Re: [keycloak-dev] Notes on KEYCLOAK-795: Move Auth Server into KC subsystem

From: "Stan Silvert" <ssilvert(a)redhat.com&gt; To: "Stian Thorgersen" <stian(a)redhat.com&gt; Cc: keycloak-dev(a)lists.jboss.org Sent: Friday, 31 October, 2014 2:10:06 PM Subject: Re: [keycloak-dev] Notes on KEYCLOAK-795: Move Auth Server into KC subsystem On 10/31/2014 8:47 AM, Stian Thorgersen wrote: > > ----- Original Message ----- >> From: "Stan Silvert" <ssilvert(a)redhat.com&gt; >> To: "Stian Thorgersen" <stian(a)redhat.com&gt; >> Cc: keycloak-dev(a)lists.jboss.org >> Sent: Friday, 31 October, 2014 1:41:59 PM >> Subject: Re: [keycloak-dev] Notes on KEYCLOAK-795: Move Auth Server into >> KC subsystem >> >> On 10/31/2014 7:55 AM, Stian Thorgersen wrote: >>>>> Stan, can we get rid of these: >>>>> 08:30:02,004 WARN [org.jboss.as.dependency.private] (MSC service >>>>> thread >>>>> 1-8) JBAS018567: Deployment "deployment.main-auth-server.war" is >>>>> using >>>>> a private module ... >>>> I don't think that's related to my PR. I think you'll see those when >>>> you deploy from the /deployments directory as well. >>>> >>>> The messages are for the jackson and httpcomponents modules. I think I >>>> can get rid of the messages if we remove the <dependencies> section from >>>> jboss-deployment-structure.xml. Those dependencies should be added using >>>> KeycloakDependencyProcessor instead. >>> Yes, it's not caused by your PR (I should have clarified that), was just >>> hoping there was some magic we could do in the subsystem to get rid of >>> those. >>> >>> Removing dependencies section would brake it when deployed as WAR though. >>> Can you modify the dependencies in the deployment-process instead? >> It would only brake when the Keycloak subsystem is not installed. You >> can still deploy as a WAR. Don't we require that anyway on WildFly/EAP >> deployments? > How about when we deploy to AS7 and EAP6? We have a subsystem for that. So we would just have to require that it's installed. > >> The other thing we could do is to install our own versions of >> httpcomponents and jackson. > Or just put them in WEB-INF/lib? We already have a few deps in there That would work too. Do we use the same WAR for WildFly and Tomcat? If so, then that's probably how we should handle it.

> >>>>> ----- Original Message ----- >>>>>> From: "Stian Thorgersen" <stian(a)redhat.com&gt; >>>>>> To: "Stan Silvert" <ssilvert(a)redhat.com&gt; >>>>>> Cc: keycloak-dev(a)lists.jboss.org >>>>>> Sent: Wednesday, 29 October, 2014 3:56:18 PM >>>>>> Subject: Re: [keycloak-dev] Notes on KEYCLOAK-795: Move Auth Server >>>>>> into >>>>>> KC subsystem >>>>>> >>>>>> I'd like to have a look at this before we merge it, but won't have >>>>>> time >>>>>> until >>>>>> tomorrow (maybe Friday). >>>>>> >>>>>> ----- Original Message ----- >>>>>>> From: "Stan Silvert" <ssilvert(a)redhat.com&gt; >>>>>>> To: keycloak-dev(a)lists.jboss.org >>>>>>> Sent: Wednesday, 29 October, 2014 3:25:55 PM >>>>>>> Subject: Re: [keycloak-dev] Notes on KEYCLOAK-795: Move Auth Server >>>>>>> into >>>>>>> KC >>>>>>> subsystem >>>>>>> >>>>>>> On 10/29/2014 10:07 AM, Bill Burke wrote: >>>>>>>> On 10/29/2014 9:28 AM, Stan Silvert wrote: >>>>>>>>> * EAP6 does not yet support all this. We should discuss >>>>>>>>> whether >>>>>>>>> or >>>>>>>>> not this functionality should be backported. >>>>>>>>> >>>>>>>> +1 for this, but maybe some focus should be on getting a more >>>>>>>> seamless >>>>>>>> "hello world" like we discussed in a previous thread? >>>>>>>> >>>>>>> I agree. IMO, the next step should be Feature Pack installation and >>>>>>> the >>>>>>> seamless "hello world". Then we look at EAP6. >>>>>>> _______________________________________________ >>>>>>> keycloak-dev mailing list >>>>>>> keycloak-dev(a)lists.jboss.org >>>>>>> https://lists.jboss.org/mailman/listinfo/keycloak-dev >>>>>>> >>>>>> _______________________________________________ >>>>>> keycloak-dev mailing list >>>>>> keycloak-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/keycloak-dev >>>>>> >>