A few things I'd like us to follow with regards to using JIRA: * Create a JIRA for all changes/fixes/improvements - unless they have no effect on users * When completing an issue mark as resolved (not closed) - we'll close when we do a release (otherwise we can't change fix version without re-opening the issue) A few things for Git: * Try to keep it to a single commit per-JIRA * Refer to JIRA issue in the commit message _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev

I don't like refer JIRA in commit message. I prefer refer it in PR. apart of that +1

-- Passos On Thu, Oct 2, 2014 at 10:54 AM, Stan Silvert <ssilvert(a)redhat.com <mailto:ssilvert@redhat.com>> wrote: +1 On 10/2/2014 3:49 AM, Stian Thorgersen wrote: > A few things I'd like us to follow with regards to using JIRA: > > * Create a JIRA for all changes/fixes/improvements - unless they have no effect on users > * When completing an issue mark as resolved (not closed) - we'll close when we do a release (otherwise we can't change fix version without re-opening the issue) > > A few things for Git: > > * Try to keep it to a single commit per-JIRA > * Refer to JIRA issue in the commit message > _______________________________________________ > keycloak-dev mailing list > keycloak-dev(a)lists.jboss.org <mailto:keycloak-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/keycloak-dev _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org <mailto:keycloak-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/keycloak-dev

If they're in the PR they're lost once it's merged, so we should put them in the commit.

----- Original Message ----- > From: "Stan Silvert" <ssilvert(a)redhat.com&gt; > To: "Daniel Passos" <daniel(a)passos.me&gt; > Cc: keycloak-dev(a)lists.jboss.org > Sent: Tuesday, 7 October, 2014 2:42:39 PM > Subject: Re: [keycloak-dev] JIRA usage > > On 10/6/2014 6:31 PM, Daniel Passos wrote: > > > > I don't like refer JIRA in commit message. I prefer refer it in PR. apart of > that +1 > Sounds reasonable to me. > > > > > -- Passos > > On Thu, Oct 2, 2014 at 10:54 AM, Stan Silvert < ssilvert(a)redhat.com > wrote: > > > +1 > > On 10/2/2014 3:49 AM, Stian Thorgersen wrote: >> A few things I'd like us to follow with regards to using JIRA: >> >> * Create a JIRA for all changes/fixes/improvements - unless they have no >> effect on users >> * When completing an issue mark as resolved (not closed) - we'll close when >> we do a release (otherwise we can't change fix version without re-opening >> the issue) >> >> A few things for Git: >> >> * Try to keep it to a single commit per-JIRA >> * Refer to JIRA issue in the commit message >> _______________________________________________ >> keycloak-dev mailing list >> keycloak-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/keycloak-dev > _______________________________________________ > keycloak-dev mailing list > keycloak-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/keycloak-dev > > > > _______________________________________________ > keycloak-dev mailing list > keycloak-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/keycloak-dev