Re: [keycloak-dev] Code and console inspection

----- Original Message ----- > From: "Bill Burke" <bburke(a)redhat.com&gt; > To: keycloak-dev(a)lists.jboss.org > Sent: Tuesday, 19 November, 2013 1:34:42 PM > Subject: Re: [keycloak-dev] Code and console inspection > > > > On 11/19/2013 8:23 AM, Viliam Rockai wrote: >> Hi all, >> >> So, I've looked at both - the code and the console UI. I've created >> bunch of JIRAs today and I still have some unclear issues. Here's my list: >> >> * What's the point of admin-ui-styles module? Why does it contain html? >> o I had troubles with this when I was working on the social page >> and some (provider helper) pages were used from this module >> instead of admin-ui module. >> > > Could be merged with admin-ui module. This is just an artifact of how > the project evolved. +1 We should have a common-styles module instead. It should only contain stylesheets/images/etc that are used by both admin and forms.

> >> * Directive naming not unified (ie. uncollapsed vs. kcInput). >> o Do we care about that (it's angularJS good practice)? I think it >> would be not just correct but even pretty to have kc prefix >> everywhere. >> >> * I see combined AngularJS + JQuery code on some places. >> o AFAIK this should be avoided unless there is no angular way how >> to solve the problem. >> > > The session timeout logic is JQuery. If you know an Angular way, feel > free to change it. Just wrap it in a directive. I believe you should never ever manipulate the DOM outside of directives. This because you're doing changes to the DOM that Angular is unaware of which can cause weird side-effects. Villiam this would be a good exercise if you haven't already written a directive ;)

> > Another placeholder. This will allow the admin to query or see which > users have sessions on an application so that they can be automatically > logged out. We should comment the link out for now, as I assume this is not something we'll implement for M1?