2:03 a.m.
Dear All,
I would like to propse a fix to the bug KEYCLOAK-6788. I have already
fixed the bug and verified that it works.
The fix includes a small function that ensures that the string given by
the user as the flow name is not empty or doesn’t contain the character
‘/’.
Should I also include the source file with this email? Eagerly waiting
to hear from you guys! Please correct me if I am wrong as I am pretty
new to opensource contribution.
Best regards,
Shiva
2:02 a.m.
Doesn't sound like you've really fixed the bug, but rather added
validation. We do not want small snippets of code everywhere to do
validation in the admin endpoints. Rather, we need a proper way of doing
validation using a validation framework that we should leverage. Hence, why
this issue is a subtask to KEYCLOAK-2355.
On Fri, 19 Oct 2018 at 09:04, Shiva Prasad Thagadur Prakash <
shiva.prasad.thagadur.prakash(a)ericsson.com> wrote:
Dear All,
I would like to propse a fix to the bug KEYCLOAK-6788. I have already
fixed the bug and verified that it works.
The fix includes a small function that ensures that the string given by
the user as the flow name is not empty or doesn’t contain the character
‘/’.
Should I also include the source file with this email? Eagerly waiting
to hear from you guys! Please correct me if I am wrong as I am pretty
new to opensource contribution.
Best regards,
Shiva
_______________________________________________
keycloak-dev mailing list
keycloak-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev
2257
days inactive
2260
days old
1 comments
2 participants
participants (2)
-
Shiva Prasad Thagadur Prakash -
Stian Thorgersen