Re: [keycloak-dev] AdapterDeploymentContextBean with custom location

Based on the other feedback and the Spring way of providing as many configuration options as possible, I think we should refactor AdapterDeploymentContextBean. However, I rather like the way Spring that divides behavior up into an interface and multiple implementations. I think we should: 1. Refactor the current AdapterDeploymentContextBean to be an interface and maybe rename it AdapterDeploymentContextFactory. 2. Split the current implementation into: a. ClasspathAdapterDeploymentContextFactory > loads from class path b. WebApplicationAdapterDeploymentContextFactory > loads from WEB-INF c. JndiAdapterDeploymentContextFactory > load from JNDI 3. The above implementations should extend AbtractAdapterDeploymentContextFactory with something like: protected loadKeycloakDeployment(Resource resource) { return KeycloakDeploymentBuilder.build(resource.getInputStream()); } That would allow anyone to provide a custom AdapterDeploymentContextFactory to load the keycloak.json from “anywhere." What do you think? Since we’re refactoring, I’d also like to take into account design multi-tentant support. I think this approach is flexible enough to add that in the future. If we agree this is a good approach you want to take a stab at it Thomas or should I? Best, Scott Scott Rossillo Smartling | Senior Software Engineer srossillo(a)smartling.com <https://app.sigstr.com/uc/55e5d41c6533390d03580000> <http://www.sigstr.com/>