----- Original Message -----
From: "Stian Thorgersen" <stian(a)redhat.com>
To: "Bill Burke" <bburke(a)redhat.com>
Cc: keycloak-dev(a)lists.jboss.org
Sent: Tuesday, January 20, 2015 12:03:59 PM
Subject: Re: [keycloak-dev] Provider modules
Why would you need jboss-deployment-structure.xml to embedded WAR?
The problem with that approach is that all providers are loaded from
the same class-loader so there would be issues if providers use different versions of the
same library. I also think it would be more natural for a WildFly user to edit
standalone.xml or use the CLI than to add dependencies to an existing module. Finally
another issue happens when someone upgrades/patches Keycloak, would they not then override
the keycloak-providers module.xml and have to add everything again?
Yes they would. That's another reason why, in general, hacking the WAR (or anything
else we ship) is a bad idea.
Plus, it drives the support guys absolutely nuts!