PR #928
by Alessio Soldano
Folks,
I've just finished pushing stuff to
https://github.com/resteasy/Resteasy/pull/928 . The goals are:
1) remove usage of tjws embedded container (which is deprecated) in our
own project; most of the tests that relied on it have already been moved
to the new testsuite are and are using Arquillian; few others (basically
those in the provider modules) are being moved soon by Martin. All
remaining stuff is basically special components or stuff that does not
go into WildFly / EAP, so won't be moved to the new testsuite area for
now. For the latter tests, the easiest approach was to modify them to
use our resteasy-netty4 server adapter (the migration to undertow would
be more difficult, as the integration API is slightly different, while
the netty4 one is basically the same as the tjws embedded server one).
2) get rid of the resteasy-jaxrs-testsuite module, which was temporary
created when tjws was moved out of resteasy-jaxrs and not has now no
reason to stay, given all its tests have already been refactored to the
new testsuite (well, except for the wadl tests, which are dealt with in
the PR here).
Any comments, just let me know. Otherwise, assuming Travis CI runs pass,
I'll merge the PR tomorrow.
Cheers
Alessio
--
Alessio Soldano
Web Service Lead, JBoss
9 years
i18n issues?
by Alessio Soldano
Hi,
while fixing an issue with i18n messages in the Vert.x server adapter
(basically the same base id of Netty4 adapter was used, hence resulting
in id clashes), I stumbled upon the i18n maven profile that can be found
in many pom.xml files in the project. Can anybody please explain
how/when that is used?
In particular, when that profile is on, I find what the
maven-resources-plugin does a bit suspicious; see for example
https://github.com/resteasy/Resteasy/blob/5b4823ff60d73fdf48f7c0b70b2b4ee...
, files from the test tree are copied into the main tree (hence
potentially polluting the built artifacts).
Thanks
Alessio
--
Alessio Soldano
Web Service Lead, JBoss
9 years
Re: [resteasy-dev] RESTEASY-1480 - JDK9 build issues
by Alessio Soldano
Thanks Antoine.
At https://github.com/resteasy/Resteasy/pull/927 you can find changes to
drop the async-http-servlet-3.0 module and move its classes into
resteasy-jaxrs module. Can you check that would actually solve
RESTEASY-1480?
Thanks
Alessio
Il 01/09/2016 11:57, Antoine Sabot-Durand ha scritto:
> Hi Alessio,
>
> Yes My PR is only a proposal to avoid having the same package in
> different jars. Merging both modules if possible would probably be a
> better approach from a migration perspective (the continuous failing
> of integration tests on my PR seems to prove that ;) ).
>
>
> Antoine
>
> On Thu, Sep 1, 2016 at 11:46 AM, Alessio Soldano <asoldano(a)redhat.com
> <mailto:asoldano@redhat.com>> wrote:
>
> Hi,
>
> Antoine created https://issues.jboss.org/browse/RESTEASY-1480
> <https://issues.jboss.org/browse/RESTEASY-1480> yesterday and is
> trying providing a PR for fixing it. I'd like to raise the topic
> here as the proposed fix would come with potential migration
> problems (judging from the changes, a lot of user would have to
> fix their apps when upgrading to new resteasy version). Any
> thoughts on this?
>
> How about we drop the async-http-servlet-3.0 module and move its
> few classes into resteasy-jaxrs module instead? That would prevent
> the package rename. Ron, Weinan, do you see any drawbacks in that
> considering the reasons that led to creating a different module in
> the past?
>
> Cheers
>
> Alessio
>
>
> --
> Alessio Soldano
> Web Service Lead, JBoss
>
>
--
Alessio Soldano
Web Service Lead, JBoss
9 years, 1 month
RESTEASY-1480 - JDK9 build issues
by Alessio Soldano
Hi,
Antoine created https://issues.jboss.org/browse/RESTEASY-1480 yesterday
and is trying providing a PR for fixing it. I'd like to raise the topic
here as the proposed fix would come with potential migration problems
(judging from the changes, a lot of user would have to fix their apps
when upgrading to new resteasy version). Any thoughts on this?
How about we drop the async-http-servlet-3.0 module and move its few
classes into resteasy-jaxrs module instead? That would prevent the
package rename. Ron, Weinan, do you see any drawbacks in that
considering the reasons that led to creating a different module in the past?
Cheers
Alessio
--
Alessio Soldano
Web Service Lead, JBoss
9 years, 1 month
