Re: [Apiman-dev] APIMAN-549 - Can't add a plugin when using postgres

Yeah I punted the problem down the road a bit. Future Brandon and Future Eric can deal with it. ;) -Eric On 7/21/2015 6:14 PM, Brandon Gaisford wrote: > Oh I see, got it. Well, that shifts the problem elsewhere then as those table creates were/are generated by the liquibase-hibernate plugin. As we try and move toward automated reconciliation of JPA entity updates within the Liquibase model, it will be a challenge if the liquibase-hibernate plugin is generating “incorrect” liquibase table create statements. Fun for another day… :) > > Brandon > > > On Jul 21, 2015, at 12:07 PM, Eric Wittmann <eric.wittmann(a)redhat.com&gt; wrote: > >> I believe the changes I made allow everything to remain database agnostic. Here are the changes: >> >> https://github.com/apiman/apiman/commit/c6f7dafd66a08bad7909a86c458f9ef92... >> >> According to liquibase documentation, I believe those may be the more appropriate column types. :) I checked the postgres file and the tables seemed reasonable to me. I haven't had a chance to give it a try. I'm hopeful. >> >> -Eric >> >> On 7/21/2015 4:10 PM, Brandon Gaisford wrote: >>> I’m glad you found some time Eric, unfortunately, I’ve been sucked into a different issue/project that’s consuming all my free time. Regarding the column datatype issues, that’s a bit of a concern as the Liquibase representation is supposed to be DB agnostic. If we’re finding that we need to make type changes per database, then I bet there is a more global way to do that. Anyway, that’s something we can address later. I know you want to get 1.1.5.Final out, thanks for copying the DDLs over to the overlay. >>> >>> The micro-service stuff sound cool! I’ll put my thinking cap for automated testing strategies. >>> >>> Laters, >>> >>> Brandon >>> >>> On Jul 21, 2015, at 5:21 AM, Eric Wittmann <eric.wittmann(a)redhat.com&gt; wrote: >>> >>>> Update: I have finally found the time to work on the DB stuff today. I am testing against mysql 5 and I've had to make some changes to this file: >>>> >>>> 010-apiman-manager-api.db.tables.changelog.xml >>>> >>>> Just column datatype changes. Hopefully it won't break postgres! But I'll let you test that out. :) >>>> >>>> For now, I'm going to use the generated DDLs to update the current approach (basically copy/paste from ddl/target into distro-wildfly8. We'll obviously need to evolve this more, but I want to do a 1.1.5.Final release and I would like these new DDLs included. >>>> >>>> Also note - there are new micro-service implementations of the apiman Manager and Gateway. These micro services are jetty based and should be easy to extend. As a result I'm adding different servers to a new apiman repository: >>>> >>>> https://github.com/apiman/apiman-servers >>>> >>>> There's nothing there right now but I'll be checking in soon, at which point there will be a mysql API Manager server and an Elasticsearch API Gateway server. These will be useful for manual testing, of course. >>>> >>>> We still need some kind of solution for more automated testing. I'm open to ideas. :) >>>> >>>> Nice job on this liquibase stuff - it's looking pretty good so far! >>>> >>>> -Eric >>>> >>>> On 7/15/2015 11:50 PM, Brandon Gaisford wrote: >>>>> Eric, >>>>> >>>>> I spent a couple hours this afternoon trying to update io.apiman.manager.test.server.ManagerApiTestServer to use an external Postgres database to run the maven tests against. I wasn’t successful and ran out of time today. I’m currently stuck as JPA is throwing “Transaction not active” errors. I was hoping I could get this done today and help with the testing/validation effort against the new DDLs, but unfortunately not. Sorry dude, I tried. I’ll pick it up again tomorrow as I have time unless you come up with a better approach. >>>>> >>>>> Laters, >>>>> >>>>> Brandon >>>>> >>>>> >>>>> _______________________________________________ >>>>> Apiman-dev mailing list >>>>> Apiman-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/apiman-dev >>>>> >>> >>> >>> _______________________________________________ >>> Apiman-dev mailing list >>> Apiman-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/apiman-dev >>> > > > _______________________________________________ > Apiman-dev mailing list > Apiman-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/apiman-dev >