Re: [keycloak-dev] Client ID and Client ClientID - I propose we remove one

+1 for this change. I am just not sure if we should set the "id" to the current value of "client-id" ? Few things to note: - SAML clients currently use clientId in form of URL. For example in SAML demo there are clientIds like "http://localhosT:8080/employee-sig" . I don't know if it's requirement, maybe it's possible to solve it somehow (ie. introduce different attribute for SAML client to store these URLs). But from what I remember, Bill changed admin console to use "id" instead of "clientId" because there were issues with URL-like clientId in admin console . So if we overwrite the "id" with current "client-id" the issue will be back. - Migration might be a pain. Many tables (roles, protocolMappers, user consents, offline clientSessions ...) references client by "id" . Overwriting "id" with "client-id" means that we will need to change all those DB records. And there are things like foreign keys etc... Shouldn't do vice-versa and just remove current "client-id" and ask people to update their keycloak.json adapter configurations? On the other hand, removing "client-id" might break migration of JSON exported realms as the JSON entities are using "client-id" for referencing client. It seems the migration will be a pain regardless of whatever direction we choose :-( Marek On 16/11/15 14:54, Stian Thorgersen wrote: