8:40 a.m.
Hi,
Would like to know your thoughts about which model implementations I must support for
the authz model. Both Database/JPA and MongoDB ?
Regards.
Pedro Igor
3:15 a.m.
For now - which ever you want. I propose you introduce a new SPI though.
Once it's beyond a POC then both :/
On 14 October 2015 at 15:40, Pedro Igor Silva <psilva(a)redhat.com> wrote:
Hi,
Would like to know your thoughts about which model implementations I
must support for the authz model. Both Database/JPA and MongoDB ?
Regards.
Pedro Igor
_______________________________________________
keycloak-dev mailing list
keycloak-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev
8:07 a.m.
Yeah, I've talked with Bolek as well and we discussed about focusing on JPA (which I
was already using) for now, but still provide a SPI for future implementations.
From a SPI perspective, I did something very simple without KC's
org.keycloak.provider.Spi. The main reason for this decision is that Spis in KC are not
loaded when defined within a custom provider and I'm trying to minimize changes in KC
itself.
However, if necessary, I can provide some minor changes to make that happen. So Spis can
also be loaded from custom providers.
Thanks.
----- Original Message -----
From: "Stian Thorgersen" <sthorger(a)redhat.com>
To: "Pedro Igor Silva" <psilva(a)redhat.com>
Cc: "keycloak dev" <keycloak-dev(a)lists.jboss.org>
Sent: Friday, October 16, 2015 5:15:56 AM
Subject: Re: [keycloak-dev] Authz Model Implementation
For now - which ever you want. I propose you introduce a new SPI though.
Once it's beyond a POC then both :/
On 14 October 2015 at 15:40, Pedro Igor Silva <psilva(a)redhat.com> wrote:
Hi,
Would like to know your thoughts about which model implementations I
must support for the authz model. Both Database/JPA and MongoDB ?
Regards.
Pedro Igor
_______________________________________________
keycloak-dev mailing list
keycloak-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev
12:18 p.m.
On 10/16/2015 9:07 AM, Pedro Igor Silva wrote:
Yeah, I've talked with Bolek as well and we discussed about
focusing on JPA (which I was already using) for now, but still provide a SPI for future
implementations.
>From a SPI perspective, I did something very simple without KC's
org.keycloak.provider.Spi. The main reason for this decision is that Spis in KC are not
loaded when defined within a custom provider and I'm trying to minimize changes in KC
itself.
How could the org.keycloak.provider.Spi not work? It uses the
META-INF/services pattern to locate new and old Spis. Nothing magical
there. Your jar just needs to be loaded into the appropriate modules.
--
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com
2:19 p.m.
I'm not saying it does not work, but in my case I have a specific module with all the
authz stuff. There I'm already using Spis from KC such as JpaConnectionProvider,
extension to admin rest api, etc. That is fine and everything is perfect.
The problem I'm facing is how to tell KC to load Spis from my module without change a
bit in KC modules or change code. If you see
org.keycloak.services.DefaultKeycloakSessionFactory#init, Spis are loaded from
getClass().getClassLoader(). Considering that my Spis are in a different classloader, they
will never be loaded.
A simple solution for that would be to do something similar as when loading providers, so
you could also consider the classloaders from the providers when loading Spis.
----- Original Message -----
From: "Bill Burke" <bburke(a)redhat.com>
To: keycloak-dev(a)lists.jboss.org
Sent: Friday, October 16, 2015 2:18:22 PM
Subject: Re: [keycloak-dev] Authz Model Implementation
On 10/16/2015 9:07 AM, Pedro Igor Silva wrote:
Yeah, I've talked with Bolek as well and we discussed about
focusing on JPA (which I was already using) for now, but still provide a SPI for future
implementations.
>From a SPI perspective, I did something very simple without KC's
org.keycloak.provider.Spi. The main reason for this decision is that Spis in KC are not
loaded when defined within a custom provider and I'm trying to minimize changes in KC
itself.
How could the org.keycloak.provider.Spi not work? It uses the
META-INF/services pattern to locate new and old Spis. Nothing magical
there. Your jar just needs to be loaded into the appropriate modules.
--
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com
_______________________________________________
keycloak-dev mailing list
keycloak-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev
1:33 a.m.
On 16 October 2015 at 21:19, Pedro Igor Silva <psilva(a)redhat.com> wrote:
I'm not saying it does not work, but in my case I have a specific
module
with all the authz stuff. There I'm already using Spis from KC such as
JpaConnectionProvider, extension to admin rest api, etc. That is fine and
everything is perfect.
The problem I'm facing is how to tell KC to load Spis from my module
without change a bit in KC modules or change code. If you see
org.keycloak.services.DefaultKeycloakSessionFactory#init, Spis are loaded
from getClass().getClassLoader(). Considering that my Spis are in a
different classloader, they will never be loaded.
A simple solution for that would be to do something similar as when
loading providers, so you could also consider the classloaders from the
providers when loading Spis.
That works - we should be able to look in modules and classpath entries for
SPIs like we do for providers. Prepare a PR and we'll merge it.
----- Original Message -----
From: "Bill Burke" <bburke(a)redhat.com>
To: keycloak-dev(a)lists.jboss.org
Sent: Friday, October 16, 2015 2:18:22 PM
Subject: Re: [keycloak-dev] Authz Model Implementation
On 10/16/2015 9:07 AM, Pedro Igor Silva wrote:
> Yeah, I've talked with Bolek as well and we discussed about focusing on
JPA (which I was already using) for now, but still provide a SPI for future
implementations.
>
>>From a SPI perspective, I did something very simple without KC's
org.keycloak.provider.Spi. The main reason for this decision is that Spis
in KC are not loaded when defined within a custom provider and I'm trying
to minimize changes in KC itself.
>
How could the org.keycloak.provider.Spi not work? It uses the
META-INF/services pattern to locate new and old Spis. Nothing magical
there. Your jar just needs to be loaded into the appropriate modules.
--
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com
_______________________________________________
keycloak-dev mailing list
keycloak-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev
_______________________________________________
keycloak-dev mailing list
keycloak-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev
3682
days inactive
3687
days old
5 comments
3 participants
participants (3)
-
Bill Burke -
Pedro Igor Silva -
Stian Thorgersen