From: "Bill Burke" <bburke(a)redhat.com&gt; To: keycloak-dev(a)lists.jboss.org Sent: Monday, 3 November, 2014 4:15:17 PM Subject: Re: [keycloak-dev] Support both Jackson and Jackson 2 Why is 811 a problem? We can just ship jackson 1.9.x

On 11/3/2014 9:05 AM, Stian Thorgersen wrote: > Currently we only support Jackson, while WildFly now uses Jackson 2. This > is OK for our the auth-server itself, but could be more problematic for > applications (see https://issues.jboss.org/browse/KEYCLOAK-811). > > The main reason we can't use Jackson 2 is that they have changed the > package for annotations (@JsonProperty). I propose we get rid of all > @JsonProperty and instead make sure all fields are named correct and that > we set the LowerCaseWithUnderscoresStrategy on the ObjectMapper. This > should also make it possible to use the Java classes with other JSON > libraries. > > For example: > > @JsonProperty("access_token") > protected String token; > > @JsonProperty("jti") > protected String id; > > Becomes: > > protected String accessToken; > > protected String jti; > _______________________________________________ > keycloak-dev mailing list > keycloak-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/keycloak-dev > -- Bill Burke JBoss, a division of Red Hat http://bill.burkecentral.com _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev

From: "Bill Burke" <bburke(a)redhat.com&gt; To: "Stian Thorgersen" <stian(a)redhat.com&gt; Cc: keycloak-dev(a)lists.jboss.org Sent: Monday, 3 November, 2014 4:26:58 PM Subject: Re: [keycloak-dev] Support both Jackson and Jackson 2 On 11/3/2014 10:23 AM, Stian Thorgersen wrote: > > ----- Original Message ----- >> From: "Bill Burke" <bburke(a)redhat.com&gt; >> To: keycloak-dev(a)lists.jboss.org >> Sent: Monday, 3 November, 2014 4:15:17 PM >> Subject: Re: [keycloak-dev] Support both Jackson and Jackson 2 >> >> Why is 811 a problem? We can just ship jackson 1.9.x > > What about folks that use Jackson 2 in their applications and want to use > our adapter? > Shouldn't be a problem. Different 1.9.x/2.x are different packages and our adapter doesn't use JAX-RS provider. So there should be no clashes.

-- Bill Burke JBoss, a division of Red Hat http://bill.burkecentral.com

From: "Bill Burke" <bburke(a)redhat.com&gt; To: "Stian Thorgersen" <stian(a)redhat.com&gt; Cc: keycloak-dev(a)lists.jboss.org Sent: Monday, 3 November, 2014 4:44:12 PM Subject: Re: [keycloak-dev] Support both Jackson and Jackson 2 On 11/3/2014 10:43 AM, Stian Thorgersen wrote: > > > ----- Original Message ----- >> From: "Bill Burke" <bburke(a)redhat.com&gt; >> To: "Stian Thorgersen" <stian(a)redhat.com&gt; >> Cc: keycloak-dev(a)lists.jboss.org >> Sent: Monday, 3 November, 2014 4:26:58 PM >> Subject: Re: [keycloak-dev] Support both Jackson and Jackson 2 >> >> >> >> On 11/3/2014 10:23 AM, Stian Thorgersen wrote: >>> >>> ----- Original Message ----- >>>> From: "Bill Burke" <bburke(a)redhat.com&gt; >>>> To: keycloak-dev(a)lists.jboss.org >>>> Sent: Monday, 3 November, 2014 4:15:17 PM >>>> Subject: Re: [keycloak-dev] Support both Jackson and Jackson 2 >>>> >>>> Why is 811 a problem? We can just ship jackson 1.9.x >>> >>> What about folks that use Jackson 2 in their applications and want to use >>> our adapter? >>> >> >> Shouldn't be a problem. Different 1.9.x/2.x are different packages and >> our adapter doesn't use JAX-RS provider. So there should be no clashes. > > True, so actually 811 is only a problem for admin client java api as it's > using ResteasyClientBuilder. I guess we can quite easily make sure that > always uses Jackson provider? > > As Jackson is becoming old, would it make sense that we swap to Jackson2? > Or would it not be possible to do that on AS7/EAP6? > Not a technical problem at all, but you know how our productization is.

-- Bill Burke JBoss, a division of Red Hat http://bill.burkecentral.com