Hi Ron,
Il 06/09/2016 20:28, Ron Sigal ha scritto:
On 09/05/2016 08:50 AM, Alessio Soldano wrote:
> Thanks Ron.
> I've thought a bit about this; avoiding copying those resources is not
> easily doable due to classloading issues; so I would propose the changes
> that you can see at
https://github.com/resteasy/Resteasy/pull/926 (I
> just modified the resteasy-netty4 module, if we agree on this I can fix
> all other modules). The most important change is to run the resources
> cleanup in prepare-package maven phase, so that a mvn package / mvn
> install / mvn integration-test run does not leave the project "dirty"
> with test resources in the main tree (no need to rely on next mvn clean
> run).
Sounds good. Don't know why I didn't think of that ...
OK, thanks. I'm
checking if what Martin just proposed is doable (all
i18n test together, so that we do not have to run 50+ forked tests),
otherwise I'll go ahead as mentioned above.
> On top of that I would refactor all TestMessages_* test into
> I18nTestMessages_* in order to run them in a separate maven surefire
> execution; that way only the i18n tests would need to run in fork mode.
I could be wrong, but I think that, in branch 3.0.x, at least, all of
the i18n tests would be in org/jboss/resteasy/test/i18n/**. That may not
be true after refactoring, though.
That's still the case afaics; however the
problem is that TestMessages_*
matches the default inclusion filter of surefire; if you exclude it in
the default configuration, including it in an additional surefire
execution does not work. That's why I thought about I18nTestMessages
prefix, so that we only need to include that in the additional executions.
Cheers
Alessio
--
Alessio Soldano
Web Service Lead, JBoss