Re: [resteasy-dev] RESTEasy providers tests refactoring

Hello Alessio, thanks for the response. >> Is reuseForks strictly required for i18n testing? Can you briefly explain >> why? As far as I understand the JVM restart is required to load / setup new locale, that's why the reuseForks is used. >> how long is "too long" here? I think it was something about 1 hour and 20 minutes :) >> Would having different profiles only for tests requiring reuseForks=false >> be an option? This could be a solution. It only needs a proper order in inclusions and exclusions in other profiles too, but I think it can work just fine :)

Martin Stefanko Associate Software Engineer JBoss Sustaining Engineering Team Red Hat Czech s.r.o. On Fri, Aug 26, 2016 at 11:08 AM, Alessio Soldano < asoldano(a)redhat.com > wrote: Hi Martin, I'm cc-ing the public resteasy-dev list as this is something other contributors might be interested in and/or have comments about. Il 22/08/2016 15:33, Martin Stefanko ha scritto: I started moving test from individual providers into the testsuite and I would like to ask you for your opinion on a few things. 1. Would it be better if I'll do a separate commit / PR for each provider respectively or one huge commit? As you feel is better 2. I started with jaxb, there are two packages that I am not really sure that are necessary in the testsuite [1]. Those might simply be leftovers from my initial efforts of removing duplicated stuff in the testsuite. If you find test classes or resources that are not used anywhere, please simply delete them. 3. I discussed with Ron problem with internationalization testing which is using <reuseForks>false</reuseForks>. I made a separate profile for i18n testing but it is taking far too long to execute. I am looking for some way to specify surefire configuration on more detailed level (test or category). Maybe it would be better to make an optional module for it. Interesting topic. Generally speaking, in the long term I would like to get rid of reuseForks=false anywhere it's possible (basically because that can hide code side effects). Is reuseForks strictly required for i18n testing? Can you briefly explain why? how long is "too long" here? Would having different profiles only for tests requiring reuseForks=false be an option? Cheers Alessio Thank you. [1] https://github.com/resteasy/Resteasy/tree/master/providers/jaxb/src/test/... https://github.com/resteasy/Resteasy/tree/master/providers/jaxb/src/test/... Martin Stefanko Associate Software Engineer JBoss Sustaining Engineering Team Red Hat Czech s.r.o. -- Alessio Soldano Web Service Lead, JBoss _______________________________________________ resteasy-dev mailing list resteasy-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/resteasy-dev