Re: [keycloak-dev] examples/distro reworked/improved/finalized PLEASE TRY!
Is the only difference between the 3 examples the name of the adapter in
jboss-deployment-structure?
If so could we not do either:
* Maven profiles to template these files with the adapter module name
* Use same module name for the adapters?
That would make it a lot easier to make sure the examples are in-sync.
----- Original Message -----
From: "Bill Burke" <bburke(a)redhat.com>
To: "Stian Thorgersen" <stian(a)redhat.com>
Cc: keycloak-dev(a)lists.jboss.org
Sent: Thursday, 9 January, 2014 4:23:50 PM
Subject: Re: [keycloak-dev] examples/distro reworked/improved/finalized PLEASE TRY!
On 1/9/2014 10:18 AM, Stian Thorgersen wrote:
> I haven't had much time to play with this yet, but will do today/tomorrow.
> Although if you're not accepting PRs after today, there may not be any
> point? There's two outstanding PRs related to examples are you going to
> merge those?
>
> Some comments on the distributions:
>
> Instead of having these download bundles I think it would be better to have
> downloads for each individual thing:
>
> keycloak-bundle-<version>.zip
>
> - keycloak-<version>
> - bin
> - deployments/auth-server.war (exploded)
> - ..
>
> keycloak-war.zip
>
> - auth-server.war (exploded)
> - auth-server.war.dodeploy
> - keycloak-ds.xml
>
> keycloak-wildfly-adapter.zip
> keycloak-eap-adapter.zip
> keycloak-as7-adapter.zip
>
Poms are set up to do this so not a problem.
> Reason for this is that it allows devs to download what they want rather
> than a huge bundle. For example:
>
> * To install the server all you want is the server
> * If running Keycloak on OpenShift all you need is the one adapter for
> whatever application server you're using
>
> We could move examples into a separate github project and the documentation
> would instruct people to get it from there. That way we can add/edit
> examples after a release. This is the way JDF does it, and I would think
> that eventually Keycloak examples would be moved into there.
>
Not everybody knows how to use Github :) Plus, you need examples tied
to release versions as there may be differences between them.
> It may also be good to have these zips available in Maven central as that
> makes it simpler for other projects to build their own distributions that
> includes Keycloak. I can imagine AeroGear guys may be interested in that.
>
Simple enough.
--
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com