Hi Guys, Any comments on this? Thanks & regards, Shiva On pe, 2019-07-05 at 10:52 +0000, Shiva Prasad Thagadur Prakash wrote: > Hi Guys, > > Feedback welcomed. > > I have tried fixing the bug with ID "KEYCLOAK-10022" (https://protect > 2.fireeye.com/url?k=2125cd3b-7dafeff4-21258da0-0cc47ad93ea4- > 5132ff9b2e7863aa&q=1&u=https%3A%2F%2Fissues.jb%2F > oss.org/browse/KEYCLOAK-10022). It was due to a wrong flag being > checked to decide whether the admin events has to be raised or not. > > For example, in file PolicyResourceService.java at line number 260, > the > flag "authorization.getRealm().isAdminEventsEnabled()" is being > checked > before raising the admin event. Actually, this flag is used to > identify > whether the admin events are to be saved or not saved and not to > identify whether admin events are to be raised or not raised. > > The fix is to remove the if condition that checks for this flag > before > raising the admin events. The same fix applies in few other > files: PolicyService.java, ResourceSetService.java and > ScopeService.java. I have verified the fix and after the fix I am > able > to see the missing admin events. > > Do you guys agree with the proposed fix? Can I raise a pull request? > Eagerly waiting to hear from you. > > Thanks & regards, > Shiva > > _______________________________________________ > keycloak-dev mailing list > keycloak-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/keycloak-dev _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev