In the keycloak-server module, the keycloak-server.json file refers to the ExampleDS datasource[1] instead of KeycloakDS, which is used everywhere in the distribution. If we change this in the main build then we won't need to use the replacer[2] plugin in the dist. But before I push the change I'm wondering if there was a reason it was done that way? Nothing seems to break in the tests when I change it. Should I go ahead push the change? Stan [1] https://github.com/keycloak/keycloak/blob/master/server/src/main/resource... [2] https://github.com/keycloak/keycloak/blob/master/distribution/war-zip/pom... _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev

The reason we had it like this is so you can deploy the server WAR to a plain WildFly without adding the datasource. I'm all for changing it, at least personally I very rarely deploy it this way and can easily create the datasource when I do. ----- Original Message ----- > From: "Bill Burke" <bburke(a)redhat.com&gt; > To: keycloak-dev(a)lists.jboss.org > Sent: Thursday, 14 August, 2014 10:32:27 PM > Subject: Re: [keycloak-dev] keycloak-server.json > > It should refer to KeycloakDS. It is not a good practice to use > ExampleDS as this is something the user will want to change probably. > > > On 8/14/2014 1:29 PM, Stan Silvert wrote: >> In the keycloak-server module, the keycloak-server.json file refers to >> the ExampleDS datasource[1] instead of KeycloakDS, which is used >> everywhere in the distribution. If we change this in the main build >> then we won't need to use the replacer[2] plugin in the dist. >> >> But before I push the change I'm wondering if there was a reason it was >> done that way? Nothing seems to break in the tests when I change it. >> >> Should I go ahead push the change? >> >> Stan >> >> [1] >> https://github.com/keycloak/keycloak/blob/master/server/src/main/resource... >> [2] >> https://github.com/keycloak/keycloak/blob/master/distribution/war-zip/pom... >> _______________________________________________ >> keycloak-dev mailing list >> keycloak-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/keycloak-dev >> > -- > Bill Burke > JBoss, a division of Red Hat > http://bill.burkecentral.com > _______________________________________________ > keycloak-dev mailing list > keycloak-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/keycloak-dev > _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev