Hi all, When I was looking at the build issue: https://issues.jboss.org/browse/RESTEASY-1425, I thought the examples module should be moved to another repository (for example, name it to resteasy-examples) to make resteasy build run faster. From travis build log, remove these modules can save us about 3 mins build time. If there is some important thing should be checked in these examples, we can change to a test and add it in resteasy repo, not package war file , start/stop Jetty in resteasy build. Besides this, I think these examples only need to run against resteasy release version. WDYT? Cheers, Jim _______________________________________________ resteasy-dev mailing list resteasy-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/resteasy-dev

Hi Alessio, If you look at these examples, all the test scenarios are already covered in resteasy testsuite . Let me give some examples : jaxrs-2.0.-workbook-ex03_1 demonstrated the usage of @Path, @GET, PUT, POST, and @PathParam. Almost each resteasy test is using some of these annotation or all above annotations. jaxrs-2.0.-workbook-ex04_1 is showing usage how to create your own HTTP method annotation. This feature is already tested by org.jboss.resteasy.test.client.SyncInvoketest jaxrs-2.0-workbook-ex09_1 demonstrates the client accept media type to pick between XML and JSON. And this is already checked by org.jboss.resteasy.test.resteasy1296.ValidationThroughRestIT. jaxrs-2.0-workbook-ex11-1 is showing the usage of CacheControl and Request.evaluatePreconditions(). We can find this is already verified by org.jboss.resteasy.test.client.cache.ClientCacheTest. Each example's demonstration usage can be found in resteasy testsuite and It is checking the duplicate things if we run this in the build, so I don't think there is any issue will be introduced if we move all examples dir to resteasy-examples repo too. Cheers, Jim On 06/29/2016 11:07 PM, Alessio Soldano wrote: > Hi Jim, > we previously discussed a bit about this topic. I believe we should > keep the oreilly-jaxrs-2.0-workbook examples there because they cover > basic jaxrs 2.0 scenarios. Having the examples be automatically run > in the build ensures no regressions happen. We already have the > resteasy-examples repo, which we moved a bunch of examples to (and > which needs to be fixed, while the workbook ones just run fine ;) ). > As for the other examples (war-tests) I agree on turning them into > plain integration tests. > > Regarding RESTEASY-1425, that can possibly be fixed by moving the > jetty-plugin to a profile that is only enabled if -DskipTests=true is > not specified. > Cheers > Alessio > > Il 29/06/2016 11:40, Jim Ma ha scritto: >> Hi all, >> When I was looking at the build issue: >> https://issues.jboss.org/browse/RESTEASY-1425, I thought the examples >> module should be moved to another repository (for example, name it to >> resteasy-examples) to make resteasy build run faster. From travis build >> log, remove these modules can save us about 3 mins build time. If there >> is some important thing should be checked in these examples, we can >> change to a test and add it in resteasy repo, not package war file , >> start/stop Jetty in resteasy build. Besides this, I think these examples >> only need to run against resteasy release version. WDYT? >> Cheers, >> Jim >> _______________________________________________ >> resteasy-dev mailing list >> resteasy-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/resteasy-dev > > > -- > Alessio Soldano > Web Service Lead, JBoss > > > _______________________________________________ > resteasy-dev mailing list > resteasy-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/resteasy-dev