[JBoss JIRA] (ARQ-1647) Allow Executor to set process exit code
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/ARQ-1647?page=com.atlassian.jira.plugin.s... ]
Karel Piwko updated ARQ-1647:
-----------------------------
Fix Version/s: spacelift_1.0.0.Alpha2
> Allow Executor to set process exit code
> ---------------------------------------
>
> Key: ARQ-1647
> URL: https://issues.jboss.org/browse/ARQ-1647
> Project: Arquillian
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Extension - Spacelift
> Affects Versions: spacelift_1.0.0.Alpha1
> Reporter: Karel Piwko
> Fix For: spacelift_1.0.0.Alpha2
>
>
> Currently, it is not possible to setup exit code for external process. This makes handling of execution failure quite complicated.
> Figure out what API should be used to let user define allowed exit values. 0 is to be kept as default value. Additionally, there might be multiple values to be set.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 1 month
[JBoss JIRA] (ARQ-1744) Provide metadata storage in DroneContext
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/ARQ-1744?page=com.atlassian.jira.plugin.s... ]
Karel Piwko closed ARQ-1744.
----------------------------
> Provide metadata storage in DroneContext
> ----------------------------------------
>
> Key: ARQ-1744
> URL: https://issues.jboss.org/browse/ARQ-1744
> Project: Arquillian
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Extension - Drone
> Affects Versions: drone_2.0.0.Alpha1
> Reporter: Karel Piwko
> Assignee: Tadeas Kriz
> Fix For: drone_2.0.0.Alpha2
>
>
> Other extensions might want to store additional data next to Drone callable/instance and its configuration.
> It would be convenient to expose key:String and value:Object storage for storing metadata directly in DroneContext.
> It is not needed to solve conflict anyhow.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 1 month
[JBoss JIRA] (ARQ-1745) Rename InjectionPoint
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/ARQ-1745?page=com.atlassian.jira.plugin.s... ]
Karel Piwko closed ARQ-1745.
----------------------------
> Rename InjectionPoint
> ---------------------
>
> Key: ARQ-1745
> URL: https://issues.jboss.org/browse/ARQ-1745
> Project: Arquillian
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Extension - Drone
> Affects Versions: drone_2.0.0.Alpha1
> Reporter: Karel Piwko
> Assignee: Tadeas Kriz
> Fix For: drone_2.0.0.Alpha2
>
>
> InjectionPoint is already in Arquillian SPI. Rather, follow the conventions and rename it to DronePoint.
> There is already InjectionPoint and EventPoint in Drone. Having a DronePoint makes perfect sense using this optics.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 1 month
[JBoss JIRA] (ARQ-1747) Move InjectionPoint one level up in DroneContext
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/ARQ-1747?page=com.atlassian.jira.plugin.s... ]
Karel Piwko closed ARQ-1747.
----------------------------
> Move InjectionPoint one level up in DroneContext
> ------------------------------------------------
>
> Key: ARQ-1747
> URL: https://issues.jboss.org/browse/ARQ-1747
> Project: Arquillian
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Extension - Drone
> Affects Versions: drone_2.0.0.Alpha1
> Reporter: Karel Piwko
> Assignee: Tadeas Kriz
> Fix For: drone_2.0.0.Alpha2
>
>
> Instead of having
> {code}
> context.getDrone(InjectionPoint<?>)
> context.getDroneConfiguration(InjectionPoint<?>)
> {code}
> provide rather
> {code}
> context.get(InjectionPoint<?>).getInstance() // type defined by IP
> context.get(InjectionPoint<?>).getInstanceAs(Class<?>)
> context.get(InjectionPoint<?>).getConfigurationAs(Class<?>)
> context.get(InjectionPoint<?>).getMetadataAs(String, Class<?>)
> {code}
> Implementation note: We might provide NullInjectionPoint to avoid people doing null checks. Or, we can throw exception instead.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 1 month
[JBoss JIRA] (ARQ-1771) Putting custom annotation on Drone creates multiple instances
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/ARQ-1771?page=com.atlassian.jira.plugin.s... ]
Karel Piwko closed ARQ-1771.
----------------------------
> Putting custom annotation on Drone creates multiple instances
> -------------------------------------------------------------
>
> Key: ARQ-1771
> URL: https://issues.jboss.org/browse/ARQ-1771
> Project: Arquillian
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Extension - Drone
> Affects Versions: drone_2.0.0.Alpha1
> Reporter: Stefan Miklosovic
> Fix For: drone_2.0.0.Alpha2
>
>
> I have a test case like this
> {code}
> @RunWith(Arquillian.class)
> @RunAsClient
> public class SomeTestCase
> {
> @Drone
> @Mobile
> @Custom
> private WebDriver mobile;
> // tests
> }
> {code}
> where @Custom is just an annotation:
> {code}
> @Retention(RetentionPolicy.RUNTIME)
> @Target({ ElementType.FIELD, ElementType.PARAMETER })
> public @interface Custom {
> }
> {code}
> it is _not_ annotated with @Qualifier.
> Realize that the same problem arise when using @OperateOnDeployment from Arquillian which is not annotated with @Qualifier neither.
> I am getting this:
> http://pastebin.com/raw.php?i=i9DVqeaC
> You see that InstrumentationPerformDecider.decidePerformingInstrumentation observes BeforeDroneInstantiated so when it is treated twice, you are going to instantiate two Drones which is another argument why Drone does it wrong.
> When I declare Drone injection like that, it results into two instances of WebDrivers so that means it instruments Android package twice with two Selendroids so that mean I am getting NoUniqueWebDriverException when I want to start some activity because from now on you have "by accident" two webdrivers instrumenting the same deployment as a result of a bug where putting custom annotation on Drone instantiates it twice.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 1 month