[JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml
by Gerhard Poul (JIRA)
[ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.s... ]
Gerhard Poul updated ARQ-2051:
------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
> Key: ARQ-2051
> URL: https://issues.jboss.org/browse/ARQ-2051
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.Beta2
> Reporter: arjan tijms
> Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
7 years, 6 months
[JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml
by arjan tijms (JIRA)
[ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.s... ]
arjan tijms commented on ARQ-2051:
----------------------------------
Great to hear you're making progress with that issue and thanks for the update!
> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
> Key: ARQ-2051
> URL: https://issues.jboss.org/browse/ARQ-2051
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.Beta2
> Reporter: arjan tijms
> Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
7 years, 6 months
[JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml
by Gerhard Poul (JIRA)
[ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.s... ]
Gerhard Poul commented on ARQ-2051:
-----------------------------------
[~atijms] I found the root-cause and will probably be able to get this working over the weekend and finally make progress on your pull request. Sorry for the delay.
> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
> Key: ARQ-2051
> URL: https://issues.jboss.org/browse/ARQ-2051
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.Beta2
> Reporter: arjan tijms
> Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
7 years, 6 months
[JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml
by arjan tijms (JIRA)
[ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.s... ]
arjan tijms commented on ARQ-2051:
----------------------------------
Thanks for looking into the PR Gerhard.
I was seeing the {{com.ibm.websphere.application.ApplicationMBean}} indeed. The java version I used for the test was:
{noformat}
java -version
java version "1.8.0_102"
Java(TM) SE Runtime Environment (build 1.8.0_102-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.102-b14, mixed mode)
{noformat}
Liberty version is the latest from Maven; 16.0.0.3. OS is OS X.
For the test I used the Soteria project (https://github.com/javaee-security-spec/soteria) where I removed the ant runt plug-in from line 409 onwards, see: https://github.com/javaee-security-spec/soteria/blob/master/test/pom.xml#...
Then with the Liberty managed container that incorporated the PR installed I did:
{noformat}
mvn clean test install -Pliberty,bundled
{noformat}
_(just "install" should be sufficient but that was the exact command used)_
So it's a "plain" Liberty install without using Docker, wrecker or the Liberty maven plug-in.
Hope this helps.
> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
> Key: ARQ-2051
> URL: https://issues.jboss.org/browse/ARQ-2051
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.Beta2
> Reporter: arjan tijms
> Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
7 years, 6 months
[JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml
by Gerhard Poul (JIRA)
[ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.s... ]
Gerhard Poul commented on ARQ-2051:
-----------------------------------
I've now created a new docker container that works with the current wercker environment and I also moved to the 1.2 version of the liberty-maven-plugin. The bad news is that at least for me the ApplicationMBean is never shown over the localConnector with the versions I tested with from the public maven repositories. I see a few other WebSphere:* MBeans, but not the ApplicationMBean.
[~atijms] are you seeing this MBean? Can you tell me which exact JDK and liberty version you're using? tnx!
> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
> Key: ARQ-2051
> URL: https://issues.jboss.org/browse/ARQ-2051
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.Beta2
> Reporter: arjan tijms
> Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
7 years, 6 months
[JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml
by Gerhard Poul (JIRA)
[ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.s... ]
Gerhard Poul commented on ARQ-2051:
-----------------------------------
>From a conceptual point of view this is just moving stuff from server.xml into arquillian.xml and it removes the need to use the liberty:create-server module in this specific case.
I'm fine with adding this for people that prefer not to use the liberty:create-server module since the localConnector is a prerequisite for the arquillian container working, but I'd rather not duplicate functionality that is available in the liberty:create-server plugin like setting JVM parameters and others and just moving them into arquillian.xml without a good reason.
FYI: At this point in time our CI tests on wercker seem not to be working because they changed how they work with the docker containers. I'll need to fix that first before I can test and merge your PR.
> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
> Key: ARQ-2051
> URL: https://issues.jboss.org/browse/ARQ-2051
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.Beta2
> Reporter: arjan tijms
> Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
7 years, 6 months
[JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml
by arjan tijms (JIRA)
[ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.s... ]
arjan tijms edited comment on ARQ-2051 at 10/24/16 6:03 PM:
------------------------------------------------------------
Hi Gerhard, thanks for your comments.
{quote}How are you downloading the liberty instance from Maven?{quote}
See for example https://github.com/javaee-samples/javaee7-samples/blob/master/pom.xml#L962
It's basically the same method that the other profiles for other servers use as well.
{quote}Why is this more useful than that?{quote}
Packaging a copy of the server.xml file and then copying it over is quite a bit more work and less obvious than just setting a boolean. Ideally for the managed server variant this would even be the default (if I'm not mistaken TomEE does something like that).
{quote}I would think that if we start adding this, we will need further changes to support other features{quote}
Adding arbitrary other features (as in feature elements) would be rather trivial to support. The {{addFeatures}} method in the PR is already prepared for that. With that setting something like {{extraFeatures=usr:JaccFeature,JPA-1.0}} depending on conditions in the test setup is a bit higher level and more flexible than having to prepare a set of different full server.xml files for every combination.
As a followup issue and PR I wanted to do something like as suggested here: http://stackoverflow.com/questions/39259375/loading-data-source-for-datas...
That is, adding a jar from from the archive (or project) that's being deployed as a shared library (<library> tag) and then let the application reference that via the existing {{commonLibraryRef}} support. Doing that all in various combinations with static server.xml files may be a bit too much.
was (Author: atijms):
Hi Gerhard, thanks for your comments.
{quote}How are you downloading the liberty instance from Maven?{quote}
See for example https://github.com/javaee-samples/javaee7-samples/blob/master/pom.xml#L962
It's basically the same method that the other profiles for other servers use as well.
{quote}Why is this more useful than that?{quote}
Packaging a copy of the server.xml file and then copying it over is quite a bit more work and less obvious then just setting a boolean. Ideally for the managed server variant this would even be the default (if I'm not mistaken TomEE does something like that).
{quote}I would think that if we start adding this, we will need further changes to support other features{quote}
Adding arbitrary other features (as in feature elements) would be rather trivial to support. The {{addFeatures}} method in the PR is already prepared for that. With that setting something like {{extraFeatures=usr:JaccFeature,JPA-1.0}} depending on conditions in the test setup is a bit higher level and more flexible than having to prepare a set of different full server.xml files for every combination.
As a followup issue and PR I wanted to do something like as suggested here: http://stackoverflow.com/questions/39259375/loading-data-source-for-datas...
That is, adding a jar from from the archive (or project) that's being deployed as a shared library (<library> tag) and then let the application reference that via the existing {{commonLibraryRef}} support. Doing that all in various combinations with static server.xml files may be a bit too much.
> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
> Key: ARQ-2051
> URL: https://issues.jboss.org/browse/ARQ-2051
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.Beta2
> Reporter: arjan tijms
> Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months
[JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml
by arjan tijms (JIRA)
[ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.s... ]
arjan tijms commented on ARQ-2051:
----------------------------------
Hi Gerhard, thanks for your comments.
{quote}How are you downloading the liberty instance from Maven?{quote}
See for example https://github.com/javaee-samples/javaee7-samples/blob/master/pom.xml#L962
It's basically the same method that the other profiles for other servers use as well.
{quote}Why is this more useful than that?{quote}
Packaging a copy of the server.xml file and then copying it over is quite a bit more work and less obvious then just setting a boolean. Ideally for the managed server variant this would even be the default (if I'm not mistaken TomEE does something like that).
{quote}I would think that if we start adding this, we will need further changes to support other features{quote}
Adding arbitrary other features (as in feature elements) would be rather trivial to support. The {{addFeatures}} method in the PR is already prepared for that. With that setting something like {{extraFeatures=usr:JaccFeature,JPA-1.0}} depending on conditions in the test setup is a bit higher level and more flexible than having to prepare a set of different full server.xml files for every combination.
As a followup issue and PR I wanted to do something like as suggested here: http://stackoverflow.com/questions/39259375/loading-data-source-for-datas...
That is, adding a jar from from the archive (or project) that's being deployed as a shared library (<library> tag) and then let the application reference that via the existing {{commonLibraryRef}} support. Doing that all in various combinations with static server.xml files may be a bit too much.
> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
> Key: ARQ-2051
> URL: https://issues.jboss.org/browse/ARQ-2051
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.Beta2
> Reporter: arjan tijms
> Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months
[JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml
by Gerhard Poul (JIRA)
[ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.s... ]
Gerhard Poul commented on ARQ-2051:
-----------------------------------
How are you downloading the liberty instance from Maven? If you're using the liberty:create-server goal it already provides an option for a configFile like we packaged it in our wlp-managed-85 test.
Why is this more useful than that? I would think that if we start adding this, we will need further changes to support other features as well and at that point it just might be easier to include the server.xml as part of the test in the first place anyway; What do you think?
> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
> Key: ARQ-2051
> URL: https://issues.jboss.org/browse/ARQ-2051
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.Beta2
> Reporter: arjan tijms
> Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months
[JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml
by arjan tijms (JIRA)
[ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.s... ]
arjan tijms updated ARQ-2051:
-----------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/arquillian/arquillian-container-was/pull/28
> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
> Key: ARQ-2051
> URL: https://issues.jboss.org/browse/ARQ-2051
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.Beta2
> Reporter: arjan tijms
> Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months