[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4608?page=c... ] Adam Warski updated HHH-4608: ----------------------------- Fix Version/s: (was: 3.6) 3.5 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4608?page=c... ] Paul Benedict commented on HHH-4608: ------------------------------------ Adam, can Hibernate core retrieve the values at runtime? If it could, I can enhance HHH-2576 to expose those as native-SQL placeholders. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4608?page=c... ] Paul Benedict commented on HHH-4608: ------------------------------------ I don't have a particular need for the feature, but I can foresee people wanting to write native queries against the audit tables once they are available. Since 3.5 introduces envers integration, my thinking was to make sure it's also fully integrable with the native sql capabilities. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4608?page=c... ] Paul Benedict commented on HHH-4608: ------------------------------------ Adam, can you tell me how these properties are currently set for envers? Is it just another value in the current Hibernate properties/configuration file? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4608?page=c... ] Paul Benedict commented on HHH-4608: ------------------------------------ Any objection to exposing them in {{o.h.cfg.Settings}} as methods? We may want to ask Steve for his opinion, too. It will be a requirement to getting them during runtime. {code} String #getAuditDefaultSchemaName() String #getAuditDefaultCatalogName() {code} Some further analysis: * What about patching {{o.h.cfg.Environment}} to document the new properties in the API doc? I believe you already did this in the reference manual. * Since everything in envers deals with auditing, consider dropping "Audit" (or vice-versa) since the property is already namespaced with "envers"? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4608?page=c... ] Adam Warski commented on HHH-4608: ---------------------------------- I don't have any objections to expose the settings in o.h.cfg.Settings, although that's a core-core class, and Envers is a separate module. So this could create an "informal" dependency from core to envers. Not sure what Steve's opinion would be here ;). So I think it's best to ask him. As for method names, audit-only is perfectly fine for me. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4608?page=c... ] Adam Warski commented on HHH-4608: ---------------------------------- It should be quite trivial to add this to Settings. And the dependency would be very "informal" as I wrote, nothing binary :). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4608?page=c... ] Adam Warski commented on HHH-4608: ---------------------------------- The camel case was purely my invention ;). I renamed the properties as per your suggestion. Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4608?page=c... ] Adam Warski commented on HHH-4608: ---------------------------------- Yeah, I changed all of them. Of course I support the old ones for now also. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira