February 2020 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-13879) Slow query log should use System#nanoTime not System#currentTimeMillis

by Vlad Mihalcea (JIRA)

Vlad Mihalcea ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-13879 ( https://hibernate.atlassian.net/browse/HHH-13879?atlOrigin=eyJpIjoiMTAzNG... ) Re: Slow query log should use System#nanoTime not System#currentTimeMillis ( https://hibernate.atlassian.net/browse/HHH-13879?atlOrigin=eyJpIjoiMTAzNG... ) Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) All Metrics frameworks I know use System.nanoTime : * Dropwizard Metrics ( https://github.com/dropwizard/metrics/blob/4.1-development/metrics-core/s... ) * Micrometer ( https://github.com/micrometer-metrics/micrometer/blob/6c657f93479b0383547... ) >From the JavaDoc, nanoTime is suggested to be used for durations. Do you know of some JDK bug that causes the issue you indicated? ( https://hibernate.atlassian.net/browse/HHH-13879#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-13879#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a269fed )

4 years, 3 months

1
0
0 / 0

[JIRA] (HHH-13879) Slow query log should use System#nanoTime not System#currentTimeMillis

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-13879 ( https://hibernate.atlassian.net/browse/HHH-13879?atlOrigin=eyJpIjoiMDRiNG... ) Re: Slow query log should use System#nanoTime not System#currentTimeMillis ( https://hibernate.atlassian.net/browse/HHH-13879?atlOrigin=eyJpIjoiMDRiNG... ) hi Vlad, careful that’s not a straight forward change. I’m aware that {{ currentTimeMillis }} isn't recommended, but using {{ nanoTime }} might be a worse choice: it is bound to the time of the specific CPU core, so if the context is switched to a different CPU while performing the measured operation, the measured delta could be completely wrong - including possibly negative times as you’re also affected by different speeds of each core and complex power management of modern OSs. The problem is that the task “running a query” is a blocking IO operation by nature, so we’re almost sure that the task will be re-scheduled - we’re just not sure on which physical CPU it will end up with. Using `System#currentTimeMillis` is less precise, but all considered is possibly more suitable in this context. Neither of them has the precision we would need for a “fast operation”, but the specific need of logging *slow queries* the milliseconds should be a good fit. At least while not super precise, it won’t be producing confusing results. ( https://hibernate.atlassian.net/browse/HHH-13879#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-13879#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a269fed )

4 years, 3 months

1
0
0 / 0

[JIRA] (HBX-1994) Move class 'org.hibernate.tool.api.dialect.MetaDataDialectFactory' to 'org.hibernate.tool.api.reveng.RevengDialectFactory'

by Koen Aers (JIRA)

4 years, 3 months

1
0
0 / 0

[JIRA] (HBX-1994) Move class 'org.hibernate.tool.api.dialect.MetaDataDialectFactory' to 'org.hibernate.tool.api.reveng.RevengDialectFactory'

by Koen Aers (JIRA)

4 years, 3 months

1
0
0 / 0

[JIRA] (HHH-13879) Slow query log should use System#nanoTime not System#currentTimeMillis

by Vlad Mihalcea (JIRA)

Vlad Mihalcea ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMjJmYzYyZjY0... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-13879?atlOrigin=eyJpIjoiMjJmYz... ) HHH-13879 ( https://hibernate.atlassian.net/browse/HHH-13879?atlOrigin=eyJpIjoiMjJmYz... ) Slow query log should use System#nanoTime not System#currentTimeMillis ( https://hibernate.atlassian.net/browse/HHH-13879?atlOrigin=eyJpIjoiMjJmYz... ) Issue Type: Improvement Affects Versions: 5.4.12 Assignee: Vlad Mihalcea ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hibernate-core Created: 25/Feb/2020 06:26 AM Priority: Major Reporter: Vlad Mihalcea ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Currently, the slow query log using `System#currentTimeMillis`, that is not suitable for calculating time durations, as stated by the Java Doc: > > > > Note that while the unit of time of the return value is a millisecond, the > granularity of the value depends on the underlying operating system and > may be larger. For example, many operating systems measure time in units > of tens of milliseconds. > > We should use `nanoTime` instead. ( https://hibernate.atlassian.net/browse/HHH-13879#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-13879#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a269fed )

4 years, 3 months

1
0
0 / 0

[JIRA] (HBX-1993) Move class 'org.hibernate.tool.api.dialect.MetaDataDialect' to 'org.hibernate.tool.api.reveng.RevengDialect'

by Koen Aers (JIRA)

4 years, 3 months

1
0
0 / 0

[JIRA] (HBX-1993) Move class 'org.hibernate.tool.api.dialect.MetaDataDialect' to 'org.hibernate.tool.api.reveng.RevengDialect'

by Koen Aers (JIRA)

4 years, 3 months

1
0
0 / 0

[JIRA] (HBX-1992) Reorganize the reverse engineering strategy hierarchy

by Koen Aers (JIRA)

4 years, 3 months

1
0
0 / 0

[JIRA] (HV-1758) Extra dollar sign in validation messages for ModCheck

by Yoann Rodière (JIRA)

4 years, 3 months

1
0
0 / 0

[JIRA] (HV-1758) Extra dollar sign in validation messages for ModCheck

by Yoann Rodière (JIRA)

4 years, 3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues February 2020