[hibernate-issues] [JIRA] (HHH-16418) Request clearer logged error message when @GeneratedValue stategy = IDENTITY and USE_GET_GENERATED_KEYS setting is false

BARRY LAFOND ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=617715c... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZWZjYTBiM2Fh... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16418?atlOrigin=eyJpIjoiZWZjYT... ) HHH-16418 ( https://hibernate.atlassian.net/browse/HHH-16418?atlOrigin=eyJpIjoiZWZjYT... ) Request clearer logged error message when @GeneratedValue stategy = IDENTITY and USE_GET_GENERATED_KEYS setting is false ( https://hibernate.atlassian.net/browse/HHH-16418?atlOrigin=eyJpIjoiZWZjYT... ) Issue Type: Bug Affects Versions: 6.2.0 Assignee: Unassigned Attachments: Oracle_ORM_generate_ids_false.txt, Oracle_ORM_generate_ids_true.txt Components: hibernate-core Created: 02/Apr/2023 12:24 PM Priority: Major Reporter: BARRY LAFOND ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=617715c... ) Working on Reactive enabling Oracle support for ORM 6.2 I was testing our identity generation test cases. I added an ORM session test ( https://github.com/DavideD/hibernate-reactive/blob/42540081fa415a4e21591c... ) for comparison to a a Reactive version and while working on that test I ran into an NPE from ORM based on using USE_GET_GENERATED_KEYS = FALSE setting with an entity ID using @GeneratedValue(strategy = GenerationType.IDENTITY). The NPE is due to a null identitySelectString in the persister. (see attached logs) Adding a check for this sooner and logging a simple message would help users identify that their configuration setting isn’t compatible with their Entity definition ( https://hibernate.atlassian.net/browse/HHH-16418#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16418#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:57c27f3 )