From: "Scott Rossillo" <srossillo(a)smartling.com&gt; To: "keycloak-dev" <keycloak-dev(a)lists.jboss.org&gt; Sent: Friday, 8 May, 2015 2:20:00 AM Subject: [keycloak-dev] Spring Security Adapter Hi, I sent 3 pull requests that get the Spring Security adapter into shape for production usage. I started writing the documentation today and will be sending a PR tomorrow. I have one more code related PR tomorrow to set up the default Spring Security configuration fully so there’s less to document. :) Best, Scott _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev

From: "Scott Rossillo" <srossillo(a)smartling.com&gt; To: "Stian Thorgersen" <stian(a)redhat.com&gt; Cc: "keycloak-dev" <keycloak-dev(a)lists.jboss.org&gt; Sent: Friday, 8 May, 2015 7:24:42 AM Subject: Re: [keycloak-dev] Spring Security Adapter Hi Stian, There’s an example here: https://github.com/foo4u/keycloak-spring-demo I will look into making them run on Wildfly and contributing them to the Keycloak project but it may not make the 1.2.0.Final if that’s going out Monday. Also, I need to push an update to them once you merge my PRs.

As for tests, there’s pretty solid unit test coverage in the module’s test folder. However, I’ll look into creating a test suite. These definitely look more like integration tests, which are also quite important. Also post 1.2.0.Final but definitely something I’ll add.

~ Scott PS - I sent another PR about an hour ago adding a docbook section on using the Spring Security adapter. > On May 8, 2015, at 1:11 AM, Stian Thorgersen <stian(a)redhat.com&gt; wrote: > > Great, thanks for contributing this. Would also be good to have an example > and tests (see testsuite which has adapters tests for tomcat, jetty, > etc.). > > ----- Original Message ----- >> From: "Scott Rossillo" <srossillo(a)smartling.com&gt; >> To: "keycloak-dev" <keycloak-dev(a)lists.jboss.org&gt; >> Sent: Friday, 8 May, 2015 2:20:00 AM >> Subject: [keycloak-dev] Spring Security Adapter >> >> Hi, >> >> I sent 3 pull requests that get the Spring Security adapter into shape for >> production usage. I started writing the documentation today and will be >> sending a PR tomorrow. >> >> I have one more code related PR tomorrow to set up the default Spring >> Security configuration fully so there’s less to document. :) >> >> Best, >> Scott >> >> >> _______________________________________________ >> keycloak-dev mailing list >> keycloak-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/keycloak-dev

From: "Scott Rossillo" <srossillo(a)smartling.com&gt; To: "Stian Thorgersen" <stian(a)redhat.com&gt; Cc: "keycloak-dev" <keycloak-dev(a)lists.jboss.org&gt; Sent: Friday, 8 May, 2015 4:20:36 PM Subject: Re: [keycloak-dev] Spring Security Adapter Thanks for merging everything. Will you merge them into the 1.2.0 branch as well?

> On May 8, 2015, at 1:28 AM, Stian Thorgersen <stian(a)redhat.com&gt; wrote: > > > > ----- Original Message ----- >> From: "Scott Rossillo" <srossillo(a)smartling.com&gt; >> To: "Stian Thorgersen" <stian(a)redhat.com&gt; >> Cc: "keycloak-dev" <keycloak-dev(a)lists.jboss.org&gt; >> Sent: Friday, 8 May, 2015 7:24:42 AM >> Subject: Re: [keycloak-dev] Spring Security Adapter >> >> Hi Stian, >> >> There’s an example here: https://github.com/foo4u/keycloak-spring-demo >> >> I will look into making them run on Wildfly and contributing them to the >> Keycloak project but it may not make the 1.2.0.Final if that’s going out >> Monday. Also, I need to push an update to them once you merge my PRs. > > Merged and after 1.2.0.Final is no prob. > >> >> As for tests, there’s pretty solid unit test coverage in the module’s test >> folder. However, I’ll look into creating a test suite. These definitely >> look >> more like integration tests, which are also quite important. Also post >> 1.2.0.Final but definitely something I’ll add. > > We barely have unit tests and try to aim for integration/end-to-end or > whatever you'd call it ;) > >> >> ~ Scott >> >> PS - I sent another PR about an hour ago adding a docbook section on using >> the Spring Security adapter. >> >> >>> On May 8, 2015, at 1:11 AM, Stian Thorgersen <stian(a)redhat.com&gt; wrote: >>> >>> Great, thanks for contributing this. Would also be good to have an >>> example >>> and tests (see testsuite which has adapters tests for tomcat, jetty, >>> etc.). >>> >>> ----- Original Message ----- >>>> From: "Scott Rossillo" <srossillo(a)smartling.com&gt; >>>> To: "keycloak-dev" <keycloak-dev(a)lists.jboss.org&gt; >>>> Sent: Friday, 8 May, 2015 2:20:00 AM >>>> Subject: [keycloak-dev] Spring Security Adapter >>>> >>>> Hi, >>>> >>>> I sent 3 pull requests that get the Spring Security adapter into shape >>>> for >>>> production usage. I started writing the documentation today and will be >>>> sending a PR tomorrow. >>>> >>>> I have one more code related PR tomorrow to set up the default Spring >>>> Security configuration fully so there’s less to document. :) >>>> >>>> Best, >>>> Scott >>>> >>>> >>>> _______________________________________________ >>>> keycloak-dev mailing list >>>> keycloak-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/keycloak-dev >> >>

From: "Thomas Raehalme" <thomas.raehalme(a)codecenter.fi&gt; To: "keycloak-dev" <keycloak-dev(a)lists.jboss.org&gt; Sent: Monday, 11 May, 2015 8:19:15 AM Subject: Re: [keycloak-dev] Spring Security Adapter Hi! On Mon, May 11, 2015 at 8:24 AM, Stian Thorgersen < stian(a)redhat.com > wrote: > Thanks for merging everything. Will you merge them into the 1.2.0 branch as > well? No, bug fixes only in 1.2 branch. I'd like to thank you guys for the Spring Security adapter, it's looking really good! Since the adapter will not make into the 1.2 release, can you see any problems using the adapter in 1.3 with an earlier Keycloak version?

Perhaps separating the adapter releases from the Keycloak application would be something worth considering at some point? Their release cycle is not always related to Keycloak and new adapters could be spawn between Keycloak releases as well.

Best regards, Thomas _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev