Thanks for merging everything. Will you merge them into the 1.2.0 branch as well?
On May 8, 2015, at 1:28 AM, Stian Thorgersen <stian(a)redhat.com>
----- Original Message -----
> From: "Scott Rossillo" <srossillo(a)smartling.com>
> To: "Stian Thorgersen" <stian(a)redhat.com>
> Cc: "keycloak-dev" <keycloak-dev(a)lists.jboss.org>
> Sent: Friday, 8 May, 2015 7:24:42 AM
> Subject: Re: [keycloak-dev] Spring Security Adapter
> Hi Stian,
> There’s an example here: https://github.com/foo4u/keycloak-spring-demo
> I will look into making them run on Wildfly and contributing them to the
> Keycloak project but it may not make the 1.2.0.Final if that’s going out
> Monday. Also, I need to push an update to them once you merge my PRs.
Merged and after 1.2.0.Final is no prob.
> As for tests, there’s pretty solid unit test coverage in the module’s test
> folder. However, I’ll look into creating a test suite. These definitely look
> more like integration tests, which are also quite important. Also post
> 1.2.0.Final but definitely something I’ll add.
We barely have unit tests and try to aim for integration/end-to-end or whatever you'd
call it ;)
> ~ Scott
> PS - I sent another PR about an hour ago adding a docbook section on using
> the Spring Security adapter.
>> On May 8, 2015, at 1:11 AM, Stian Thorgersen <stian(a)redhat.com> wrote:
>> Great, thanks for contributing this. Would also be good to have an example
>> and tests (see testsuite which has adapters tests for tomcat, jetty,
>> ----- Original Message -----
>>> From: "Scott Rossillo" <srossillo(a)smartling.com>
>>> To: "keycloak-dev" <keycloak-dev(a)lists.jboss.org>
>>> Sent: Friday, 8 May, 2015 2:20:00 AM
>>> Subject: [keycloak-dev] Spring Security Adapter
>>> I sent 3 pull requests that get the Spring Security adapter into shape for
>>> production usage. I started writing the documentation today and will be
>>> sending a PR tomorrow.
>>> I have one more code related PR tomorrow to set up the default Spring
>>> Security configuration fully so there’s less to document. :)
>>> keycloak-dev mailing list