Project Newcastle will only deal with storing source and NPM libraries. We
still need to filter what's installed from NPM. If we incorporate the
changes I made here all we'd need to do after PNC has been fixed is to stop
committing the full unfiltered node_modules directory.
On 26 January 2018 at 16:12, Stan Silvert <ssilvert(a)redhat.com> wrote:
That's all good, but didn't we agree that we would wait for
Newcastle to complete their solution? It's probably time to find out
where they are as they seemed to indicate that they were close last time
On 1/26/2018 3:33 AM, Stian Thorgersen wrote:
> I took a stab at cleaning up the node_modules (not for account2) by
> a new profile to themes that can download packages from NPM. Then
> copy/filter these to the directory used to build the server.
> Benefits here:
> * Removes unneeded files from dist
> * Files included when running KeycloakServer is the same as in the dist
> * All files/sources still checked in for RH-SSO
> * Folks don't have to run this to build
> You can try it out here:
> cd themes
> mvn -Pnpm-update clean install
> Unless you change the package.json you shouldn't see any files to commit
> afterwards. If you do there may be something with line encodings on Linux
> vs Windows that we need to address (we should be able to tweak that by
> adding a custom .gitattributes file in the node_modules dir).
> Login, account and admin seems to work just fine with all these files
> removed. There's probably more we can remove, but I think this is
> sufficient at least for now.
> keycloak-dev mailing list
keycloak-dev mailing list