Hey, As Stefan noticed, some providers (including the one I created a few weeks back) check "disabled" flag from the configuration [1][2]. Stefan pointed out, that our Subsystem (and Keycloak internals) already check the "enabled" flag [3] on the SPI level. If the SPI is disabled, it won't be initialized at all, so all the disabled/enabled checks in ProviderFactory#init seems to be redundant. If I didn't miss anything and you all agree with me, I'd like to remove this kind of checks. Thanks, Sebastian [1] https://github.com/keycloak/keycloak/blob/5f9feee3f86e3d856063c8b6d355e30... [2] https://github.com/keycloak/keycloak/blob/3afbdd3ea3d8eb1ef339f2c0c46fb57... [3] https://github.com/keycloak/keycloak/blob/505cf5b25184c59ca85de63b082eb12... _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev

That's correct a provider won't be initialised if it's disabled so there's no need for this in the provider itself. One thing to not here is that providers that have an expensive init should consider lazy init itself. We don't have support for that built in directly so the providers need to do that themselves for now. Take a look at the jpa connection factory for an example. On Tue, 27 Aug 2019, 21:47 Stefan Guilhen, <sguilhen(a)redhat.com&gt; wrote: > Hi Sebastian, > > I agree with you here. The session factory is already checking the > "enabled" property, so any provider factory checking the same property (or > the "disabled' variant) seems redundant to me. So +1 to removing the > checks > from the provider factories. > > On Tue, Aug 27, 2019 at 9:37 AM Sebastian Laskawiec <slaskawi(a)redhat.com&gt; > wrote: > > > Hey, > > > > As Stefan noticed, some providers (including the one I created a few > weeks > > back) check "disabled" flag from the configuration [1][2]. Stefan > pointed > > out, that our Subsystem (and Keycloak internals) already check the > > "enabled" flag [3] on the SPI level. If the SPI is disabled, it won't be > > initialized at all, so all the disabled/enabled checks in > > ProviderFactory#init seems to be redundant. > > > > If I didn't miss anything and you all agree with me, I'd like to remove > > this kind of checks. > > > > Thanks, > > Sebastian > > > > [1] > > > > > https://github.com/keycloak/keycloak/blob/5f9feee3f86e3d856063c8b6d355e30... > > [2] > > > > > https://github.com/keycloak/keycloak/blob/3afbdd3ea3d8eb1ef339f2c0c46fb57... > > [3] > > > > > https://github.com/keycloak/keycloak/blob/505cf5b25184c59ca85de63b082eb12... > > _______________________________________________ > > keycloak-dev mailing list > > keycloak-dev(a)lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/keycloak-dev > > > > > -- > > Stefan Guilhen > > Principal Software Engineer > > Red Hat <https://www.redhat.com/> > > sguilhen(a)redhat.com IM: sguilhen > @RedHat <https://twitter.com/redhat> Red Hat > <https://www.linkedin.com/company/red-hat> Red Hat > <https://www.facebook.com/RedHatInc> > <https://www.redhat.com/> > _______________________________________________ > keycloak-dev mailing list > keycloak-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/keycloak-dev >