[JBoss JIRA] (ARQ-1368) Warp: reverse order of chaining of request builder
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/ARQ-1368?page=com.atlassian.jira.plugin.s... ]
Work on ARQ-1368 started by Lukáš Fryč.
> Warp: reverse order of chaining of request builder
> --------------------------------------------------
>
> Key: ARQ-1368
> URL: https://issues.jboss.org/browse/ARQ-1368
> Project: Arquillian
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Extension - Warp
> Reporter: Lukáš Fryč
> Assignee: Lukáš Fryč
> Priority: Critical
> Fix For: warp_1.0.0.Alpha3
>
> Original Estimate: 30 minutes
> Remaining Estimate: 30 minutes
>
> If we are following observer:
> {code}.observe(request().uri().contains("__richfacesPushAsync").index(1)){code}
> we want observe first request matching criteria - (URI containing given string), however that is not what happens:
> the {{index(1)}} calls method [{{addFilter}}|https://github.com/arquillian/arquillian-extension-warp/blob/1.0.0.Alpha2/impl/src/main/java/org/jboss/arquillian/warp/impl/client/filter/http/DefaultHttpFilterBuilder.java#L111] which allows chaining, but this chain [evaluates the newly passed filter before it evaluates previous one|https://github.com/arquillian/arquillian-extension-warp/blob/1.0.0.Al...].
> ----
> Reverse the order of evaluation in order to fix semantics of fluent API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (ARQ-1396) CommandEventBusService use wrong metadata to match Request URI
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/ARQ-1396?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč updated ARQ-1396:
----------------------------
Status: Resolved (was: Pull Request Sent)
Assignee: Aslak Knutsen
Resolution: Done
> CommandEventBusService use wrong metadata to match Request URI
> --------------------------------------------------------------
>
> Key: ARQ-1396
> URL: https://issues.jboss.org/browse/ARQ-1396
> Project: Arquillian
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Extension - Warp
> Affects Versions: warp_1.0.0.Alpha2
> Reporter: Aslak Knutsen
> Assignee: Aslak Knutsen
> Priority: Critical
> Fix For: warp_1.0.0.Alpha3
>
>
> canDelegate use request.getServletPath to check if the current request match a given path.
> The problem is, pr spec, getServletPath is a empty String when Servlet is mapped to /*, and in this case it's just a Filter. Both getServletPath and getPathInfo are bound to a Servlet.
> getServletPath works in JBoss AS 7.1.1, but not in WildFly 8.
> getServletPath works in WildFly 8, but not in JBoss AS 7.1.1.
> The correct check seems to be:
> getRequestURI().endsWith(COMMAND_EVENT_BUS_MAPPING)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months