[JBoss JIRA] (ARQ-1345) maxTestClassesBeforeRestart causes more restarts than it should
by Aslak Knutsen (JIRA)
[ https://issues.jboss.org/browse/ARQ-1345?page=com.atlassian.jira.plugin.s... ]
Aslak Knutsen resolved ARQ-1345.
--------------------------------
Assignee: Aslak Knutsen
Fix Version/s: 1.0.4.Final
Resolution: Done
Think this should do it.
pushed upstream: https://github.com/arquillian/arquillian-core/commit/f3ea66789668e352d9b7...
> maxTestClassesBeforeRestart causes more restarts than it should
> ---------------------------------------------------------------
>
> Key: ARQ-1345
> URL: https://issues.jboss.org/browse/ARQ-1345
> Project: Arquillian
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 1.0.3.Final
> Reporter: Rich DiCroce
> Assignee: Aslak Knutsen
> Fix For: 1.0.4.Final
>
>
> ContainerRestarter (package org.jboss.arquillian.container.test.impl.client.container) has a bug in it that causes maxTestClassesBeforeRestart to be evaluated slightly incorrectly. The below code is what the shouldRestart() method currently does:
> {code}
> ArquillianDescriptor descriptor = configuration.get();
> Integer maxTestClasses = descriptor.engine().getMaxTestClassesBeforeRestart();
> if(maxTestClasses == null)
> {
> return false;
> }
> if(maxTestClasses > -1)
> {
> if((maxTestClasses -1 ) == testClassesCount)
> {
> testClassesCount = 0;
> return true;
> }
> }
> testClassesCount++;
> return false;
> {code}
> Because it checks if maxTestClasses - 1 is equal to testClassesCount, the first container restart actually occurs before test #N-1, not test #N. An easy way to see this is to set maxTestClassesBeforeRestart to 1; you will observe that the container is started for the first time, then immediately shut down without anything being deployed, then restarted.
> This can be fixed by checking if maxTestClasses == testClassesCount instead of maxTestClasses - 1 == testClassesCount.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months
[JBoss JIRA] (ARQ-863) Poor error message when WebArchive deployed with ".jar" name
by Aslak Knutsen (JIRA)
[ https://issues.jboss.org/browse/ARQ-863?page=com.atlassian.jira.plugin.sy... ]
Aslak Knutsen updated ARQ-863:
------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
pushed upstream https://github.com/arquillian/arquillian-core/commit/29ca483834d4cab6f4d5...
> Poor error message when WebArchive deployed with ".jar" name
> ------------------------------------------------------------
>
> Key: ARQ-863
> URL: https://issues.jboss.org/browse/ARQ-863
> Project: Arquillian
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 1.0.0.CR8
> Environment: Jboss AS 7.1.1.Final
> java version "1.7.0_01"
> Java(TM) SE Runtime Environment (build 1.7.0_01-b08)
> Java HotSpot(TM) 64-Bit Server VM (build 21.1-b02, mixed mode)
> Linux ayaki.localdomain 3.3.0-4.fc16.x86_64 #1 SMP Tue Mar 20 18:05:40 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
> Reporter: Craig Ringer
> Assignee: Tommy Tynjä
> Priority: Minor
> Fix For: 1.0.4.Final
>
> Attachments: ArquillianShrinkwrapWarBug.zip
>
>
> If a WebArchive is deployed with the name ending in ".jar" instead of ".war" (due to, eg, a stupid editing mistake) the error message is not at all helpful. The container will fail to run the test class with a ClassNotFoundException for the test class.
> It'd be really nice if the deployer or the packager would detect this issue and report it.
> {code}
> 13:58:42,082 ERROR [org.jboss.arquillian.protocol.jmx.JMXTestRunner] (pool-1-thread-29) Failed: com.example.shrinkwrapwarbug.DemoTest.testReturnOne:
> java.lang.ClassNotFoundException: com.example.shrinkwrapwarbug.DemoTest from [Module "deployment.demo.jar:main" from Service Module Loader]
> at org.jboss.modules.ModuleClassLoader.findClass(ModuleClassLoader.java:190) [jboss-modules.jar:1.1.1.GA]
> at org.jboss.modules.ConcurrentClassLoader.performLoadClassUnchecked(ConcurrentClassLoader.java:468) [jboss-modules.jar:1.1.1.GA]
> at org.jboss.modules.ConcurrentClassLoader.performLoadClassChecked(ConcurrentClassLoader.java:456) [jboss-modules.jar:1.1.1.GA]
> at org.jboss.modules.ConcurrentClassLoader.performLoadClass(ConcurrentClassLoader.java:398) [jboss-modules.jar:1.1.1.GA]
> at org.jboss.modules.ConcurrentClassLoader.loadClass(ConcurrentClassLoader.java:120) [jboss-modules.jar:1.1.1.GA]
> at org.jboss.as.arquillian.service.ArquillianConfig.loadClass(ArquillianConfig.java:130) [arquillian-service:]
> at org.jboss.as.arquillian.service.ArquillianService$ExtendedTestClassLoader.loadTestClass(ArquillianService.java:259) [arquillian-service:]
> at org.jboss.arquillian.protocol.jmx.JMXTestRunner.runTestMethodInternal(JMXTestRunner.java:124) [arquillian-service:]
> at org.jboss.arquillian.protocol.jmx.JMXTestRunner.runTestMethod(JMXTestRunner.java:107) [arquillian-service:]
> at org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.runTestMethod(ArquillianService.java:226) [arquillian-service:]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.7.0_01]
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) [rt.jar:1.7.0_01]
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.7.0_01]
> at java.lang.reflect.Method.invoke(Method.java:601) [rt.jar:1.7.0_01]
> at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:111) [rt.jar:1.7.0_01]
> at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:45) [rt.jar:1.7.0_01]
> at com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:235) [rt.jar:1.7.0_01]
> at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138) [rt.jar:1.7.0_01]
> at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:250) [rt.jar:1.7.0_01]
> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819) [rt.jar:1.7.0_01]
> at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:791) [rt.jar:1.7.0_01]
> at org.jboss.as.jmx.PluggableMBeanServerImpl$TcclMBeanServer.invoke(PluggableMBeanServerImpl.java:498)
> at org.jboss.as.jmx.PluggableMBeanServerImpl.invoke(PluggableMBeanServerImpl.java:246)
> at org.jboss.remotingjmx.protocol.v1.ServerProxy$InvokeHandler.handle(ServerProxy.java:1034)
> at org.jboss.remotingjmx.protocol.v1.ServerProxy$MessageReciever$1.run(ServerProxy.java:215)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) [rt.jar:1.7.0_01]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) [rt.jar:1.7.0_01]
> at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_01]
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (ARQ-1373) Cleanup does not work when none datasets provided for seeding
by Bartosz Majsak (JIRA)
[ https://issues.jboss.org/browse/ARQ-1373?page=com.atlassian.jira.plugin.s... ]
Bartosz Majsak resolved ARQ-1373.
---------------------------------
Resolution: Done
Cleanup based on seeded data (tables or rows only strategies) should not work when no data provided - therefore such strategies are ignored and warning is displayed.
Pushed upstream.
> Cleanup does not work when none datasets provided for seeding
> -------------------------------------------------------------
>
> Key: ARQ-1373
> URL: https://issues.jboss.org/browse/ARQ-1373
> Project: Arquillian
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Extension - Persistence
> Reporter: Bartosz Majsak
> Assignee: Bartosz Majsak
> Fix For: persistence_1.0.0.next
>
>
> If "used tables only" strategy is selected and none datasets provided for the the test itself, cleanup procedure results with NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months