[JBoss JIRA] (ARQ-2065) Combine multiple test results
by Bartosz Majsak (JIRA)
[ https://issues.jboss.org/browse/ARQ-2065?page=com.atlassian.jira.plugin.s... ]
Bartosz Majsak closed ARQ-2065.
-------------------------------
> Combine multiple test results
> -----------------------------
>
> Key: ARQ-2065
> URL: https://issues.jboss.org/browse/ARQ-2065
> Project: Arquillian
> Issue Type: Feature Request
> Components: core
> Affects Versions: 1.1.11.Final
> Reporter: Bartosz Majsak
> Assignee: Bartosz Majsak
> Priority: Minor
> Fix For: 1.1.12.Final
>
>
> With the current implementation in place splitting single test in several executions can only happen from within Arquillian events (so we run n tests from within single test). This in particular happens for running contract tests for Pact, where one test spawns several verifications based on the content of the contract itself.
> Even though the {{List<TestResult>}} is used as a container object for TestResult instance passed along when Test event is fired, it can happen one test can be fired multiple times (for example in arquillian-algeron).
> The temporary solution for this problem could be that all the results are collected into one instance of TestResult.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years
[JBoss JIRA] (ARQ-2068) Hard to discover why an @Observer method is not being invoked
by Bartosz Majsak (JIRA)
[ https://issues.jboss.org/browse/ARQ-2068?page=com.atlassian.jira.plugin.s... ]
Bartosz Majsak closed ARQ-2068.
-------------------------------
> Hard to discover why an @Observer method is not being invoked
> -------------------------------------------------------------
>
> Key: ARQ-2068
> URL: https://issues.jboss.org/browse/ARQ-2068
> Project: Arquillian
> Issue Type: Bug
> Components: core
> Affects Versions: 1.1.11.Final
> Reporter: Bartosz Majsak
> Assignee: Jonh Wendell
> Priority: Minor
> Fix For: 1.1.12.Final
>
>
> If someone writes a method with @Observer annotation and supply an argument that's impossible to be injected, that method will never be invoked.
> But...
> The user might have a hard time trying to find out the reason.
> It would be good if we had some kind of warning printed out. It'd save us some time :)
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years
[JBoss JIRA] (ARQ-2034) Test enrichment and JUnit @Rule do not harmonize
by Bartosz Majsak (JIRA)
[ https://issues.jboss.org/browse/ARQ-2034?page=com.atlassian.jira.plugin.s... ]
Bartosz Majsak closed ARQ-2034.
-------------------------------
> Test enrichment and JUnit @Rule do not harmonize
> ------------------------------------------------
>
> Key: ARQ-2034
> URL: https://issues.jboss.org/browse/ARQ-2034
> Project: Arquillian
> Issue Type: Bug
> Components: Base Implementation
> Affects Versions: 1.1.11.Final
> Environment: junit 4.11
> arquillian-junit-container 1.1.11.Final
> wildfly-arquillian-container-remote 8.1.0.Final
> Reporter: Björn Kautler
> Assignee: Matous Jobanek
> Fix For: 1.1.12.Final
>
>
> We are starting with Arquillian tests on a remote WildFly instance.
> I tried to write a JUnit {{@Rule}}, that can be used to make a login call for all test methods automatically, but I was not yet able to make it work, as I need an injected {{@Ejb}} instance for this.
> I tried to add {{@EJB private InterfaceLoginManagement interfaceLoginManagement;}} to the {{TestRule}} implementation, but it stays {{null}}. I've read at ARQ-1954 that this should probably work, but unfortunately it is not, at least not with the remote container runner. {{org.jboss.arquillian.junit.extension.JUnitCoreExtension}} that should register {{org.jboss.arquillian.junit.extension.UpdateTestResultBeforeAfter}} and {{org.jboss.arquillian.junit.RulesEnricher}} is not even loaded on the container side. Maybe the {{META-INF/services/}} file is missing?
> Then I tried to simply give the injected instance to the rule from the test class like
> {code}
> @EJB private InterfaceLoginManagement interfaceLoginManagement;
> @Rule private LoginRule loginRule = new LoginRule(interfaceLoginManagement);
> {code}
> or even
> {code}
> @EJB private InterfaceLoginManagement interfaceLoginManagement;
> @Rule public LoginRule getLoginRule() {
> return new LoginRule(() -> {
> return interfaceLoginManagement;
> });
> }
> {code}
> with the {{LoginRule}} receiving a {{Supplier<InterfaceLoginManagement>}} and call it as late as possible, i. e. in the rules {{apply()}} method. But even this is still too early as the EJB is still {{null}} and the test enrichers are only run between the {{@Rule}} applying and {{@Before}} methods.
> So I'd like to suggest two things:
> # Fix the implementation of ARQ-1954 if it should work on container side which I assume it should
> # Make the test enrichments earlier in the lifecycle, i. e. before the {{@Rule}} s are being applied, or rather even before the {{@Rule}} methods are called, so that you at least can use the injected instances in the {{@Rule}} annotated methods to forward them to a rule. This is necessary even if top 1 is taken care of, because you might want to use a 3rd Party rule the code of which you cannot change.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years
[JBoss JIRA] (ARQ-2012) Warnings when test runs as client without @RunAsClient
by Bartosz Majsak (JIRA)
[ https://issues.jboss.org/browse/ARQ-2012?page=com.atlassian.jira.plugin.s... ]
Bartosz Majsak closed ARQ-2012.
-------------------------------
> Warnings when test runs as client without @RunAsClient
> ------------------------------------------------------
>
> Key: ARQ-2012
> URL: https://issues.jboss.org/browse/ARQ-2012
> Project: Arquillian
> Issue Type: Bug
> Components: Deployable Containers SPI
> Affects Versions: 1.1.11.Final
> Reporter: Ladislav Thon
> Assignee: Matous Jobanek
> Fix For: 1.1.12.Final
>
>
> When I moved to Arquillian 1.1.11.Final, I started getting warnings when my tests run as client but don't use the {{@RunAsClient}} annotation. The cause is ARQ-1937.
> I'll just reiterate that I actually never ever use the {{@RunAsClient}} annotation because it's superfluous. I simply set my {{@Deployment}} to {{testable = false}} or I have no {{@Deployment}} at all. I do that intentionally and I _expect_ that the test will run as client, so the warning doesn't make much sense for me.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years
[JBoss JIRA] (ARQ-2068) Hard to discover why an @Observer method is not being invoked
by Bartosz Majsak (JIRA)
[ https://issues.jboss.org/browse/ARQ-2068?page=com.atlassian.jira.plugin.s... ]
Bartosz Majsak updated ARQ-2068:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 1.1.12.Final
Resolution: Done
> Hard to discover why an @Observer method is not being invoked
> -------------------------------------------------------------
>
> Key: ARQ-2068
> URL: https://issues.jboss.org/browse/ARQ-2068
> Project: Arquillian
> Issue Type: Bug
> Components: core
> Affects Versions: 1.1.11.Final
> Reporter: Bartosz Majsak
> Assignee: Jonh Wendell
> Priority: Minor
> Fix For: 1.1.12.Final
>
>
> If someone writes a method with @Observer annotation and supply an argument that's impossible to be injected, that method will never be invoked.
> But...
> The user might have a hard time trying to find out the reason.
> It would be good if we had some kind of warning printed out. It'd save us some time :)
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years
[JBoss JIRA] (ARQ-2068) Hard to discover why an @Observer method is not being invoked
by Bartosz Majsak (JIRA)
[ https://issues.jboss.org/browse/ARQ-2068?page=com.atlassian.jira.plugin.s... ]
Bartosz Majsak reassigned ARQ-2068:
-----------------------------------
Assignee: Jonh Wendell (was: Bartosz Majsak)
> Hard to discover why an @Observer method is not being invoked
> -------------------------------------------------------------
>
> Key: ARQ-2068
> URL: https://issues.jboss.org/browse/ARQ-2068
> Project: Arquillian
> Issue Type: Bug
> Components: core
> Affects Versions: 1.1.11.Final
> Reporter: Bartosz Majsak
> Assignee: Jonh Wendell
> Priority: Minor
> Fix For: 1.1.12.Final
>
>
> If someone writes a method with @Observer annotation and supply an argument that's impossible to be injected, that method will never be invoked.
> But...
> The user might have a hard time trying to find out the reason.
> It would be good if we had some kind of warning printed out. It'd save us some time :)
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years