[JBoss JIRA] (ARQ-2114) It is easy to reach the GH rate limit when firefox is used
by Matous Jobanek (JIRA)
Matous Jobanek created ARQ-2114:
-----------------------------------
Summary: It is easy to reach the GH rate limit when firefox is used
Key: ARQ-2114
URL: https://issues.jboss.org/browse/ARQ-2114
Project: Arquillian
Issue Type: Bug
Components: Extension - Drone
Affects Versions: drone_2.1.1
Reporter: Matous Jobanek
Assignee: Matous Jobanek
Fix For: drone_2.1.2
When the limit is reached, then you get this error:
{noformat}
07:48:53 java.lang.RuntimeException: Could not create statement
07:48:53 at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:360)
07:48:53 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
07:48:53 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
07:48:53 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
07:48:53 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
07:48:53 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
07:48:53 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
07:48:53 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
07:48:53 at org.jboss.arquillian.junit.Arquillian$2.evaluate(Arquillian.java:205)
07:48:53 at org.jboss.arquillian.junit.Arquillian.multiExecute(Arquillian.java:431)
07:48:53 at org.jboss.arquillian.junit.Arquillian.access$200(Arquillian.java:55)
07:48:53 at org.jboss.arquillian.junit.Arquillian$3.evaluate(Arquillian.java:219)
07:48:53 at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
07:48:53 at org.junit.rules.RunRules.evaluate(RunRules.java:20)
07:48:53 at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
07:48:53 at org.jboss.arquillian.junit.Arquillian.run(Arquillian.java:167)
07:48:53 at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
07:48:53 at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
07:48:53 at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
07:48:53 at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
07:48:53 at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
07:48:53 at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
07:48:53 at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
07:48:53 Caused by: java.lang.IllegalStateException: Something bad happened when Drone was trying to download and prepare a binary. For more information see the cause.
07:48:53 at org.jboss.arquillian.drone.webdriver.binary.handler.AbstractBinaryHandler.checkAndSetBinary(AbstractBinaryHandler.java:61)
07:48:53 at org.jboss.arquillian.drone.webdriver.factory.FirefoxDriverFactory.getCapabilities(FirefoxDriverFactory.java:107)
07:48:53 at org.jboss.arquillian.drone.webdriver.factory.FirefoxDriverFactory.createInstance(FirefoxDriverFactory.java:73)
07:48:53 at org.jboss.arquillian.drone.webdriver.factory.FirefoxDriverFactory.createInstance(FirefoxDriverFactory.java:39)
07:48:53 at org.jboss.arquillian.drone.webdriver.factory.WebDriverFactory.createInstance(WebDriverFactory.java:127)
07:48:53 at org.jboss.arquillian.drone.webdriver.factory.WebDriverFactory.createInstance(WebDriverFactory.java:38)
07:48:53 at org.jboss.arquillian.drone.impl.DroneConfigurator$1.createInstance(DroneConfigurator.java:112)
07:48:53 at org.jboss.arquillian.drone.impl.CachingCallableImpl.call(CachingCallableImpl.java:44)
07:48:53 at org.jboss.arquillian.core.impl.threading.ThreadedExecutorService$ContextualCallable.call(ThreadedExecutorService.java:89)
07:48:53 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
07:48:53 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
07:48:53 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
07:48:53 at java.lang.Thread.run(Thread.java:745)
07:48:53 Caused by: java.lang.IllegalStateException: This is not a JSON Array.
07:48:53 at com.google.gson.JsonElement.getAsJsonArray(JsonElement.java:106)
07:48:53 at org.jboss.arquillian.drone.webdriver.binary.downloading.source.GitHubSource.getReleaseForVersion(GitHubSource.java:103)
07:48:53 at org.jboss.arquillian.drone.webdriver.binary.handler.AbstractBinaryHandler.downloadAndPrepare(AbstractBinaryHandler.java:161)
07:48:53 at org.jboss.arquillian.drone.webdriver.binary.handler.AbstractBinaryHandler.checkAndSetBinary(AbstractBinaryHandler.java:59)
07:48:53 at org.jboss.arquillian.drone.webdriver.factory.FirefoxDriverFactory.getCapabilities(FirefoxDriverFactory.java:107)
07:48:53 at org.jboss.arquillian.drone.webdriver.factory.FirefoxDriverFactory.createInstance(FirefoxDriverFactory.java:73)
07:48:53 at org.jboss.arquillian.drone.webdriver.factory.FirefoxDriverFactory.createInstance(FirefoxDriverFactory.java:39)
07:48:53 at org.jboss.arquillian.drone.webdriver.factory.WebDriverFactory.createInstance(WebDriverFactory.java:127)
07:48:53 at org.jboss.arquillian.drone.webdriver.factory.WebDriverFactory.createInstance(WebDriverFactory.java:38)
07:48:53 at org.jboss.arquillian.drone.impl.DroneConfigurator$1.createInstance(DroneConfigurator.java:112)
07:48:53 at org.jboss.arquillian.drone.impl.CachingCallableImpl.call(CachingCallableImpl.java:44)
07:48:53 at org.jboss.arquillian.core.impl.threading.ThreadedExecutorService$ContextualCallable.call(ThreadedExecutorService.java:89)
07:48:53 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
07:48:53 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
07:48:53 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
07:48:53 at java.lang.Thread.run(Thread.java:745)
{noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 7 months
[JBoss JIRA] (ARQ-2047) Use of Java 8 lambdas by injected class causes injection to fail silently
by Dipak Pawar (JIRA)
[ https://issues.jboss.org/browse/ARQ-2047?page=com.atlassian.jira.plugin.s... ]
Dipak Pawar reassigned ARQ-2047:
--------------------------------
Assignee: Dipak Pawar
> Use of Java 8 lambdas by injected class causes injection to fail silently
> -------------------------------------------------------------------------
>
> Key: ARQ-2047
> URL: https://issues.jboss.org/browse/ARQ-2047
> Project: Arquillian
> Issue Type: Feature Request
> Components: Base Implementation
> Affects Versions: 1.1.11.Final
> Environment: Eclipse Neon, Windows
> Reporter: Colin Thorburn
> Assignee: Dipak Pawar
>
> Have seen this bug elsewhere marked as resolved but it clearly isn't.
> To reproduce simply create a Junit 4 Arquiliian test in which EntityManager and UserTransaction fields are annontated for injection.
> Devise an @Test method contriving the use of (say) Runnable. Call a method in another class using the Runnable as a parameter
> Code using an anonymous inner class idiom; everything works fine.
> Code it as a lambda expression and, bizarrely, only the EntityManager is not injected (utx is OK!). No hint of anything awry in the log, no exception thrown, field is simply left null.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 7 months
[JBoss JIRA] (ARQ-2047) Use of Java 8 lambdas by injected class causes injection to fail silently
by Dipak Pawar (JIRA)
[ https://issues.jboss.org/browse/ARQ-2047?page=com.atlassian.jira.plugin.s... ]
Dipak Pawar edited comment on ARQ-2047 at 5/15/17 7:42 AM:
-----------------------------------------------------------
[~cthorburn8], I have tried to reproduce this issue as per steps mentioned by you. But I couldn't reproduce your mentioned behavior for lambda expression. You can look for my test project [here|https://github.com/dipak-pawar/ARQ-2047-test]
Can you please share your project where this issue is reproducing? Maybe something is missing in my project.
was (Author: dipakpawar231):
[~cthorburn8], I have tried to reproduce this issue as per steps mentioned by you. But I couldn't reproduce your mentioned behavior for lambda expression. You can look for my test project [here|https://github.com/dipak-pawar/ARQ-2047-test]
Can you please try to share your project where this issue is reproducing? Maybe something is missing in my project.
> Use of Java 8 lambdas by injected class causes injection to fail silently
> -------------------------------------------------------------------------
>
> Key: ARQ-2047
> URL: https://issues.jboss.org/browse/ARQ-2047
> Project: Arquillian
> Issue Type: Feature Request
> Components: Base Implementation
> Affects Versions: 1.1.11.Final
> Environment: Eclipse Neon, Windows
> Reporter: Colin Thorburn
>
> Have seen this bug elsewhere marked as resolved but it clearly isn't.
> To reproduce simply create a Junit 4 Arquiliian test in which EntityManager and UserTransaction fields are annontated for injection.
> Devise an @Test method contriving the use of (say) Runnable. Call a method in another class using the Runnable as a parameter
> Code using an anonymous inner class idiom; everything works fine.
> Code it as a lambda expression and, bizarrely, only the EntityManager is not injected (utx is OK!). No hint of anything awry in the log, no exception thrown, field is simply left null.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 7 months
[JBoss JIRA] (ARQ-2047) Use of Java 8 lambdas by injected class causes injection to fail silently
by Dipak Pawar (JIRA)
[ https://issues.jboss.org/browse/ARQ-2047?page=com.atlassian.jira.plugin.s... ]
Dipak Pawar commented on ARQ-2047:
----------------------------------
[~cthorburn8], I have tried to reproduce this issue as per steps mentioned by you. But I couldn't reproduce your mentioned behavior for lambda expression. You can look for my test project [here|https://github.com/dipak-pawar/ARQ-2047-test]
Can you please try to share your project where this issue is reproducing? Maybe something is missing in my project.
> Use of Java 8 lambdas by injected class causes injection to fail silently
> -------------------------------------------------------------------------
>
> Key: ARQ-2047
> URL: https://issues.jboss.org/browse/ARQ-2047
> Project: Arquillian
> Issue Type: Feature Request
> Components: Base Implementation
> Affects Versions: 1.1.11.Final
> Environment: Eclipse Neon, Windows
> Reporter: Colin Thorburn
>
> Have seen this bug elsewhere marked as resolved but it clearly isn't.
> To reproduce simply create a Junit 4 Arquiliian test in which EntityManager and UserTransaction fields are annontated for injection.
> Devise an @Test method contriving the use of (say) Runnable. Call a method in another class using the Runnable as a parameter
> Code using an anonymous inner class idiom; everything works fine.
> Code it as a lambda expression and, bizarrely, only the EntityManager is not injected (utx is OK!). No hint of anything awry in the log, no exception thrown, field is simply left null.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 7 months
[JBoss JIRA] (ARQ-2088) When test is skipped because of an assumption, Arquillian's test result is passed
by Dipak Pawar (JIRA)
[ https://issues.jboss.org/browse/ARQ-2088?page=com.atlassian.jira.plugin.s... ]
Dipak Pawar commented on ARQ-2088:
----------------------------------
It has nothing to do with core, we have bug in reporter. Look for following events
{code}
(E) ManagerProcessing
(O) LoadableExtensionLoader.load
(E) ServiceRegistryLoader
(E) ManagerStarted
(O) ReporterLifecycleManager.observeFirstEvent
(E) ExecutionStore
(O) ConfigurationRegistrar.loadConfiguration
(E) ArquillianDescriptorImpl
(O) ProtocolRegistryCreator.createRegistry
(E) ProtocolRegistry
(O) ContainerRegistryCreator.createRegistry
(E) LocalContainerRegistry
(O) ReporterConfigurator.configure
(E) ReporterConfiguration
(E) BeforeSuite
(I) TestContextHandler.createSuiteContext
(O) ArquillianCoreReporterLifecycleManager.startTestSuite
(E) TestSuiteSection
(O) ReporterLifecycleManager.observeEventsForAllSections
(O) ContainerEventController.execute
(E) SetupContainers
(O) ClientDeployerCreator.createClientSideDeployer
(E) ClientDeployer
(O) ClientContainerControllerCreator.createClientSideContainerController
(E) ClientContainerController
(O) ContainerLifecycleController.setupContainers
(E) StartSuiteContainers
(O) ContainerLifecycleController.startSuiteContainers
(O) EnvironmentReportCreator.startTestSuite
(E) TestSuiteConfigurationSection
(O) ReporterLifecycleManager.observeEventsForAllSections
(E) BeforeClass
(I) TestContextHandler.createSuiteContext
(I) TestContextHandler.createClassContext
(E) TestClass
(O) ArquillianCoreReporterLifecycleManager.startTestClass
(E) TestClassSection
(O) ReporterLifecycleManager.observeEventsForAllSections
(O) ContainerEventController.execute
(E) StartClassContainers
(O) ContainerLifecycleController.startClassContainers
(E) GenerateDeployment
(O) DeploymentGenerator.generateDeployment
(E) DeploymentScenario
(E) DeployManagedDeployments
(O) ContainerDeployController.deployManaged
(O) ContainerRestarter.restart
(O) ClientBeforeAfterLifecycleEventExecuter.on
(E) RulesEnrichment
(I) TestContextHandler.createSuiteContext
(I) TestContextHandler.createClassContext
(E) TestClass
(I) TestContextHandler.createTestContext
(I) ContainerEventController.createBeforeContext
(O) RulesEnricher.enrichRulesAndTestInstance
(O) ClientBeforeAfterLifecycleEventExecuter.on
(E) BeforeRules
(I) TestContextHandler.createSuiteContext
(I) TestContextHandler.createClassContext
(E) TestClass
(I) TestContextHandler.createTestContext
(I) ContainerEventController.createBeforeContext
(O) RulesEnricher.enrichStatement
(E) BeforeEnrichment
(E) AfterEnrichment
(O) ClientBeforeAfterLifecycleEventExecuter.on
(E) Before
(I) TestContextHandler.createSuiteContext
(I) TestContextHandler.createClassContext
(E) TestClass
(I) TestContextHandler.createTestContext
(I) ContainerEventController.createBeforeContext
(O) ArquillianCoreReporterLifecycleManager.startTestMethod
(E) TestMethodSection
(O) ReporterLifecycleManager.observeEventsForAllSections
(O) TestInstanceEnricher.enrich
(E) BeforeEnrichment
(E) AfterEnrichment
(O) ClientBeforeAfterLifecycleEventExecuter.on
(E) Test
(I) TestContextHandler.createSuiteContext
(I) TestContextHandler.createClassContext
(E) TestClass
(I) TestContextHandler.createTestContext
(I) ContainerEventController.createTestContext
(O) ClientTestExecuter.execute
(E) LocalExecutionEvent
(O) LocalTestExecuter.execute
This should fail
(E) TestResult
(E) After
(I) TestContextHandler.createSuiteContext
(I) TestContextHandler.createClassContext
(E) TestClass
(I) TestContextHandler.createTestContext
(I) UpdateTestResultBeforeAfter.update
(I) ContainerEventController.createAfterContext
(O) ClientBeforeAfterLifecycleEventExecuter.on
(O) ArquillianCoreReporterLifecycleManager.stopTestMethod
(E) TestMethodSection
(O) ReporterLifecycleManager.observeEventsForAllSections
(E) ComparisonFailure
(E) ComparisonFailure
(E) AfterRules
(I) TestContextHandler.createSuiteContext
(I) TestContextHandler.createClassContext
(E) TestClass
(I) TestContextHandler.createTestContext
(I) UpdateTestResultBeforeAfter.update
(I) ContainerEventController.createAfterContext
(O) ClientBeforeAfterLifecycleEventExecuter.on
(O) ArquillianCoreReporterLifecycleManager.stopTestMethod
(E) TestMethodSection
(O) ReporterLifecycleManager.observeEventsForAllSections
(E) AfterClass
(I) TestContextHandler.createSuiteContext
(I) TestContextHandler.createClassContext
(E) TestClass
(O) ClientBeforeAfterLifecycleEventExecuter.on
(O) ContainerEventController.execute
(E) UnDeployManagedDeployments
(O) ContainerDeployController.undeployManaged
(E) StopManualContainers
(O) ContainerLifecycleController.stopManualContainers
(E) StopClassContainers
(O) ContainerLifecycleController.stopClassContainers
(O) ArquillianCoreReporterLifecycleManager.stopTestClass
(E) TestClassSection
(O) ReporterLifecycleManager.observeEventsForAllSections
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.669 sec <<< FAILURE! - in org.arquillian.reporter.FailingTest
runFailingTest(org.arquillian.reporter.FailingTest) Time elapsed: 0.095 sec <<< FAILURE!
org.junit.ComparisonFailure: expected:<[0]> but was:<[1]>
at org.arquillian.reporter.FailingTest.runFailingTest(FailingTest.java:25)
(E) AfterSuite
(I) TestContextHandler.createSuiteContext
(O) ContainerEventController.execute
(E) StopSuiteContainers
(O) ContainerLifecycleController.stopSuiteContainers
(O) ArquillianCoreReporterLifecycleManager.stopTestSuite
(E) TestSuiteSection
(O) ReporterLifecycleManager.observeEventsForAllSections
(E) ManagerStopping
(O) ReporterLifecycleManager.observeLastEvent
{code}
We are observing wrong event `AfterTest` in reporter. We should observe `AfterTestLifecycleEvent` from which AfterTest is inhereting, invoke fire for reporter only if observing event is instance of `AfterTestLifeCycleEvent`
Opened isssue for reporter on [GH|https://github.com/arquillian/arquillian-reporter/issues/20].
Fixed in [PR|https://github.com/arquillian/arquillian-reporter/pull/21]
Thanks,
Dipak
> When test is skipped because of an assumption, Arquillian's test result is passed
> ---------------------------------------------------------------------------------
>
> Key: ARQ-2088
> URL: https://issues.jboss.org/browse/ARQ-2088
> Project: Arquillian
> Issue Type: Enhancement
> Components: core
> Affects Versions: 1.1.13.Final
> Reporter: Matous Jobanek
>
> When you run Arquillian test with an assumption: {{Assume.assumeFalse(true);}} then the test is skipped. The same also say both IDE and maven surefire, but Arquillian's {{TestResult}} retrieved in {{After}} phase contains status Passed.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 7 months