January 2018 - arquillian-issues - Jboss List Archives

[JBoss JIRA] (ARQ-2172) Remove duplication in TestRunnerAdaptor

by Bartosz Majsak (JIRA)

Bartosz Majsak created ARQ-2172: ----------------------------------- Summary: Remove duplication in TestRunnerAdaptor Key: ARQ-2172 URL: https://issues.jboss.org/browse/ARQ-2172 Project: Arquillian Issue Type: Enhancement Components: Base Implementation Reporter: Bartosz Majsak The code of the TestRunnerAdaptor management is same in both JUnit runner and JUnit class rule. The same can be also applied to the logic that invokes the test method. I've moved the code to separated classes that are used by both implementations -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2169) Already Exported/Exploded directory should delete if exists before exploding/exporting

by Bartosz Majsak (JIRA)

[ https://issues.jboss.org/browse/ARQ-2169?page=com.atlassian.jira.plugin.s... ] Bartosz Majsak updated ARQ-2169: -------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > Already Exported/Exploded directory should delete if exists before exploding/exporting > ---------------------------------------------------------------------------------------- > > Key: ARQ-2169 > URL: https://issues.jboss.org/browse/ARQ-2169 > Project: Arquillian > Issue Type: Bug > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Dipak Pawar > Assignee: Dipak Pawar > > Running deploymentExportExploded= true after deploymentExportExploded = false or vice versa without mvn clean throws illegal argument exception -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2169) Already Exported/Exploded directory should delete if exists before exploding/exporting

by Bartosz Majsak (JIRA)

[ https://issues.jboss.org/browse/ARQ-2169?page=com.atlassian.jira.plugin.s... ] Bartosz Majsak updated ARQ-2169: -------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/arquillian/arquillian-core/pull/152 > Already Exported/Exploded directory should delete if exists before exploding/exporting > ---------------------------------------------------------------------------------------- > > Key: ARQ-2169 > URL: https://issues.jboss.org/browse/ARQ-2169 > Project: Arquillian > Issue Type: Bug > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Dipak Pawar > Assignee: Dipak Pawar > > Running deploymentExportExploded= true after deploymentExportExploded = false or vice versa without mvn clean throws illegal argument exception -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2169) Already Exported/Exploded directory should delete if exists before exploding/exporting

by Bartosz Majsak (JIRA)

[ https://issues.jboss.org/browse/ARQ-2169?page=com.atlassian.jira.plugin.s... ] Bartosz Majsak updated ARQ-2169: -------------------------------- Component/s: Base Implementation > Already Exported/Exploded directory should delete if exists before exploding/exporting > ---------------------------------------------------------------------------------------- > > Key: ARQ-2169 > URL: https://issues.jboss.org/browse/ARQ-2169 > Project: Arquillian > Issue Type: Bug > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Dipak Pawar > Assignee: Dipak Pawar > > Running deploymentExportExploded= true after deploymentExportExploded = false or vice versa without mvn clean throws illegal argument exception -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2171) @ClassRules should not be executed in container

by Matous Jobanek (JIRA)

[ https://issues.jboss.org/browse/ARQ-2171?page=com.atlassian.jira.plugin.s... ] Matous Jobanek updated ARQ-2171: -------------------------------- Git Pull Request: https://github.com/arquillian/arquillian-core/pull/156 > @ClassRules should not be executed in container > ----------------------------------------------- > > Key: ARQ-2171 > URL: https://issues.jboss.org/browse/ARQ-2171 > Project: Arquillian > Issue Type: Bug > Components: core > Affects Versions: 1.2.0.Final > Reporter: Matous Jobanek > Assignee: Matous Jobanek > > For the same reason why {{@Before/After Class}} methods are not invoked in a container (the state between {{@Test}} methods is not kept), the {{@ClassRules}} should be prevented from running there as well. > Currently, they are executed on both sides - on client & in container -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2171) @ClassRules should not be executed in container

by Matous Jobanek (JIRA)

[ https://issues.jboss.org/browse/ARQ-2171?page=com.atlassian.jira.plugin.s... ] Matous Jobanek reassigned ARQ-2171: ----------------------------------- Assignee: Matous Jobanek > @ClassRules should not be executed in container > ----------------------------------------------- > > Key: ARQ-2171 > URL: https://issues.jboss.org/browse/ARQ-2171 > Project: Arquillian > Issue Type: Bug > Components: core > Affects Versions: 1.2.0.Final > Reporter: Matous Jobanek > Assignee: Matous Jobanek > > For the same reason why {{@Before/After Class}} methods are not invoked in a container (the state between {{@Test}} methods is not kept), the {{@ClassRules}} should be prevented from running there as well. > Currently, they are executed on both sides - on client & in container -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2171) @ClassRules should not be executed in container

by Matous Jobanek (JIRA)

Matous Jobanek created ARQ-2171: ----------------------------------- Summary: @ClassRules should not be executed in container Key: ARQ-2171 URL: https://issues.jboss.org/browse/ARQ-2171 Project: Arquillian Issue Type: Bug Components: core Affects Versions: 1.2.0.Final Reporter: Matous Jobanek For the same reason why {{@Before/After Class}} methods are not invoked in a container (the state between {{@Test}} methods is not kept), the {{@ClassRules}} should be prevented from running there as well. Currently, they are executed on both sides - on client & in container -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2170) RulesEnricher doubles each test enrichment

by kostd kostd (JIRA)

[ https://issues.jboss.org/browse/ARQ-2170?page=com.atlassian.jira.plugin.s... ] kostd kostd edited comment on ARQ-2170 at 1/19/18 1:03 PM: ----------------------------------------------------------- Created arquillian-junit-core.jar without testInstance toEnrich addition. Now only one enrichment, only one soap call, Rules works as usual. was (Author: kostd): Created arquillian-junit-core without testInstance toEnrich addition. Now only one enrichment, only one soap call, Rules works as usual. > RulesEnricher doubles each test enrichment > ------------------------------------------ > > Key: ARQ-2170 > URL: https://issues.jboss.org/browse/ARQ-2170 > Project: Arquillian > Issue Type: Bug > Components: core > Environment: arquillian-junit-core-1.1.11.Final (all versions affected) > Reporter: kostd kostd > > RulesEnricher created in ARQ-1954 > 1. RulesEnricher is not implementor of TestEnricher, so it cannot be overrided through LoadableExtension. > 2. RulesEnricher#enrichRulesAndTestInstance adds into collection toEnrich test instance: > {code} > toEnrich.add(event.getTestInstance()); > {code} > https://github.com/arquillian/arquillian-core/blob/master/junit/core/src/... > So, if MyTest have`nt field rules, will be only one MyTest enrichment. If MyTest contains one or more test rule, will be two MyTest enrichments. > Each testEnrichment of MyTest do a soap call to server to prepare data for test. It is very important to me, one or two soap call will happen. > How can I change this behaviour? -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2170) RulesEnricher doubles each test enrichment

by kostd kostd (JIRA)

[ https://issues.jboss.org/browse/ARQ-2170?page=com.atlassian.jira.plugin.s... ] kostd kostd commented on ARQ-2170: ---------------------------------- Created arquillian-junit-core without testInstance toEnrich addition. Now only one enrichment, only one soap call, Rules works as usual. > RulesEnricher doubles each test enrichment > ------------------------------------------ > > Key: ARQ-2170 > URL: https://issues.jboss.org/browse/ARQ-2170 > Project: Arquillian > Issue Type: Bug > Components: core > Environment: arquillian-junit-core-1.1.11.Final (all versions affected) > Reporter: kostd kostd > > RulesEnricher created in ARQ-1954 > 1. RulesEnricher is not implementor of TestEnricher, so it cannot be overrided through LoadableExtension. > 2. RulesEnricher#enrichRulesAndTestInstance adds into collection toEnrich test instance: > {code} > toEnrich.add(event.getTestInstance()); > {code} > https://github.com/arquillian/arquillian-core/blob/master/junit/core/src/... > So, if MyTest have`nt field rules, will be only one MyTest enrichment. If MyTest contains one or more test rule, will be two MyTest enrichments. > Each testEnrichment of MyTest do a soap call to server to prepare data for test. It is very important to me, one or two soap call will happen. > How can I change this behaviour? -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 11 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2170) RulesEnricher doubles each test enrichment

by kostd kostd (JIRA)

kostd kostd created ARQ-2170: -------------------------------- Summary: RulesEnricher doubles each test enrichment Key: ARQ-2170 URL: https://issues.jboss.org/browse/ARQ-2170 Project: Arquillian Issue Type: Bug Components: core Environment: arquillian-junit-core-1.1.11.Final (all versions affected) Reporter: kostd kostd RulesEnricher created in ARQ-1954 1. RulesEnricher is not implementor of TestEnricher, so it cannot be overrided through LoadableExtension. 2. RulesEnricher#enrichRulesAndTestInstance adds into collection toEnrich test instance: {code} toEnrich.add(event.getTestInstance()); {code} https://github.com/arquillian/arquillian-core/blob/master/junit/core/src/... So, if MyTest have`nt field rules, will be only one MyTest enrichment. If MyTest contains one or more test rule, will be two MyTest enrichments. Each testEnrichment of MyTest do a soap call to server to prepare data for test. It is very important to me, one or two soap call will happen. How can I change this behaviour? -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

arquillian-issues January 2018