March 2017 - arquillian-issues - Jboss List Archives

[JBoss JIRA] (ARQ-1699) PhantomJS resolution by Spacelift

by Matous Jobanek (JIRA)

[ https://issues.jboss.org/browse/ARQ-1699?page=com.atlassian.jira.plugin.s... ] Matous Jobanek updated ARQ-1699: -------------------------------- Fix Version/s: drone_2.1.0.Beta1 (was: drone_2.1.0.Final) > PhantomJS resolution by Spacelift > --------------------------------- > > Key: ARQ-1699 > URL: https://issues.jboss.org/browse/ARQ-1699 > Project: Arquillian > Issue Type: Task > Components: Extension - Drone > Reporter: Karel Piwko > Assignee: Matous Jobanek > Fix For: drone_2.1.0.Beta1 > > > PhantomJS resolution should be done via Spacelift. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ARQGRA-500) Navigation with URL parameters

by Matous Jobanek (JIRA)

[ https://issues.jboss.org/browse/ARQGRA-500?page=com.atlassian.jira.plugin... ] Matous Jobanek commented on ARQGRA-500: --------------------------------------- [~vsevolodgolovanov] interesting solution. If you want, you can try to incorporate it into Graphene and cover it by tests. > Navigation with URL parameters > ------------------------------ > > Key: ARQGRA-500 > URL: https://issues.jboss.org/browse/ARQGRA-500 > Project: Arquillian Graphene > Issue Type: Feature Request > Reporter: Vsevolod Golovanov > > I need to add a dynamic URL parameter to a location of a page before navigating to it. > I don't want to use Selenium's navigation, because I would then need to reinvent/shoehorn Graphene's location deciding. > A special landing page would be a pretty ugly workaround. > I get that it's not possible with annotations. But at least support this with Graphene.goTo methods. > Actually it may be possible with annotations, if you could supply some provider class? E.g. {{\@Location(value = "MyView.xhtml", parameterProvider = MyParameterProvider.class)}}. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ARQGRA-496) JavaScript interface returns null instead of false for Booleans

by Matous Jobanek (JIRA)

[ https://issues.jboss.org/browse/ARQGRA-496?page=com.atlassian.jira.plugin... ] Matous Jobanek commented on ARQGRA-496: --------------------------------------- Hi [~vsevolodgolovanov] Thank you for reporting this. If you have some working fix already for this issue, feel free to send PR. We would be very thankful. Our time and knowledge for maintaining this project are very limited, so we are glad for any help. > JavaScript interface returns null instead of false for Booleans > --------------------------------------------------------------- > > Key: ARQGRA-496 > URL: https://issues.jboss.org/browse/ARQGRA-496 > Project: Arquillian Graphene > Issue Type: Bug > Affects Versions: 2.1.0.Final > Reporter: Vsevolod Golovanov > > {code} > @JavaScript(value = "MyObject") > public interface MyJsInterface { > Boolean getSomeValue(); > } > {code} > If in js MyObject.someValue === false, then attempting to get the value via Graphene's MyJsInterface will result in null getting returned, instead of false. > If you declare a primitive boolean return type, then null will get silently 'casted' to false, but that's not something I want either. I want to distinguish the three states with Boolean. I want an exception for null with boolean. > {code:title=call.js/invokeInterface} > if (property && target[property]) { > return target[property]; > } > {code} > There are 2 problems here. > # Instead of {{target\[property\]}} there should be an explicit {{typeof(target\[property\]}) !== 'undefined')}} check (or {{property in target}}, if you want to distinguish the "property is defined, but its value is undefined" case). > # When invokeInterface doesn't find neither getter, nor setter, nor method it quits without returning or throwing anything. There should be some kind of explicit handling if it can't find property/method at all. > The problem probably affects not only Booleans, but other types with falsey values too. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ARQGRA-494) Enrich WebElements returned by JavascriptExecutor (to protect against staleness etc)

by Matous Jobanek (JIRA)

[ https://issues.jboss.org/browse/ARQGRA-494?page=com.atlassian.jira.plugin... ] Matous Jobanek commented on ARQGRA-494: --------------------------------------- Hi [~vsevolodgolovanov] Thank you for reporting this. If you have some working fix already for this issue, feel free to send PR. We would be very thankful. Our time and knowledge for maintaining this project are very limited, so we are glad for any help. > Enrich WebElements returned by JavascriptExecutor (to protect against staleness etc) > ------------------------------------------------------------------------------------ > > Key: ARQGRA-494 > URL: https://issues.jboss.org/browse/ARQGRA-494 > Project: Arquillian Graphene > Issue Type: Bug > Affects Versions: 2.1.0.Final > Reporter: Vsevolod Golovanov > > ARQGRA-252 took care of elements found by manually calling SearchContext#findElement*, but there is still org.openqa.selenium.JavascriptExecutor: > {code} > jsExecutor.executeScript("return $('*').toArray();"); > {code} > This would return unproxified WebElement instances. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ARQGRA-500) Navigation with URL parameters

by Vsevolod Golovanov (JIRA)

[ https://issues.jboss.org/browse/ARQGRA-500?page=com.atlassian.jira.plugin... ] Vsevolod Golovanov commented on ARQGRA-500: ------------------------------------------- An example implementation of the LocationParameterProvider approach via overriding Graphene's LocationDecider is at http://stackoverflow.com/a/43115879/1341535 Now the interface seems weird to me. Maybe annotations would be more in line here with other Graphene stuff. \@LocationParameters on a field (outjection at navigation time) or a method (callback). > Navigation with URL parameters > ------------------------------ > > Key: ARQGRA-500 > URL: https://issues.jboss.org/browse/ARQGRA-500 > Project: Arquillian Graphene > Issue Type: Feature Request > Reporter: Vsevolod Golovanov > > I need to add a dynamic URL parameter to a location of a page before navigating to it. > I don't want to use Selenium's navigation, because I would then need to reinvent/shoehorn Graphene's location deciding. > A special landing page would be a pretty ugly workaround. > I get that it's not possible with annotations. But at least support this with Graphene.goTo methods. > Actually it may be possible with annotations, if you could supply some provider class? E.g. {{\@Location(value = "MyView.xhtml", parameterProvider = MyParameterProvider.class)}}. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ARQGRA-500) Navigation with URL parameters

by Vsevolod Golovanov (JIRA)

[ https://issues.jboss.org/browse/ARQGRA-500?page=com.atlassian.jira.plugin... ] Vsevolod Golovanov edited comment on ARQGRA-500 at 3/30/17 5:13 AM: -------------------------------------------------------------------- Then again, some parameter provider class wouldn't know the context to decide on parameters. Only the test does. Some location decider probably can get the current test instance and call some callback on it. The test just needs to implement the interface ParameterProvider - this would be the trigger. No need to alter the \@Location annotation. Upd: it's probably not possible to "get the current test instance" without hardcoding some specific test framework like JUnit. Upd2: it should be possible! Otherwise how would Graphene's annotations work. They know the test object, see org.jboss.arquillian.test.spi.TestEnricher. was (Author: vsevolodgolovanov): Then again, some parameter provider class wouldn't know the context to decide on parameters. Only the test does. Some location decider probably can get the current test instance and call some callback on it. The test just needs to implement the interface ParameterProvider - this would be the trigger. No need to alter the \@Location annotation. Upd: it's probably not possible to "get the current test instance" without hardcoding some specific test framework like JUnit. > Navigation with URL parameters > ------------------------------ > > Key: ARQGRA-500 > URL: https://issues.jboss.org/browse/ARQGRA-500 > Project: Arquillian Graphene > Issue Type: Feature Request > Reporter: Vsevolod Golovanov > > I need to add a dynamic URL parameter to a location of a page before navigating to it. > I don't want to use Selenium's navigation, because I would then need to reinvent/shoehorn Graphene's location deciding. > A special landing page would be a pretty ugly workaround. > I get that it's not possible with annotations. But at least support this with Graphene.goTo methods. > Actually it may be possible with annotations, if you could supply some provider class? E.g. {{\@Location(value = "MyView.xhtml", parameterProvider = MyParameterProvider.class)}}. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ARQGRA-500) Navigation with URL parameters

by Vsevolod Golovanov (JIRA)

[ https://issues.jboss.org/browse/ARQGRA-500?page=com.atlassian.jira.plugin... ] Vsevolod Golovanov edited comment on ARQGRA-500 at 3/30/17 5:01 AM: -------------------------------------------------------------------- Then again, some parameter provider class wouldn't know the context to decide on parameters. Only the test does. Some location decider probably can get the current test instance and call some callback on it. The test just needs to implement the interface ParameterProvider - this would be the trigger. No need to alter the \@Location annotation. Upd: it's probably not possible to "get the current test instance" without hardcoding some specific test framework like JUnit. was (Author: vsevolodgolovanov): Then again, some parameter provider class wouldn't know the context to decide on parameters. Only the test does. Some location decider probably can get the current test instance and call some callback on it. The test just needs to implement the interface ParameterProvider - this would be the trigger. No need to alter the \@Location annotation. > Navigation with URL parameters > ------------------------------ > > Key: ARQGRA-500 > URL: https://issues.jboss.org/browse/ARQGRA-500 > Project: Arquillian Graphene > Issue Type: Feature Request > Reporter: Vsevolod Golovanov > > I need to add a dynamic URL parameter to a location of a page before navigating to it. > I don't want to use Selenium's navigation, because I would then need to reinvent/shoehorn Graphene's location deciding. > A special landing page would be a pretty ugly workaround. > I get that it's not possible with annotations. But at least support this with Graphene.goTo methods. > Actually it may be possible with annotations, if you could supply some provider class? E.g. {{\@Location(value = "MyView.xhtml", parameterProvider = MyParameterProvider.class)}}. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ARQGRA-484) Enriched element is not equal to the same element

by Matous Jobanek (JIRA)

[ https://issues.jboss.org/browse/ARQGRA-484?page=com.atlassian.jira.plugin... ] Matous Jobanek commented on ARQGRA-484: --------------------------------------- [~vsevolodgolovanov] Thank you for your investigation. Any contribution/help in this issue will be very welcome. > Enriched element is not equal to the same element > ------------------------------------------------- > > Key: ARQGRA-484 > URL: https://issues.jboss.org/browse/ARQGRA-484 > Project: Arquillian Graphene > Issue Type: Bug > Affects Versions: 2.1.0.Alpha3 > Reporter: Jiří Štefek > > After upgrading to 2.1.0.Alpha3 from Alpha2, the following (simplified) test won't pass: > {code} > @FindBy(id="id") > private WebElement e; > @Test > private void test(){ > e.equals(e) > } > {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ARQGRA-484) Enriched element is not equal to the same element

by Vsevolod Golovanov (JIRA)

[ https://issues.jboss.org/browse/ARQGRA-484?page=com.atlassian.jira.plugin... ] Vsevolod Golovanov edited comment on ARQGRA-484 at 3/30/17 3:36 AM: -------------------------------------------------------------------- <Moved to PR154> was (Author: vsevolodgolovanov): {code:title=PR154}if (obj instanceof GrapheneElementImpl) { obj = ((GrapheneElementImpl) obj).element; } return element.equals(obj); {code} {{obj instanceof GrapheneElementImpl}} would most of the time evaluate to false because obj would be a proxy. So the execution would move on to {{element.equals(obj)}}, where it relies on Selenium's RemoteWebElement#equals to unwrap the obj (via the WrapsElement interface and its getWrappedElement() method). Might as well rely on it in case of {{obj instanceof GrapheneElementImpl}} evaluating to true. In fact, whenever there are proxies involved, code like {{otherObj.privateField}} seems iffy. What if a proxy sometimes extends the Impl class? > Enriched element is not equal to the same element > ------------------------------------------------- > > Key: ARQGRA-484 > URL: https://issues.jboss.org/browse/ARQGRA-484 > Project: Arquillian Graphene > Issue Type: Bug > Affects Versions: 2.1.0.Alpha3 > Reporter: Jiří Štefek > > After upgrading to 2.1.0.Alpha3 from Alpha2, the following (simplified) test won't pass: > {code} > @FindBy(id="id") > private WebElement e; > @Test > private void test(){ > e.equals(e) > } > {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ARQGRA-484) Enriched element is not equal to the same element

by Vsevolod Golovanov (JIRA)

[ https://issues.jboss.org/browse/ARQGRA-484?page=com.atlassian.jira.plugin... ] Vsevolod Golovanov edited comment on ARQGRA-484 at 3/30/17 3:36 AM: -------------------------------------------------------------------- <Moved to PR154> was (Author: vsevolodgolovanov): But sometimes a proxy doesn't implement WrapsElement, because it doesn't proxy a GrapheneElement, but a RemoteWebElement directly. E.g. {{driver.switchTo().activeElement()}}. This may be a separate bug... > Enriched element is not equal to the same element > ------------------------------------------------- > > Key: ARQGRA-484 > URL: https://issues.jboss.org/browse/ARQGRA-484 > Project: Arquillian Graphene > Issue Type: Bug > Affects Versions: 2.1.0.Alpha3 > Reporter: Jiří Štefek > > After upgrading to 2.1.0.Alpha3 from Alpha2, the following (simplified) test won't pass: > {code} > @FindBy(id="id") > private WebElement e; > @Test > private void test(){ > e.equals(e) > } > {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 9 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

arquillian-issues March 2017