[
https://issues.jboss.org/browse/ARQ-1368?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč updated ARQ-1368:
----------------------------
Description:
If we have following observer:
{code}.observe(request().uri().contains("__richfacesPushAsync").index(1)){code}
we want observe first request matching criteria - (URI containing given string), however
that is not what happens:
the {{index(1)}} calls method
[{{addFilter}}|https://github.com/arquillian/arquillian-extension-warp/blob/1.0.0.Alpha2/impl/src/main/java/org/jboss/arquillian/warp/impl/client/filter/http/DefaultHttpFilterBuilder.java#L111]
which allows chaining, but this chain [evaluates the newly passed filter before it
evaluates previous
one|https://github.com/arquillian/arquillian-extension-warp/blob/1.0.0.Al...].
----
Reverse the order of evaluation in order to fix semantics of fluent API.
was:
If we are following observer:
{code}.observe(request().uri().contains("__richfacesPushAsync").index(1)){code}
we want observe first request matching criteria - (URI containing given string), however
that is not what happens:
the {{index(1)}} calls method
[{{addFilter}}|https://github.com/arquillian/arquillian-extension-warp/blob/1.0.0.Alpha2/impl/src/main/java/org/jboss/arquillian/warp/impl/client/filter/http/DefaultHttpFilterBuilder.java#L111]
which allows chaining, but this chain [evaluates the newly passed filter before it
evaluates previous
one|https://github.com/arquillian/arquillian-extension-warp/blob/1.0.0.Al...].
----
Reverse the order of evaluation in order to fix semantics of fluent API.
Warp: reverse order of chaining of request builder
--------------------------------------------------
Key: ARQ-1368
URL:
https://issues.jboss.org/browse/ARQ-1368
Project: Arquillian
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: Extension - Warp
Reporter: Lukáš Fryč
Assignee: Lukáš Fryč
Priority: Critical
Fix For: warp_1.0.0.Alpha3
Original Estimate: 30 minutes
Remaining Estimate: 30 minutes
If we have following observer:
{code}.observe(request().uri().contains("__richfacesPushAsync").index(1)){code}
we want observe first request matching criteria - (URI containing given string), however
that is not what happens:
the {{index(1)}} calls method
[{{addFilter}}|https://github.com/arquillian/arquillian-extension-warp/blob/1.0.0.Alpha2/impl/src/main/java/org/jboss/arquillian/warp/impl/client/filter/http/DefaultHttpFilterBuilder.java#L111]
which allows chaining, but this chain [evaluates the newly passed filter before it
evaluates previous
one|https://github.com/arquillian/arquillian-extension-warp/blob/1.0.0.Al...].
----
Reverse the order of evaluation in order to fix semantics of fluent API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira