7:47 p.m.
Dan Allen created ARQ-920:
-----------------------------
Summary: Support @Deployment on non-public member (method or field)
Key: ARQ-920
URL: https://issues.jboss.org/browse/ARQ-920
Project: Arquillian
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Reporter: Dan Allen
Priority: Minor
I don't see a reason why we are forcing the @Deployment member (method or field) to be
public. It's common to have non-public injection points, so it's reasonable to
assume we can honor non-public members for defining a @Deployment as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:49 p.m.
[
https://issues.jboss.org/browse/ARQ-920?page=com.atlassian.jira.plugin.sy...
]
Dan Allen commented on ARQ-920:
-------------------------------
The benefit here is that it reduces one extra keyword that has to be repeatedly typed,
which is going to reduce friction of using Arquillian.
{code:java}
@RunWith(Arquillian.class)
public class MyTestCase {
@Deployment
static JavaArchive createDeployment() {
return ShrinkWrap.create(JavaArchive.class);
}
}
{code}
or
{code:java}
@RunWith(Arquillian.class)
public class MyTestCase {
@Deployment
static JavaArchive deployment = ShrinkWrap.create(JavaArchive.class);
}
{code}
Support @Deployment on non-public member (method or field)
----------------------------------------------------------
Key: ARQ-920
URL: https://issues.jboss.org/browse/ARQ-920
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: Dan Allen
Priority: Minor
Labels: starter
I don't see a reason why we are forcing the @Deployment member (method or field) to
be public. It's common to have non-public injection points, so it's reasonable to
assume we can honor non-public members for defining a @Deployment as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:51 p.m.
[
https://issues.jboss.org/browse/ARQ-920?page=com.atlassian.jira.plugin.sy...
]
Dan Allen commented on ARQ-920:
-------------------------------
Be sure to use a SecurityActions class to scan members and set the accessible flag.
See getFieldsWithAnnotation on this class:
https://github.com/arquillian/arquillian-core/blob/master/test/impl-base/...
Support @Deployment on non-public member (method or field)
----------------------------------------------------------
Key: ARQ-920
URL: https://issues.jboss.org/browse/ARQ-920
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: Dan Allen
Priority: Minor
Labels: starter
I don't see a reason why we are forcing the @Deployment member (method or field) to
be public. It's common to have non-public injection points, so it's reasonable to
assume we can honor non-public members for defining a @Deployment as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:04 p.m.
[
https://issues.jboss.org/browse/ARQ-920?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen updated ARQ-920:
------------------------------
Fix Version/s: 1.0.2.Final
Support @Deployment on non-public member (method or field)
----------------------------------------------------------
Key: ARQ-920
URL: https://issues.jboss.org/browse/ARQ-920
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: Dan Allen
Priority: Minor
Labels: starter
Fix For: 1.0.2.Final
I don't see a reason why we are forcing the @Deployment member (method or field) to
be public. It's common to have non-public injection points, so it's reasonable to
assume we can honor non-public members for defining a @Deployment as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:06 p.m.
[
https://issues.jboss.org/browse/ARQ-920?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen closed ARQ-920.
-----------------------------
Resolution: Partially Completed
protected and private supported via ARQ-1024
Field injection is not a workable option as all client resources would be required in
container as well as on client side.
Support @Deployment on non-public member (method or field)
----------------------------------------------------------
Key: ARQ-920
URL: https://issues.jboss.org/browse/ARQ-920
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Reporter: Dan Allen
Priority: Minor
Labels: starter
Fix For: 1.0.2.Final
I don't see a reason why we are forcing the @Deployment member (method or field) to
be public. It's common to have non-public injection points, so it's reasonable to
assume we can honor non-public members for defining a @Deployment as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4362
days inactive
4432
days old
arquillian-issues@lists.jboss.org
4 comments
2 participants
participants (2)
-
Aslak Knutsen (JIRA) -
Dan Allen (JIRA)