Sanne Grinovero (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%...
) *created* an issue
Hibernate ORM (
https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMWY3ZWNhM2Q0...
) / Improvement (
https://hibernate.atlassian.net/browse/HHH-16092?atlOrigin=eyJpIjoiMWY3ZW...
) HHH-16092 (
https://hibernate.atlassian.net/browse/HHH-16092?atlOrigin=eyJpIjoiMWY3ZW...
) Trim allocation size of CacheKeyImplementation, avoid Objects::deepEquals (
https://hibernate.atlassian.net/browse/HHH-16092?atlOrigin=eyJpIjoiMWY3ZW...
)
Issue Type: Improvement Assignee: Sanne Grinovero (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%...
) Created: 24/Jan/2023 13:54 PM Fix Versions: 6.2.0 Labels: performance Priority: Major
Reporter: Sanne Grinovero (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%...
)
Francesco Nigro (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%...
) identified that the performance of Objects::deepEquals as being used currently by
CacheKeyImplementation is usboptimal, and suggested we only resort to deepEquals in case
the disassembled key is represented by an array.
Additionally, I remember the size of this key object needing to be kept under control for
optimal efficiency as many instances might need to be held in the 2LC; it would seem that
recent improvements have made this key significantly larger.
I plan to introduce a specialized key implementation for the most common case, in which we
don’t have a tenant identifier defined, and the key is not represnted as an array. This
specialized key implementation can then benefit from both optimisations.
(
https://hibernate.atlassian.net/browse/HHH-16092#add-comment?atlOrigin=ey...
) Add Comment (
https://hibernate.atlassian.net/browse/HHH-16092#add-comment?atlOrigin=ey...
)
Get Jira notifications on your phone! Download the Jira Cloud app for Android (
https://play.google.com/store/apps/details?id=com.atlassian.android.jira....
) or iOS (
https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em...
) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:01e0849 )