[hibernate-issues] [JIRA] (HHH-13986) SequenceHiLoGeneratorNoIncrementTest is not testing the right Optimiser

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZDFjNzM1MjQ1... ) / Task ( https://hibernate.atlassian.net/browse/HHH-13986?atlOrigin=eyJpIjoiZDFjNz... ) HHH-13986 ( https://hibernate.atlassian.net/browse/HHH-13986?atlOrigin=eyJpIjoiZDFjNz... ) SequenceHiLoGeneratorNoIncrementTest is not testing the right Optimiser ( https://hibernate.atlassian.net/browse/HHH-13986?atlOrigin=eyJpIjoiZDFjNz... ) Issue Type: Task Assignee: Unassigned Components: hibernate-core Created: 27/Apr/2020 14:13 PM Priority: Major Reporter: Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) The `org.hibernate.id.SequenceHiLoGeneratorNoIncrementTest` test seems designed to test `LegacyHiLoAlgorithmOptimizer`, however an initialization failure is triggered making the test actually verify the samantics of the fallback optimizer. The mistake is best observed by adding a breakpoint in `org.hibernate.id.enhanced.OptimizerFactory#buildOptimizer(java.lang.String, java.lang.Class, int)` . Unfortunately fixing the test will have it change the asserted values; since the goal of this test is to verify strict consistency with the legacy behaviour we need to be careful. ( https://hibernate.atlassian.net/browse/HHH-13986#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-13986#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100125- sha1:c966059 )