]
Cédrik LIME commented on HHH-5469:
----------------------------------
I understand you want to avoid magic strings.
How about logging to the interface ({{org.hibernate.stat.Statistics}}) instead of the
implementation for this particular log? This way, you will be able to swap the
implementation (which the user shouldn't care about) and keep the public information
with no change on the client side.
HHH-3659 is only half done, due to HHH-4989 (i.e. no HQL performance
log when running Java 5)
---------------------------------------------------------------------------------------------
Key: HHH-5469
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5469
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.4, 3.6.0.Beta1
Reporter: Cédrik LIME
Assignee: Steve Ebersole
Priority: Trivial
Fix For: 3.5.5, 3.6.0.Beta3
Original Estimate: 1h
Remaining Estimate: 1h
HHH-3659 introduced a well-deserved HQL execution time log, which is good.
Unfortunately, HHH-4989 (Java 5 concurrent for statistics) didn't pick up those
changes, so no execution time logs when running Java 5.
To fix, add the same log statement to {{ConcurrentStatisticsImpl#queryExecuted(String
hql, int rows, long time)}}:
{code:java}
log.info("HQL: {}, time: {}ms, rows: {}", new Object[]{hql, new Long(time),
Long.valueOf(rows)});
{code}
May I also suggest that we change this particular logger from whichever implementation
class du jour to a {{org.hibernate.performance}} logger.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: