[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-503?pag... ] G Fernandes updated HSEARCH-503: -------------------------------- Attachment: archetype.diff Moved packages from example to com.example -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-503?pag... ] Sanne Grinovero commented on HSEARCH-503: ----------------------------------------- Gustavo, I'm getting a warning which doesn't seem to be a problem as it appears to work fine with your patch but your opinion would be appreciated: {code}[WARNING] org.apache.velocity.runtime.exception.ReferenceException: reference : template = archetype-resources/pom.xml [line 28,column 22] : ${pom.version} is not a valid reference.{code} but the file having "pom.version" is being generated by {{mvn archetype:create-from-project}}, even if I switch to Maven3; you think we should change some plugin version in the parent? Would be nice if it could work without warnings with all Maven2.0x, 2.1.x and 3 not sure if this could be a problem? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-503?pag... ] Sanne Grinovero commented on HSEARCH-503: ----------------------------------------- I've applied your patch; could you please check it. My comments above are not relevant on this issue; still if you could have a quick look to all the Maven warnings while you check this would be nice. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-503?pag... ] Emmanuel Bernard commented on HSEARCH-503: ------------------------------------------ Guys I can't seem to make the archetype business to work. {code}mvn archetype:create -DarchetypeGroupId=org.hibernate -DarchetypeArtifactId=hibernate-search-quickstart -DarchetypeVersion=3.2.0-SNAPSHOT -DgroupId=my.company -DartifactId=quickstart [WARNING] This goal is deprecated. Please use mvn archetype:generate instead [INFO] Defaulting package to group ID: my.company [INFO] ---------------------------------------------------------------------------- [INFO] Using following parameters for creating OldArchetype: hibernate-search-quickstart:3.2.0-SNAPSHOT [INFO] ---------------------------------------------------------------------------- [INFO] Parameter: groupId, Value: my.company [INFO] Parameter: packageName, Value: my.company [INFO] Parameter: package, Value: my.company [INFO] Parameter: artifactId, Value: quickstart [INFO] Parameter: basedir, Value: /Users/manu/projects/notbackedup/search/test-artefact [INFO] Parameter: version, Value: 1.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] Error creating from archetype Embedded error: The META-INF/maven/archetype.xml descriptor cannot be found. {code} Using the new goal {code} mvn archetype:generate -DarchetypeGroupId=org.hibernate -DarchetypeArtifactId=hibernate-search-quickstart -DarchetypeVersion=3.2.0-SNAPSHOT -DgroupId=my.company -DartifactId=quickstart [INFO] Setting property: velocimacro.messages.on => 'false'. [INFO] Setting property: resource.loader => 'classpath'. [INFO] Setting property: resource.manager.logwhenfound => 'false'. [INFO] [archetype:generate {execution: default-cli}] [INFO] Generating project in Interactive mode [WARNING] No archetype repository found. Falling back to central repository (http://repo1.maven.org/maven2). [WARNING] Use -DarchetypeRepository=<your repository> if archetype's repository is elsewhere. [INFO] snapshot org.hibernate:hibernate-search-quickstart:3.2.0-SNAPSHOT: checking for updates from hibernate-search-quickstart-repo [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] The defined artifact is not an archetype [INFO] ------------------------------------------------------------------------ {code} Adjusting the artifact id {code}mvn archetype:generate -DarchetypeGroupId=org.hibernate -DarchetypeArtifactId=hibernate-search-archetype -DarchetypeVersion=3.2.0-SNAPSHOT -DgroupId=my.company -DartifactId=quickstart [INFO] Generating project in Interactive mode [WARNING] No archetype repository found. Falling back to central repository (http://repo1.maven.org/maven2). [WARNING] Use -DarchetypeRepository=<your repository> if archetype's repository is elsewhere. [INFO] snapshot org.hibernate:hibernate-search-archetype:3.2.0-SNAPSHOT: checking for updates from hibernate-search-archetype-repo [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] The defined artifact is not an archetype [INFO] ------------------------------------------------------------------------ {code} Somehow something is wrong (doc or/and archetype) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-503?pag... ] Emmanuel Bernard commented on HSEARCH-503: ------------------------------------------ I've also delayed Gustavo's patch on the archetype dependencies cleaning from HSEARCH-491. Once we've got our act together, we should apply it. In the mean time I will push this issue to 3.2 final -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-503?pag... ] Sanne Grinovero updated HSEARCH-503: ------------------------------------ Assignee: G Fernandes (was: Sanne Grinovero) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-503?pag... ] Emmanuel Bernard commented on HSEARCH-503: ------------------------------------------ I did not do the first step (ie mvn -o clean archetype:create-from-project in the archetype directory). what I did was mvn install it as I expected it to actually install the archetype and prepare it for use. silly me :) So we have to manually run the first step when releasing a new version of HSearch? If we do it, a user just have to do mvn -o archetype:generate -DarchetypeGroupId=org.hibernate -DarchetypeArtifactId=hibernate-search-quickstart -DarchetypeVersion=3.2.0-SNAPSHOT -DgroupId=my.company -DartifactId=quickstart -Dversion=1.0-SNAPSHOT from an empty directory? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-503?pag... ] Hardy Ferentschik commented on HSEARCH-503: ------------------------------------------- Seems like a bug in 'archetype:create-from-project'. When filtering the java files it wrongly replaces org.hibernate.search with ${groupId), where the variable is the group id specified during the archetype generate phase. It think that it is a bug within the archetype plugin which causes the problem. I updated the archetype and the process described in this issue works now, however I had to set the groupId in the pom to {{com.example}}. Given that for now we are not able to update/deploy the archetype catalog on the new maven repo (see comment on [Maven Getting Started - Developers|Maven Getting Started - Developers]), we should just skip the deployment of the archetype for 3.2. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-503?pag... ] Hardy Ferentschik commented on HSEARCH-503: ------------------------------------------- The changes I made included a move of the java classes into com.example. I also moved _archetype.properties_ out of the source directory since otherwise it was included into the artifact. In fact the following sequence of commands (as described in [Contributing in Hibernate Search|http://community.jboss.org/wiki/ContributingtoHibernateSearch]) works now: {code} # archetype creation # archetype usage against local catalog {code} However, I also had to set the groupId in the pom to _com.example_. Leaving the groupId as _org.hibernate_ screwed up the import statements in the archetype. What happens is that all in all import statements _org.hibernate_ gets replaced with whatever you specify during _archetype:generate_. The problem with _com.example_ is that the artifact gets deployed at the wrong spot in the repo. On top of this it is at the moment not clear what happens with the archetype catalog. How and if it gets maintained on the new Jboss Maven repo. I added a comment regarding this issue [here|http://community.jboss.org/wiki/MavenGettingStarted-Developers]. Last but not least, I am getting more and more frustrated with the archetype plugin. Really the archetype needs its own packaging type. Right now I need a two step process to get the achetype deployed. I can not have an aggregator project where one module is the archetype which gets automatically deployed (as artifact!) when calling 'mvn install' or 'mvn deploy'. Currently there is always this additional step of 'mvn archetype:create-from-project; cd target/generated-sources/archetype; mvn install' From a release perspective this is a pita. I'll resolve the issue, since the dot(.) problem is kind of resolved. We can visit the archetype generation/deployment at a later point in time. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-503?pag... ] Hardy Ferentschik updated HSEARCH-503: -------------------------------------- Summary: Generated archetype broken for any package name with dot (.) (was: Generated archetype broken for any package name with dot (.) (Gustavo Fernandes)) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira