[Hibernate-JIRA] Created: (HBX-1009) @JoinColumn on association with composite foreign key needs referencedColumnName
9:27 p.m.
@JoinColumn on association with composite foreign key needs referencedColumnName
--------------------------------------------------------------------------------
Key: HBX-1009
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Its not ok to generate this:
@JoinColumns( { @JoinColumn(name = "make"), @JoinColumn(name =
"model"),
@JoinColumn(name = "year") })
You need the referencedColumnNames.
Incidently, is all this noisy crap really necessary?
@EmbeddedId
@AttributeOverrides( {
@AttributeOverride(name = "make", column = @Column(name = "make",
nullable = false, length = 20)),
@AttributeOverride(name = "model", column = @Column(name = "model",
nullable = false, length = 30)),
@AttributeOverride(name = "year", column = @Column(name = "year",
nullable = false)) })
@NotNull
public ModelYearId getId() {
return this.id;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:16 a.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1009) @JoinColumn on association with composite foreign key needs referencedColumnName
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009?page=c...
]
Max Rydahl Andersen commented on HBX-1009:
------------------------------------------
what is the input that generates this ?
@JoinColumn on association with composite foreign key needs
referencedColumnName
--------------------------------------------------------------------------------
Key: HBX-1009
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Its not ok to generate this:
@JoinColumns( { @JoinColumn(name = "make"), @JoinColumn(name =
"model"),
@JoinColumn(name = "year") })
You need the referencedColumnNames.
Incidently, is all this noisy crap really necessary?
@EmbeddedId
@AttributeOverrides( {
@AttributeOverride(name = "make", column = @Column(name = "make",
nullable = false, length = 20)),
@AttributeOverride(name = "model", column = @Column(name =
"model", nullable = false, length = 30)),
@AttributeOverride(name = "year", column = @Column(name = "year",
nullable = false)) })
@NotNull
public ModelYearId getId() {
return this.id;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:40 a.m.
New subject: [Hibernate-JIRA] Updated: (HBX-1009) @JoinColumn on association with composite foreign key needs referencedColumnName
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009?page=c...
]
Gavin King updated HBX-1009:
----------------------------
Attachment: test-schema.txt
Here it is.
@JoinColumn on association with composite foreign key needs
referencedColumnName
--------------------------------------------------------------------------------
Key: HBX-1009
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Attachments: test-schema.txt
Its not ok to generate this:
@JoinColumns( { @JoinColumn(name = "make"), @JoinColumn(name =
"model"),
@JoinColumn(name = "year") })
You need the referencedColumnNames.
Incidently, is all this noisy crap really necessary?
@EmbeddedId
@AttributeOverrides( {
@AttributeOverride(name = "make", column = @Column(name = "make",
nullable = false, length = 20)),
@AttributeOverride(name = "model", column = @Column(name =
"model", nullable = false, length = 30)),
@AttributeOverride(name = "year", column = @Column(name = "year",
nullable = false)) })
@NotNull
public ModelYearId getId() {
return this.id;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:53 a.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1009) @JoinColumn on association with composite foreign key needs referencedColumnName
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009?page=c...
]
Max Rydahl Andersen commented on HBX-1009:
------------------------------------------
So I don't get any deploy errors when using this schema.......
What I do get is thought that associations that points to non-primary-key associations are
broken - never been done completely for the code generation.
Is that the error you are talking about ? This is not going to be an easy fix.
As long as the foreeignkey points to the primary key and the column order is the same this
does work though AFAICS
@JoinColumn on association with composite foreign key needs
referencedColumnName
--------------------------------------------------------------------------------
Key: HBX-1009
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Attachments: test-schema.txt
Its not ok to generate this:
@JoinColumns( { @JoinColumn(name = "make"), @JoinColumn(name =
"model"),
@JoinColumn(name = "year") })
You need the referencedColumnNames.
Incidently, is all this noisy crap really necessary?
@EmbeddedId
@AttributeOverrides( {
@AttributeOverride(name = "make", column = @Column(name = "make",
nullable = false, length = 20)),
@AttributeOverride(name = "model", column = @Column(name =
"model", nullable = false, length = 30)),
@AttributeOverride(name = "year", column = @Column(name = "year",
nullable = false)) })
@NotNull
public ModelYearId getId() {
return this.id;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:55 a.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1009) @JoinColumn on association with composite foreign key needs referencedColumnName
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009?page=c...
]
Max Rydahl Andersen commented on HBX-1009:
------------------------------------------
note: I can see in the spec that referenceColumnName is required .... but hibernate at
least doesn't fail on it.
@JoinColumn on association with composite foreign key needs
referencedColumnName
--------------------------------------------------------------------------------
Key: HBX-1009
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Attachments: test-schema.txt
Its not ok to generate this:
@JoinColumns( { @JoinColumn(name = "make"), @JoinColumn(name =
"model"),
@JoinColumn(name = "year") })
You need the referencedColumnNames.
Incidently, is all this noisy crap really necessary?
@EmbeddedId
@AttributeOverrides( {
@AttributeOverride(name = "make", column = @Column(name = "make",
nullable = false, length = 20)),
@AttributeOverride(name = "model", column = @Column(name =
"model", nullable = false, length = 30)),
@AttributeOverride(name = "year", column = @Column(name = "year",
nullable = false)) })
@NotNull
public ModelYearId getId() {
return this.id;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:10 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1009) @JoinColumn on association with composite foreign key needs referencedColumnName
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009?page=c...
]
Gavin King commented on HBX-1009:
---------------------------------
You must have just got lucky. For me, Hibernate takes a guess (based upon the column
order) and gets it wrong. Tries to join "make" with "year".
@JoinColumn on association with composite foreign key needs
referencedColumnName
--------------------------------------------------------------------------------
Key: HBX-1009
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Attachments: test-schema.txt
Its not ok to generate this:
@JoinColumns( { @JoinColumn(name = "make"), @JoinColumn(name =
"model"),
@JoinColumn(name = "year") })
You need the referencedColumnNames.
Incidently, is all this noisy crap really necessary?
@EmbeddedId
@AttributeOverrides( {
@AttributeOverride(name = "make", column = @Column(name = "make",
nullable = false, length = 20)),
@AttributeOverride(name = "model", column = @Column(name =
"model", nullable = false, length = 30)),
@AttributeOverride(name = "year", column = @Column(name = "year",
nullable = false)) })
@NotNull
public ModelYearId getId() {
return this.id;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:11 a.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1009) @JoinColumn on association with composite foreign key needs referencedColumnName
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009?page=c...
]
Emmanuel Bernard commented on HBX-1009:
---------------------------------------
Are you using Hibernate Annotations 3.2.1?
It might be due to http://opensource.atlassian.com/projects/hibernate/browse/ANN-551
but year referencedColumnName are better being expressed.
@JoinColumn on association with composite foreign key needs
referencedColumnName
--------------------------------------------------------------------------------
Key: HBX-1009
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Attachments: test-schema.txt
Its not ok to generate this:
@JoinColumns( { @JoinColumn(name = "make"), @JoinColumn(name =
"model"),
@JoinColumn(name = "year") })
You need the referencedColumnNames.
Incidently, is all this noisy crap really necessary?
@EmbeddedId
@AttributeOverrides( {
@AttributeOverride(name = "make", column = @Column(name = "make",
nullable = false, length = 20)),
@AttributeOverride(name = "model", column = @Column(name =
"model", nullable = false, length = 30)),
@AttributeOverride(name = "year", column = @Column(name = "year",
nullable = false)) })
@NotNull
public ModelYearId getId() {
return this.id;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:31 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1009) @JoinColumn on association with composite foreign key needs referencedColumnName
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009?page=c...
]
Max Rydahl Andersen commented on HBX-1009:
------------------------------------------
i added the referencedcolumnname for the places where I can currently easily identify them
(joins to PK)
And we are using whatever is in JBoss EAP :)
@JoinColumn on association with composite foreign key needs
referencedColumnName
--------------------------------------------------------------------------------
Key: HBX-1009
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Attachments: test-schema.txt
Its not ok to generate this:
@JoinColumns( { @JoinColumn(name = "make"), @JoinColumn(name =
"model"),
@JoinColumn(name = "year") })
You need the referencedColumnNames.
Incidently, is all this noisy crap really necessary?
@EmbeddedId
@AttributeOverrides( {
@AttributeOverride(name = "make", column = @Column(name = "make",
nullable = false, length = 20)),
@AttributeOverride(name = "model", column = @Column(name =
"model", nullable = false, length = 30)),
@AttributeOverride(name = "year", column = @Column(name = "year",
nullable = false)) })
@NotNull
public ModelYearId getId() {
return this.id;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:10 p.m.
New subject: [Hibernate-JIRA] Closed: (HBX-1009) @JoinColumn on association with composite foreign key needs referencedColumnName
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009?page=c...
]
Max Rydahl Andersen closed HBX-1009.
------------------------------------
Resolution: Fixed
Fix Version/s: 3.2.beta12
this is now fixed for all multi-column assocations; assuming they point to the primary
key.
@JoinColumn on association with composite foreign key needs
referencedColumnName
--------------------------------------------------------------------------------
Key: HBX-1009
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1009
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Fix For: 3.2.beta12
Attachments: test-schema.txt
Its not ok to generate this:
@JoinColumns( { @JoinColumn(name = "make"), @JoinColumn(name =
"model"),
@JoinColumn(name = "year") })
You need the referencedColumnNames.
Incidently, is all this noisy crap really necessary?
@EmbeddedId
@AttributeOverrides( {
@AttributeOverride(name = "make", column = @Column(name = "make",
nullable = false, length = 20)),
@AttributeOverride(name = "model", column = @Column(name =
"model", nullable = false, length = 30)),
@AttributeOverride(name = "year", column = @Column(name = "year",
nullable = false)) })
@NotNull
public ModelYearId getId() {
return this.id;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6215
days inactive
6222
days old
hibernate-issues@lists.jboss.org
8 comments
3 participants
participants (3)
-
Emmanuel Bernard (JIRA) -
Gavin King (JIRA)
-
Max Rydahl Andersen (JIRA)