Yoann Rodière (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%...
) *created* an issue
Hibernate Search (
https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiODQ2ZTJl...
) / Task (
https://hibernate.atlassian.net/browse/HSEARCH-4889?atlOrigin=eyJpIjoiODQ...
) HSEARCH-4889 (
https://hibernate.atlassian.net/browse/HSEARCH-4889?atlOrigin=eyJpIjoiODQ...
) Forbid usage of internal/incubating Hibernate ORM code (API/SPI/...) (
https://hibernate.atlassian.net/browse/HSEARCH-4889?atlOrigin=eyJpIjoiODQ...
)
Issue Type: Task Assignee: Unassigned Components: build Created: 03/Jul/2023 00:06 AM Fix
Versions: 7.0-backlog Priority: Major Reporter: Yoann Rodière (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%...
)
See
https://hibernate.zulipchat.com/#narrow/stream/132084-redhat-specific/top...
, such code is not safe to use if we want to preserve compatibility across more than one
ORM version.
ORM annotates packages/classes/methods with custom annotations to warn about
incupating/internal/deprecated methods. Unfortunately
We could probably take advantage of JQAssistant to forbid usage of such code, like we
already do for implementation leaks inside Hibernate Search APIs. Getting method/field
granularity might be annoying, though.
Alternatively, we might be able to feed reports generated by Hibernate ORM to
forbiddenapis:
*
https://docs.jboss.org/hibernate/orm/6.2/deprecated/deprecating.txt
*
https://docs.jboss.org/hibernate/orm/6.2/incubating/incubating.txt
*
https://docs.jboss.org/hibernate/orm/6.2/internals/internal.txt
I’m not sure the format is compatible though; the type of method parameters seems to be
missing, and I believe forbiddenapis requires that. I may be wrong though; we need to
check.
(
https://hibernate.atlassian.net/browse/HSEARCH-4889#add-comment?atlOrigin...
) Add Comment (
https://hibernate.atlassian.net/browse/HSEARCH-4889#add-comment?atlOrigin...
)
Get Jira notifications on your phone! Download the Jira Cloud app for Android (
https://play.google.com/store/apps/details?id=com.atlassian.android.jira....
) or iOS (
https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em...
) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )