9:42 a.m.
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.1, 4.0.0.Final, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Attachments: testcase-connectionleak.zip
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the JUnit
test)
I have tried different ways to work around the problem. The only way it worked is to use a
simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:24 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Zoltán Holub updated HHH-7020:
------------------------------
Attachment: HHH-7020.diff
I've made a patch for this issue.
The org/hibernate/engine/jdbc/internal/JdbcResourceRegistryImpl.java class contains some
old commented out code, where exceptions are handled correctly.
I introduced the same exception handling in the new code, and it seems it fixed the
problem.
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Attachments: HHH-7020.diff, testcase-connectionleak.zip
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:09 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Shawn Clowater commented on HHH-7020:
-------------------------------------
I've also spent the day at this and had found this other user first
https://forum.hibernate.org/viewtopic.php?f=1&t=1014673&p=2453265...
Coles notes, it appears that the register(Statement statement)() on the
JdbcResourceRegistry gets called at multiple levels and builds up it's own xref map
and puts in the same underlying instance of the statement. When the secondary session is
closed (or the statement for that matter) the Wrapper is invalidated across all xref maps
(same instance) but removed only from the one Registry that actually executed it.
The other xref maps get processed when the transaction commits and then blows the
"proxy handle is no longer valid" exception and prevents the connection
release.
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Attachments: HHH-7020.diff, testcase-connectionleak.zip
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:04 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Shawn Clowater updated HHH-7020:
--------------------------------
Attachment: HHH-7020Debug.png
This illustrates the nested LogicalConnection issue. I thought it was purely a proxy
thing but I think I finally have it sorted in my head.
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Attachments: HHH-7020Debug.png, HHH-7020.diff, testcase-connectionleak.zip
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:14 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Shawn Clowater commented on HHH-7020:
-------------------------------------
The first session is opened without a connection and ends up with the logical connection @
1640 and the ResourceRegistry @ 1644
When the connection() method is called for the second session it creates another
LogicalConnectionImpl when it builds the JdbcCoordinatorImpl when creating the
TransactionCoordinatorImpl. However, we now have nested the LogicalConnectionImpl of the
first session as the PhysicalConnection of the second session's LogicalConnectionImpl
@ 1702 with it's own ResourceRegistry @ 1708
When the PreparedStatment registers itself when it is prepared it actually calls down
through both LogicalConnectionImpls and registers with both ResourceRegistries, when it is
released it only gets removed from the second session's ResourceRegistry but is left
in an invalid state in the first session's registry.
When the first session tries to close then it hits the invalid registered resource and
then blows itself out. I'll attach a unit test that shows that the first session has
registered resources but doesn't actually execute any statements of its own.
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Attachments: HHH-7020Debug.png, HHH-7020.diff, testcase-connectionleak.zip
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:22 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Shawn Clowater updated HHH-7020:
--------------------------------
Attachment: HHH-7020-TestCaseNoSpring.zip
Testcase built using hibernate functional test case on master branch
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Attachments: HHH-7020Debug.png, HHH-7020.diff, HHH-7020-TestCaseNoSpring.zip,
testcase-connectionleak.zip
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:08 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Steve Ebersole updated HHH-7020:
--------------------------------
Assignee: Steve Ebersole
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Assignee: Steve Ebersole
Attachments: HHH-7020Debug.png, HHH-7020.diff, HHH-7020-TestCaseNoSpring.zip,
testcase-connectionleak.zip
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:30 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Steve Ebersole commented on HHH-7020:
-------------------------------------
Zoltan, your patch may be the correct approach although I tend to think that sharing the
connection *proxy* from the primary Session is more the cause and these problems are just
symptoms. Going to dig a little deeper.
Shawn, thanks for the test case. I will say that I am not so certain that your assertions
regarding the {{JdbcResourceRegsitry}} are valid. I agree that they should work given the
current state of the code. But if I move to actually sharing the {{LogicalConnection}}
the 2 will also share {{JdbcResourceRegsitry}} (since that is held and maintained by the
{{LogicalConnection}}), then they will most certainly fail. But logically that is ok I
think since it is still the same {{LogicalConnection}} we are talking about for both
Sessions
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Assignee: Steve Ebersole
Attachments: HHH-7020Debug.png, HHH-7020.diff, HHH-7020-TestCaseNoSpring.zip,
testcase-connectionleak.zip
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:18 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Steve Ebersole commented on HHH-7020:
-------------------------------------
Thinking about this some more, not so sure that this split in notion of sharing Connection
and sharing "transaction conext" makes sense. Sharing the connection without
sharing the associated transaction context is a recipe for failure as I sit back and think
about it now.
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Assignee: Steve Ebersole
Attachments: HHH-7020Debug.png, HHH-7020.diff, HHH-7020-TestCaseNoSpring.zip,
testcase-connectionleak.zip
Time Spent: 1.1h
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:24 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Shawn Clowater commented on HHH-7020:
-------------------------------------
Steve, I think if it were the same JdbcResourceRegistry then the test would actually pass
since when the second session finishes executing the statement it would invalidate and
remove it from the shared resource registry so the first session would no longer have any
registered resources and would be able to close.
I think handling the close so that it doesn't fail the connection release is probably
worthwhile nonetheless.
I'm not sure you can share the same LogicalConnection if you aren't sharing the
TransactionContext can you? i.e. if the 2nd session were to start a nested transaction
and commit it, then it calls cleanup on the JdbcResourceRegistry which would clear
anything that the first session might have registered.
I think you're ok as long as when you build the second session you unwrap the proxy
before it's passed as the user supplied connection. (or why not the physical
connection?)
You'll actually run into this same sort of issue (i think) anytime a proxied
LogicalConnectionImpl is passed into another one since to do something like call
prepareStatment() goes through the proxy and registers the resource at the multiple
levels.
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Assignee: Steve Ebersole
Attachments: HHH-7020Debug.png, HHH-7020.diff, HHH-7020-TestCaseNoSpring.zip,
testcase-connectionleak.zip
Time Spent: 1.1h
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:14 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Steve Ebersole commented on HHH-7020:
-------------------------------------
Shawn, I think you might be confusing the notion of the connection proxy that is currently
used in the secondary session and a logical connection.
As far as sharing the {{LogicalConnection}} (which is not done today) while not sharing
the {{TransactionCoordinator}} ({{transactionContext()}} actually shares the
{{TransactionCoordinator}}), I just said I dont think that will work. My point being that
if we change {{SharedSessionBuilder#connection()}} to share the {{LogicalConnection}}:
# It probably really needs to share the {{TransactionCoordinator}} with various
protections, as we discussed on IRC
# It probably means consolidating the semantics of {{SharedSessionBuilder#connection()}}
and {{SharedSessionBuilder#transactionContext()}} such that they really do the same
thing.
And you can't pass the physical connection because you will get into connection
release issues.
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Assignee: Steve Ebersole
Attachments: HHH-7020Debug.png, HHH-7020.diff, HHH-7020-TestCaseNoSpring.zip,
testcase-connectionleak.zip
Time Spent: 1.1h
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:40 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Steve Ebersole commented on HHH-7020:
-------------------------------------
One of the main issue here is going to be the current tight coupling between
{{TransactionCoordinator}} and {{JdbcCoordinator}}. I think each session needs to have
its own {{JdbcCoordinator}} (which is the thing that tracks batch statements, etc) while
still sharing both the {{LogicalConnection}} and {{TransactionCoordinator}}. Currently
though there is a bi-directional coupling between {{TransactionCoordinator}} and
{{JdbcCoordinator}}. I'll have to work on de-coupling them.
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Assignee: Steve Ebersole
Attachments: HHH-7020Debug.png, HHH-7020.diff, HHH-7020-TestCaseNoSpring.zip,
testcase-connectionleak.zip
Time Spent: 1.1h
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:49 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Zoltán Holub commented on HHH-7020:
-----------------------------------
A connection leak shouldn't occur if some non-critical internal error happens. My
patch solves this issue. If you fix the original problem, you still have to ensure that
other soft errors in jdbc resource handling won't cause a connection leak.
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Assignee: Steve Ebersole
Attachments: HHH-7020Debug.png, HHH-7020.diff, HHH-7020-TestCaseNoSpring.zip,
testcase-connectionleak.zip
Time Spent: 1.1h
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:19 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Steve Ebersole commented on HHH-7020:
-------------------------------------
Sure. But I'd obviously rather fix the underlying issue here before your fix obscures
it...
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Assignee: Steve Ebersole
Attachments: HHH-7020Debug.png, HHH-7020.diff, HHH-7020-TestCaseNoSpring.zip,
testcase-connectionleak.zip
Time Spent: 1.1h
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:10 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-7020) Connection leak with nested sessions
[
https://hibernate.onjira.com/browse/HHH-7020?page=com.atlassian.jira.plug...
]
Steve Ebersole resolved HHH-7020.
---------------------------------
Resolution: Fixed
Fix Version/s: 4.1.2
Connection leak with nested sessions
------------------------------------
Key: HHH-7020
URL: https://hibernate.onjira.com/browse/HHH-7020
Project: Hibernate ORM
Issue Type: Bug
Components: core, entity-manager
Affects Versions: 4.0.0.Final, 4.0.1, 4.1.0
Environment: Windows 7.
Java 1.6.0_25, Java 1.7.0
Reporter: Zoltán Holub
Assignee: Steve Ebersole
Fix For: 4.1.2
Attachments: HHH-7020Debug.png, HHH-7020.diff, HHH-7020-TestCaseNoSpring.zip,
testcase-connectionleak.zip
Time Spent: 13.2h
I'am using a Hibernate interceptor to track data modifications. In the
interceptor's onFlushDirty() method, i open a new session without interceptors using
the same JDBC connection.
After closing this nested session and the original entitymanager, the JDBC connection
doesn't released.
I could reproduce this problem outside any interceptor. I have made a junit test without
interceptors which shows the same problem.
I have found that Hibernate throws and catches a HibernateException with message
"proxy handle is no longer valid". This exception is logged on debug level.
I investigated that the problem is in the following code:
LogicalConnectionImpl.java
public Connection close() {
LOG.trace( "Closing logical connection" );
Connection c = isUserSuppliedConnection ? physicalConnection : null;
try {
releaseProxies();
jdbcResourceRegistry.close();
if ( !isUserSuppliedConnection && physicalConnection != null ) {
releaseConnection();
}
return c;
}
finally {
// no matter what
physicalConnection = null;
isClosed = true;
LOG.trace( "Logical connection closed" );
for ( ConnectionObserver observer : observers ) {
observer.logicalConnectionClosed();
}
observers.clear();
}
}
The invocation of jdbcResourceRegistry.close() throws this exception, and this is why it
skips the following releaseConnection(). The condition of IF statement is true.
This code is new to Hibernate 4. I have tried 4.0.0, 4.0.1 and 4.1.0-SNAPSHOT and all of
them has the problem. Hibernate 3.6.0 is not affected.
My JUnit test could run with Hibernate 3.x with minor changes. (3.x code also in the
JUnit test)
I have tried different ways to work around the problem. The only way it worked is to use
a simple doWork() and native JDBC operations. This test case also in the unit test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4582
days inactive
4628
days old
hibernate-issues@lists.jboss.org
14 comments
3 participants
participants (3)
-
Shawn Clowater (JIRA) -
Steve Ebersole (JIRA)
-
Zoltán Holub (JIRA)