November 2022 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-15683) Query.setLockOptions() ignores some of the options, apparently by design

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZTI0NWI5NDYy... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15683?atlOrigin=eyJpIjoiZTI0NW... ) HHH-15683 ( https://hibernate.atlassian.net/browse/HHH-15683?atlOrigin=eyJpIjoiZTI0NW... ) Query.setLockOptions() ignores some of the options, apparently by design ( https://hibernate.atlassian.net/browse/HHH-15683?atlOrigin=eyJpIjoiZTI0NW... ) Change By: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) So look, frankly it smells a bit that {{LockOptions}} has {{aliasSpecificLockModes}} that only apply to queries, and not to {{get()}}, {{refresh()}} or {{lock()}}. But now I see that when you call {{Query.setLockOptions()}}, these {{aliasSpecificLockModes}} are actually ignored and not copied over, making them almost useless. And this is actually the _documented behavior_, so I can’t even call it a bug. This is frankly a bit crazy, and either: * {{Query.setLockOptions()}} should respect all the options in its argument, or * We we should remove {{aliasSpecificLockModes}} from {{LockOptions}}. Both of those would be in principle a backward-incompatible change, but the first looks pretty innocuous to me. ( https://hibernate.atlassian.net/browse/HHH-15683#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15683#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4f8bc0d )

2 years

1
0
0 / 0

[JIRA] (HHH-15683) Query.setLockOptions() ignores some of the options, apparently by design

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYzZiNDM1OGM1... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15683?atlOrigin=eyJpIjoiYzZiND... ) HHH-15683 ( https://hibernate.atlassian.net/browse/HHH-15683?atlOrigin=eyJpIjoiYzZiND... ) Query.setLockOptions() ignores some of the options, apparently by design ( https://hibernate.atlassian.net/browse/HHH-15683?atlOrigin=eyJpIjoiYzZiND... ) Issue Type: Improvement Assignee: Unassigned Created: 07/Nov/2022 02:09 AM Priority: Major Reporter: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) So look, frankly it smells a bit that LockOptions has aliasSpecificLockModes that only apply to queries, and not to get() , refresh() or lock(). But now I see that when you call Query.setLockOptions() , these aliasSpecificLockModes are actually ignored and not copied over, making them almost useless. And this is actually the documented behavior , so I can’t even call it a bug. This is frankly a bit crazy, and either: * Query.setLockOptions() should respect all the options in its argument, or * We should remove aliasSpecificLockModes from LockOptions. Both of those would be in principle a backward-incompatible change, but the first looks pretty innocuous to me. ( https://hibernate.atlassian.net/browse/HHH-15683#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15683#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4f8bc0d )

2 years

1
0
0 / 0

[JIRA] (HHH-15682) static final instances of LockOptions are mutable

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15682 ( https://hibernate.atlassian.net/browse/HHH-15682?atlOrigin=eyJpIjoiNmJhYz... ) Re: static final instances of LockOptions are mutable ( https://hibernate.atlassian.net/browse/HHH-15682?atlOrigin=eyJpIjoiNmJhYz... ) Sanne what I did was make an ImmutableLockOptions class that extends and overrides the setters. This is OK, but IntelliJ complains that: > > > > Referencing subclass ImmutableLockOptions from superclass LockOptions > initializer might lead to class loading deadlock > > Not sure if that’s a real problem I should be worried about. ( https://hibernate.atlassian.net/browse/HHH-15682#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15682#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4f8bc0d )

2 years

1
0
0 / 0

[JIRA] (HHH-15682) static final instances of LockOptions are mutable

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15682 ( https://hibernate.atlassian.net/browse/HHH-15682?atlOrigin=eyJpIjoiMzMzMD... ) Re: static final instances of LockOptions are mutable ( https://hibernate.atlassian.net/browse/HHH-15682?atlOrigin=eyJpIjoiMzMzMD... ) Thanks, yes we should fix that. One thing to keep in mind though: we have significant issues with too many LockOption instances being allocated, AFAIK that’s why the common cases have been made constant - let’s be mindful of that as well if possible. ( https://hibernate.atlassian.net/browse/HHH-15682#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15682#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4f8bc0d )

2 years

1
0
0 / 0

[JIRA] (HHH-15682) static final instances of LockOptions are mutable

by Gavin King (JIRA)

2 years

1
0
0 / 0

[JIRA] (HHH-15608) Error In Native Query where column is mapped twice

by Andrea Boriero (JIRA)

2 years

1
0
0 / 0

[JIRA] (HHH-15682) static final instances of LockOptions are mutable

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMjZhZGZkMzhj... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15682?atlOrigin=eyJpIjoiMjZhZG... ) HHH-15682 ( https://hibernate.atlassian.net/browse/HHH-15682?atlOrigin=eyJpIjoiMjZhZG... ) static final instances of LockOptions are mutable ( https://hibernate.atlassian.net/browse/HHH-15682?atlOrigin=eyJpIjoiMjZhZG... ) Issue Type: Bug Assignee: Unassigned Created: 07/Nov/2022 01:49 AM Priority: Major Reporter: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) LockOptions defines three convenient “constant” instances. But they’re mutable objects, and so one piece of code could accidentally call a setter on one of them, and break unrelated code. This is really bad. ( https://hibernate.atlassian.net/browse/HHH-15682#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15682#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4f8bc0d )

2 years

1
0
0 / 0

[JIRA] (HHH-15681) LockOptions.scope should be a PessimisticLockScope, not boolean

by Gavin King (JIRA)

2 years

1
0
0 / 0

[JIRA] (HHH-15681) LockOptions.scope should be a PessimisticLockScope, not boolean

by Gavin King (JIRA)

2 years

1
0
0 / 0

[JIRA] (HHH-15680) deprecate LockRequest and buildLockRequest(), and have lock() accept LockOptions

by Gavin King (JIRA)

2 years

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues November 2022