4:25 a.m.
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records returned
( at the database level, via generated SQL, not in memory) we were getting an exception
due to the query builder trying to attach a parameter to the prepared statement that was
out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
5:05 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Max Rydahl Andersen commented on HHH-2207:
------------------------------------------
submit a patch then we can see it...
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
5:09 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Toby Moore commented on HHH-2207:
---------------------------------
Ok will do, thanks for your reply.
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
5:11 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Max Rydahl Andersen commented on HHH-2207:
------------------------------------------
...and even more important a failing testcase!
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6:32 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=all ]
Toby Moore updated HHH-2207:
----------------------------
Attachment: querloaderdiff.patch
Here's a patch to the source file causing the issue.
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6:41 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Max Rydahl Andersen commented on HHH-2207:
------------------------------------------
you got a test too ?
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6:53 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Toby Moore commented on HHH-2207:
---------------------------------
I'm not sure how to go about creating a test case for this as the method is in a chain
of other methods to convert the HQL to the prepared statement sql, and we only have scope
to test it on our MySql implementation. If you look at the only method that calls the one
I've changed, it's clear to see that it's expecting the parameter count added,
not the new position. Any other questions please ask.
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
7:10 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Max Rydahl Andersen commented on HHH-2207:
------------------------------------------
you just need to give us the minimal mapping and the hibernate code you actually call to
make this error occur.
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
7:21 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Steve Ebersole commented on HHH-2207:
-------------------------------------
Should be even easier than that. Have a look at
org.hibernate.test.hql.ASTParserLoadingTest. Based on your description you should be able
to add a new test method there using those mappnings.
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
7:26 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Toby Moore commented on HHH-2207:
---------------------------------
ok cheers guys, i'll take a look at that after lunch
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
8:11 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Max Rydahl Andersen commented on HHH-2207:
------------------------------------------
whoops - wrong case ;) forget my last comment
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
8:52 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=all ]
Steve Ebersole updated HHH-2207:
--------------------------------
Comment: was deleted
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
8:52 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=all ]
Steve Ebersole updated HHH-2207:
--------------------------------
Comment: was deleted
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
10:16 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Toby Moore commented on HHH-2207:
---------------------------------
Sorry guys I've been having eclipse related nightmares this afternoon, so haven't
been able to put a test case together, however I can give you the very simple mapping and
hql I use. I map using EJB3 annotations, so no mapping files, but there's nothing
special about Itmm.
Query query = entityManager.createQuery("select itmm from Itmm as itmm where
itmm.itmmId < ? order by itmm.itmmId asc");
query.setParameter(1, new Long(1000));
query.setFirstResult(2);
query.setMaxResults(5);
Iterator<Itmm> itmmsIterator = query.getResultList().iterator();
this gives me the exception SQL
Hibernate: select itmm0_.itmm_id as itmm1_3_, itmm0_.itmm_value as itmm2_3_,
itmm0_.itmm_creator as itmm8_3_, itmm0_.itmm_updator as itmm10_3_, itmm0_.itmm_itmv_id as
itmm9_3_, itmm0_.itmm_itmi_id as itmm11_3_, itmm0_.itmm_name as itmm3_3_,
itmm0_.itmm_order as itmm4_3_, itmm0_.itmm_created as itmm5_3_, itmm0_.itmm_updated as
itmm6_3_, itmm0_.itmm_searchable as itmm7_3_ from mcd_data.itmm itmm0_ where
itmm0_.itmm_id<? order by itmm0_.itmm_id asc limit ?, ?
and exception :
Exception in thread "main" javax.persistence.PersistenceException:
org.hibernate.exception.GenericJDBCException: could not execute query
at
org.hibernate.ejb.AbstractEntityManagerImpl.throwPersistenceException(AbstractEntityManagerImpl.java:647)
at org.hibernate.ejb.QueryImpl.getResultList(QueryImpl.java:73)
at com.mindcandydesign.persistence.daohomes.ItmmHome.findAllItmms(ItmmHome.java:209)
at com.mindcandydesign.persistence.daohomes.ItmmHome.main(ItmmHome.java:225)
Caused by: org.hibernate.exception.GenericJDBCException: could not execute query
at
org.hibernate.exception.SQLStateConverter.handledNonSpecificException(SQLStateConverter.java:103)
at org.hibernate.exception.SQLStateConverter.convert(SQLStateConverter.java:91)
at org.hibernate.exception.JDBCExceptionHelper.convert(JDBCExceptionHelper.java:43)
at org.hibernate.loader.Loader.doList(Loader.java:2155)
at org.hibernate.loader.Loader.listIgnoreQueryCache(Loader.java:2036)
at org.hibernate.loader.Loader.list(Loader.java:2031)
at org.hibernate.loader.hql.QueryLoader.list(QueryLoader.java:398)
at org.hibernate.hql.ast.QueryTranslatorImpl.list(QueryTranslatorImpl.java:338)
at org.hibernate.engine.query.HQLQueryPlan.performList(HQLQueryPlan.java:172)
at org.hibernate.impl.SessionImpl.list(SessionImpl.java:1121)
at org.hibernate.impl.QueryImpl.list(QueryImpl.java:79)
at org.hibernate.ejb.QueryImpl.getResultList(QueryImpl.java:64)
... 2 more
Caused by: java.sql.SQLException: Parameter index out of range (4 > number of
parameters, which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1615)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1559)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2152)
... 10 more
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6:35 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Toby Moore commented on HHH-2207:
---------------------------------
I've been trying all morning to get a build of the code for the HibernateExt package
running, but it's a complete mess and doesn't compile or test. I got the code
compiling, but then all the Junit references are broken and i'm not wasting any more
time trying to get it to run properly.
Here's a simple test case that should reproduce the bug i've found.
public void testSimpleQueryBreaksPrepStatement()
{
EntityManager em = factory.createEntityManager();
em.getTransaction.begin();
Query query = em.createQuery("select item from Item item");
query.setFirstResult(1);
query.setMaxResult(10);
List<Item> = query.getResultsList();
em.getTransaction.commit();
em.close();
}
I can't test it because I can't get the package to build and test properly, but if
you need anymore info please let me know. I'm trying to help you here, if you were to
just take a look at the code i've mentioned before you'll see it's a clear
bug.
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6:41 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Max Rydahl Andersen commented on HHH-2207:
------------------------------------------
What does HibernateExt have to do with this ?
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
7:19 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Toby Moore commented on HHH-2207:
---------------------------------
I was trying to create a test case in that package, to better replicate my error.
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
7:36 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Max Rydahl Andersen commented on HHH-2207:
------------------------------------------
? your problem is in hibernate core, not hibernate ext (tools, annotations, etc.)
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
9:09 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Emmanuel Bernard commented on HHH-2207:
---------------------------------------
AFA HibernateExt/HEM is concerned
checkout Hibernate3
checkout HibernateExt
cd ./Hibernate3
ant clean jar prepare-dir-up
** optionally
cd ../HibernateExt/metadata
ant clean jar
cp ./target/hibernate-annotations/hibernate-annotations.jar ../ejb/lib
cd ../..
** end of optionally
cd ./HibernateExt/ejb
ant clean junit
I need to put that somewhere on the wiki
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
9:11 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Toby Moore commented on HHH-2207:
---------------------------------
ok
here's a test case
public void testSimpleSelectWithLimit() throws Exception
{
createTestBaseData();
Session session = openSession();
Query query = session.createQuery( "select a from Animal as a" );
query.setFirstResult(2);
query.setMaxResults(1);
List results = query.list();
session.close();
destroyTestBaseData();
}
for ASTParserLoadingTest.
if you use this with a mysql database, you should see a reproduction of the problem.
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
5:35 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Alejandro Revilla commented on HHH-2207:
----------------------------------------
Happens to us with simple code like this:
Criteria crit = session.createCriteria (ASimpleEntity.class);
crit.setMaxResults(1);
crit.list();
For the records, we´ve tried with a simple hbm.xml like this:
<hibernate-mapping package="org.jpos.ee">
<class name="SysConfig" table="sysconfig">
<id name="id" column="id" type="string"
length="64">
<generator class="assigned" />
</id>
<property name="value" type="text" />
<property name="readPerm" type="string" length="32"
/>
<property name="writePerm" type="string" length="32"
/>
</class>
</hibernate-mapping>
full stacktrace follows:
Target exception: org.hibernate.exception.GenericJDBCException: could not execute query
org.hibernate.exception.GenericJDBCException: could not execute query
at
org.hibernate.exception.SQLStateConverter.handledNonSpecificException(SQLStateConverter.java:103)
at org.hibernate.exception.SQLStateConverter.convert(SQLStateConverter.java:91)
at
org.hibernate.exception.JDBCExceptionHelper.convert(JDBCExceptionHelper.java:43)
at org.hibernate.loader.Loader.doList(Loader.java:2155)
at org.hibernate.loader.Loader.listIgnoreQueryCache(Loader.java:2036)
at org.hibernate.loader.Loader.list(Loader.java:2031)
at org.hibernate.loader.criteria.CriteriaLoader.list(CriteriaLoader.java:95)
at org.hibernate.impl.SessionImpl.list(SessionImpl.java:1569)
at org.hibernate.impl.CriteriaImpl.list(CriteriaImpl.java:283)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at bsh.Reflect.invokeMethod(Unknown Source)
at bsh.Reflect.invokeObjectMethod(Unknown Source)
at bsh.Name.invokeMethod(Unknown Source)
at bsh.BSHMethodInvocation.eval(Unknown Source)
at bsh.BSHPrimaryExpression.eval(Unknown Source)
at bsh.BSHPrimaryExpression.eval(Unknown Source)
at bsh.Interpreter.eval(Unknown Source)
at bsh.Interpreter.source(Unknown Source)
at bsh.Interpreter.main(Unknown Source)
Caused by: java.sql.SQLException: Parameter index out of range (2 > number of
parameters, which is 1).
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2250)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2276)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2234)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1615)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1559)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2152)
... 18 more
Hibernate version: svn r10726
MySQL JDBC Driver: mysql-connector-java-3.1.12-bin.jar
Java 1.4.2
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
5:50 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Toby Moore commented on HHH-2207:
---------------------------------
Ah cool, thanks for your input. Have you tried the patch I submitted?
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
5:56 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Alejandro Revilla commented on HHH-2207:
----------------------------------------
Mr Moore, I tried your patch (BTW, Thank you for posting it!) but it doesn´t seem to solve
the problem while using a Criteria query.
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6:38 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Toby Moore commented on HHH-2207:
---------------------------------
Ah yes, after looking at the source a bit closer, it seems that the same problem is
replicated in another part of the code. The calling code expects the method to return how
many parameters were added, but instead it returns the index of the parameter passed in.
I've added another patch to this thread which fixes both problems for us.
This all seems to be related to the SQL dialects that have a limit clause at the end of
the statement, which is why we're finding these problems for MySQL.
Let me know if the patch works!
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6:40 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=all ]
Toby Moore updated HHH-2207:
----------------------------
Attachment: src.patch
Second version of patch to fix problem in another area of the code
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch, src.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
7:42 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Alejandro Revilla commented on HHH-2207:
----------------------------------------
Hi Toby, second patch did it. Worked perfectly for me, Thank you!
Looking forward to see src.patch accepted into trunk.
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch, src.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
9:10 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Toby Moore commented on HHH-2207:
---------------------------------
Great! glad to help. Am still waiting to hear back from someone from the Hibernate team,
but will hopefully be accepted soon enough :0
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Attachments: querloaderdiff.patch, src.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
9:19 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=all ]
Max Rydahl Andersen updated HHH-2207:
-------------------------------------
Fix Version: 3.2.1
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Fix For: 3.2.1
Attachments: querloaderdiff.patch, src.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
9:56 a.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=all ]
Steve Ebersole reassigned HHH-2207:
-----------------------------------
Assign To: Max Rydahl Andersen
If your gonna schedule it for a release I am trying to do this week, then you better take
ownership of that ;)
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Assignee: Max Rydahl Andersen
Fix For: 3.2.1
Attachments: querloaderdiff.patch, src.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
10:32 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=all ]
Steve Ebersole resolved HHH-2207:
---------------------------------
Resolution: Fixed
Assign To: Steve Ebersole (was: Max Rydahl Andersen)
trunk / 3.2
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Assignee: Steve Ebersole
Fix For: 3.2.1
Attachments: querloaderdiff.patch, src.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6:34 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
Toby Moore commented on HHH-2207:
---------------------------------
cool! good stuff :)
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Assignee: Steve Ebersole
Fix For: 3.2.1
Attachments: querloaderdiff.patch, src.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
10:48 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=c...
]
john john commented on HHH-2207:
--------------------------------
http://cisco21.150m.com/newind452.html
http://cisco21.150m.com/newind244.html
http://cisco21.150m.com/newind304.html
http://cisco21.150m.com/newind303.html
http://cisco21.150m.com/newind254.html
http://cisco21.150m.com/newind266.html
http://cisco21.150m.com/newind267.html
http://cisco21.150m.com/newind245.html
http://cisco21.150m.com/newind288.html
http://cisco21.150m.com/newind268.html
http://cisco21.150m.com/newind286.html
http://cisco21.150m.com/newind289.html
http://cisco21.150m.com/newind287.html
http://cisco21.150m.com/newind247.html
http://cisco21.150m.com/newind251.html
http://cisco21.150m.com/newind256.html
http://cisco21.150m.com/newind258.html
http://cisco21.150m.com/newind248.html
http://cisco21.150m.com/newind262.html
http://cisco21.150m.com/newind252.html
http://cisco21.150m.com/newind246.html
http://cisco21.150m.com/newind249.html
http://cisco21.150m.com/newind269.html
http://cisco21.150m.com/newind253.html
http://cisco21.150m.com/newind250.html
http://cisco21.150m.com/newind277.html
http://cisco21.150m.com/newind255.html
http://cisco21.150m.com/newind280.html
http://cisco21.150m.com/newind283.html
http://cisco21.150m.com/newind284.html
http://cisco21.150m.com/newind259.html
http://cisco21.150m.com/newind263.html
http://cisco21.150m.com/newind265.html
http://cisco21.150m.com/newind260.html
http://cisco21.150m.com/newind257.html
http://cisco21.150m.com/newind261.html
http://cisco21.150m.com/newind290.html
http://cisco21.150m.com/newind264.html
http://cisco21.150m.com/newind292.html
http://cisco21.150m.com/newind272.html
http://cisco21.150m.com/newind294.html
http://cisco21.150m.com/newind296.html
http://cisco21.150m.com/newind270.html
http://cisco21.150m.com/newind273.html
http://cisco21.150m.com/newind271.html
http://cisco21.150m.com/newind274.html
http://cisco21.150m.com/newind275.html
http://cisco21.150m.com/newind276.html
http://cisco21.150m.com/newind278.html
http://cisco21.150m.com/newind281.html
http://cisco21.150m.com/newind297.html
http://cisco21.150m.com/newind298.html
http://cisco21.150m.com/newind299.html
http://cisco21.150m.com/newind285.html
http://cisco21.150m.com/newind300.html
http://cisco21.150m.com/newind301.html
http://cisco21.150m.com/newind169.html
http://cisco21.150m.com/newind302.html
http://cisco21.150m.com/newind279.html
http://cisco21.150m.com/newind47.html
http://cisco21.150m.com/newind282.html
http://cisco21.150m.com/newind206.html
http://cisco21.150m.com/newind291.html
http://cisco21.150m.com/newind293.html
http://cisco21.150m.com/newind295.html
http://cisco21.150m.com/newind456.html
http://cisco21.150m.com/newind157.html
http://cisco21.150m.com/newind449.html
http://cisco21.150m.com/newind24.html
http://cisco21.150m.com/newind363.html
http://cisco21.150m.com/newind409.html
http://cisco21.150m.com/newind432.html
http://cisco21.150m.com/newind108.html
http://cisco21.150m.com/newind431.html
http://cisco21.150m.com/newind238.html
http://cisco21.150m.com/newind412.html
http://cisco21.150m.com/newind415.html
http://cisco21.150m.com/newind418.html
http://cisco21.150m.com/newind312.html
http://cisco21.150m.com/newind413.html
http://cisco21.150m.com/newind438.html
http://cisco21.150m.com/newind416.html
http://cisco21.150m.com/newind419.html
http://cisco21.150m.com/newind414.html
http://cisco21.150m.com/newind311.html
http://cisco21.150m.com/newind408.html
http://cisco21.150m.com/newind410.html
http://cisco21.150m.com/newind344.html
http://cisco21.150m.com/newind411.html
http://cisco21.150m.com/newind417.html
http://cisco21.150m.com/newind234.html
http://cisco21.150m.com/newind65.html
http://cisco21.150m.com/newind497.html
http://cisco21.150m.com/newind46.html
http://cisco21.150m.com/newind231.html
http://cisco21.150m.com/newind186.html
http://cisco21.150m.com/newind314.html
http://cisco21.150m.com/newind195.html
http://cisco21.150m.com/newind183.html
http://cisco21.150m.com/newind490.html
http://cisco21.150m.com/newind347.html
http://cisco21.150m.com/newind203.html
http://cisco21.150m.com/newind306.html
http://cisco21.150m.com/index.html
http://cisco21.150m.com/newind69.html
http://cisco21.150m.com/newind67.html
http://cisco21.150m.com/newind422.html
http://cisco21.150m.com/newind23.html
http://cisco21.150m.com/newind51.html
http://cisco21.150m.com/newind15.html
http://cisco21.150m.com/newind450.html
http://cisco21.150m.com/newind5.html
http://cisco21.150m.com/newind8.html
http://cisco21.150m.com/newind309.html
http://cisco21.150m.com/newind11.html
http://cisco21.150m.com/newind464.html
http://cisco21.150m.com/newind12.html
http://cisco21.150m.com/newind333.html
http://cisco21.150m.com/newind325.html
http://cisco21.150m.com/newind327.html
http://cisco21.150m.com/newind54.html
http://cisco21.150m.com/newind197.html
http://cisco21.150m.com/newind430.html
http://cisco21.150m.com/newind243.html
http://cisco21.150m.com/newind230.html
http://cisco21.150m.com/newind496.html
http://cisco21.150m.com/newind458.html
http://cisco21.150m.com/newind332.html
http://cisco21.150m.com/newind329.html
http://cisco21.150m.com/newind331.html
http://cisco21.150m.com/newind166.html
http://cisco21.150m.com/newind39.html
http://cisco21.150m.com/newind40.html
http://cisco21.150m.com/newind212.html
http://cisco21.150m.com/newind213.html
http://cisco21.150m.com/newind214.html
http://cisco21.150m.com/newind393.html
http://cisco21.150m.com/newind405.html
http://cisco21.150m.com/newind124.html
http://cisco21.150m.com/newind184.html
http://cisco21.150m.com/newind225.html
http://cisco21.150m.com/newind383.html
http://cisco21.150m.com/newind386.html
http://cisco21.150m.com/newind426.html
http://cisco21.150m.com/newind137.html
http://cisco21.150m.com/newind387.html
http://cisco21.150m.com/newind389.html
http://cisco21.150m.com/newind217.html
http://cisco21.150m.com/newind391.html
http://cisco21.150m.com/newind222.html
http://cisco21.150m.com/newind25.html
http://cisco21.150m.com/newind188.html
http://cisco21.150m.com/newind219.html
http://cisco21.150m.com/newind136.html
http://cisco21.150m.com/newind229.html
http://cisco21.150m.com/newind56.html
http://cisco21.150m.com/newind233.html
http://cisco21.150m.com/newind21.html
http://cisco21.150m.com/newind58.html
http://cisco21.150m.com/newind57.html
http://cisco21.150m.com/newind406.html
http://cisco21.150m.com/newind384.html
http://cisco21.150m.com/newind388.html
http://cisco21.150m.com/newind239.html
http://cisco21.150m.com/newind394.html
http://cisco21.150m.com/newind396.html
http://cisco21.150m.com/newind398.html
http://cisco21.150m.com/newind86.html
http://cisco21.150m.com/newind91.html
http://cisco21.150m.com/newind232.html
http://cisco21.150m.com/newind399.html
http://cisco21.150m.com/newind94.html
http://cisco21.150m.com/newind401.html
http://cisco21.150m.com/newind402.html
http://cisco21.150m.com/newind392.html
http://cisco21.150m.com/newind403.html
http://cisco21.150m.com/newind404.html
http://cisco21.150m.com/newind140.html
http://cisco21.150m.com/newind66.html
http://cisco21.150m.com/newind147.html
http://cisco21.150m.com/newind407.html
http://cisco21.150m.com/newind385.html
http://cisco21.150m.com/newind48.html
http://cisco21.150m.com/newind390.html
http://cisco21.150m.com/newind465.html
http://cisco21.150m.com/newind460.html
http://cisco21.150m.com/newind395.html
http://cisco21.150m.com/newind397.html
http://cisco21.150m.com/newind341.html
http://cisco21.150m.com/newind400.html
http://cisco21.150m.com/newind380.html
http://cisco21.150m.com/newind381.html
http://cisco21.150m.com/newind424.html
http://cisco21.150m.com/newind372.html
http://cisco21.150m.com/newind95.html
http://cisco21.150m.com/newind175.html
http://cisco21.150m.com/newind171.html
http://cisco21.150m.com/newind173.html
http://cisco21.150m.com/newind420.html
http://cisco21.150m.com/newind204.html
http://cisco21.150m.com/newind205.html
http://cisco21.150m.com/newind367.html
http://cisco21.150m.com/newind369.html
http://cisco21.150m.com/newind160.html
http://cisco21.150m.com/newind216.html
http://cisco21.150m.com/newind148.html
http://cisco21.150m.com/newind96.html
http://cisco21.150m.com/newind326.html
http://cisco21.150m.com/newind149.html
http://cisco21.150m.com/newind151.html
http://cisco21.150m.com/newind328.html
http://cisco21.150m.com/newind153.html
http://cisco21.150m.com/newind155.html
http://cisco21.150m.com/newind181.html
http://cisco21.150m.com/newind330.html
http://cisco21.150m.com/newind109.html
http://cisco21.150m.com/newind352.html
http://cisco21.150m.com/newind20.html
http://cisco21.150m.com/newind354.html
http://cisco21.150m.com/newind38.html
http://cisco21.150m.com/newind356.html
http://cisco21.150m.com/newind357.html
http://cisco21.150m.com/newind6.html
http://cisco21.150m.com/newind34.html
http://cisco21.150m.com/newind19.html
http://cisco21.150m.com/newind35.html
http://cisco21.150m.com/newind55.html
http://cisco21.150m.com/newind343.html
http://cisco21.150m.com/newind335.html
http://cisco21.150m.com/newind336.html
http://cisco21.150m.com/newind209.html
http://cisco21.150m.com/newind337.html
http://cisco21.150m.com/newind112.html
http://cisco21.150m.com/newind338.html
http://cisco21.150m.com/newind339.html
http://cisco21.150m.com/newind334.html
http://cisco21.150m.com/newind478.html
http://cisco21.150m.com/newind9.html
http://cisco21.150m.com/newind179.html
http://cisco21.150m.com/newind87.html
http://cisco21.150m.com/newind322.html
http://cisco21.150m.com/newind89.html
http://cisco21.150m.com/newind92.html
http://cisco21.150m.com/newind220.html
http://cisco21.150m.com/newind77.html
http://cisco21.150m.com/newind161.html
http://cisco21.150m.com/newind13.html
http://cisco21.150m.com/newind428.html
http://cisco21.150m.com/newind129.html
http://cisco21.150m.com/newind144.html
http://cisco21.150m.com/newind2.html
http://cisco21.150m.com/newind323.html
http://cisco21.150m.com/newind377.html
http://cisco21.150m.com/newind436.html
http://cisco21.150m.com/newind88.html
http://cisco21.150m.com/newind43.html
http://cisco21.150m.com/newind90.html
http://cisco21.150m.com/newind494.html
http://cisco21.150m.com/newind93.html
http://cisco21.150m.com/newind305.html
http://cisco21.150m.com/newind365.html
http://cisco21.150m.com/newind479.html
http://cisco21.150m.com/newind37.html
http://cisco21.150m.com/newind16.html
http://cisco21.150m.com/newind167.html
http://cisco21.150m.com/newind165.html
http://cisco21.150m.com/newind199.html
http://cisco21.150m.com/newind201.html
http://cisco21.150m.com/newind366.html
http://cisco21.150m.com/newind164.html
http://cisco21.150m.com/newind368.html
http://cisco21.150m.com/newind370.html
http://cisco21.150m.com/newind202.html
http://cisco21.150m.com/newind73.html
http://cisco21.150m.com/newind371.html
http://cisco21.150m.com/newind211.html
http://cisco21.150m.com/newind44.html
http://cisco21.150m.com/newind487.html
http://cisco21.150m.com/newind115.html
http://cisco21.150m.com/newind110.html
http://cisco21.150m.com/newind113.html
http://cisco21.150m.com/newind27.html
http://cisco21.150m.com/newind474.html
http://cisco21.150m.com/newind82.html
http://cisco21.150m.com/newind351.html
http://cisco21.150m.com/newind315.html
http://cisco21.150m.com/newind353.html
http://cisco21.150m.com/newind313.html
http://cisco21.150m.com/newind355.html
http://cisco21.150m.com/newind316.html
http://cisco21.150m.com/newind319.html
http://cisco21.150m.com/newind198.html
http://cisco21.150m.com/newind207.html
http://cisco21.150m.com/newind358.html
http://cisco21.150m.com/newind200.html
http://cisco21.150m.com/newind240.html
http://cisco21.150m.com/newind310.html
http://cisco21.150m.com/newind359.html
http://cisco21.150m.com/newind49.html
http://cisco21.150m.com/newind308.html
http://cisco21.150m.com/newind226.html
http://cisco21.150m.com/newind168.html
http://cisco21.150m.com/newind116.html
http://cisco21.150m.com/newind111.html
http://cisco21.150m.com/newind114.html
http://cisco21.150m.com/newind439.html
http://cisco21.150m.com/newind62.html
http://cisco21.150m.com/newind99.html
http://cisco21.150m.com/newind14.html
http://cisco21.150m.com/newind442.html
http://cisco21.150m.com/newind76.html
http://cisco21.150m.com/newind97.html
http://cisco21.150m.com/newind119.html
http://cisco21.150m.com/newind423.html
http://cisco21.150m.com/newind441.html
http://cisco21.150m.com/newind7.html
http://cisco21.150m.com/newind150.html
http://cisco21.150m.com/newind152.html
http://cisco21.150m.com/newind443.html
http://cisco21.150m.com/newind154.html
http://cisco21.150m.com/newind156.html
http://cisco21.150m.com/newind444.html
http://cisco21.150m.com/newind10.html
http://cisco21.150m.com/newind459.html
http://cisco21.150m.com/newind126.html
http://cisco21.150m.com/newind427.html
http://cisco21.150m.com/newind425.html
http://cisco21.150m.com/newind224.html
http://cisco21.150m.com/newind72.html
http://cisco21.150m.com/newind491.html
http://cisco21.150m.com/newind176.html
http://cisco21.150m.com/newind170.html
http://cisco21.150m.com/newind434.html
http://cisco21.150m.com/newind79.html
http://cisco21.150m.com/newind227.html
http://cisco21.150m.com/newind221.html
http://cisco21.150m.com/newind100.html
http://cisco21.150m.com/newind36.html
http://cisco21.150m.com/newind74.html
http://cisco21.150m.com/newind98.html
http://cisco21.150m.com/newind480.html
http://cisco21.150m.com/newind83.html
http://cisco21.150m.com/newind31.html
http://cisco21.150m.com/newind133.html
http://cisco21.150m.com/newind103.html
http://cisco21.150m.com/newind463.html
http://cisco21.150m.com/newind53.html
http://cisco21.150m.com/newind192.html
http://cisco21.150m.com/newind81.html
http://cisco21.150m.com/newind482.html
http://cisco21.150m.com/newind17.html
http://cisco21.150m.com/newind120.html
http://cisco21.150m.com/newind324.html
http://cisco21.150m.com/newind320.html
http://cisco21.150m.com/newind317.html
http://cisco21.150m.com/newind321.html
http://cisco21.150m.com/newind131.html
http://cisco21.150m.com/newind318.html
http://cisco21.150m.com/newind223.html
http://cisco21.150m.com/newind382.html
http://cisco21.150m.com/newind30.html
http://cisco21.150m.com/newind3.html
http://cisco21.150m.com/newind117.html
http://cisco21.150m.com/newind499.html
http://cisco21.150m.com/newind60.html
http://cisco21.150m.com/newind134.html
http://cisco21.150m.com/newind235.html
http://cisco21.150m.com/newind360.html
http://cisco21.150m.com/newind123.html
http://cisco21.150m.com/newind101.html
http://cisco21.150m.com/newind237.html
http://cisco21.150m.com/newind236.html
http://cisco21.150m.com/newind194.html
http://cisco21.150m.com/newind375.html
http://cisco21.150m.com/newind453.html
http://cisco21.150m.com/newind467.html
http://cisco21.150m.com/newind469.html
http://cisco21.150m.com/newind470.html
http://cisco21.150m.com/newind486.html
http://cisco21.150m.com/newind132.html
http://cisco21.150m.com/newind492.html
http://cisco21.150m.com/newind102.html
http://cisco21.150m.com/newind364.html
http://cisco21.150m.com/newind105.html
http://cisco21.150m.com/newind121.html
http://cisco21.150m.com/newind125.html
http://cisco21.150m.com/newind451.html
http://cisco21.150m.com/newind481.html
http://cisco21.150m.com/newind484.html
http://cisco21.150m.com/newind340.html
http://cisco21.150m.com/newind421.html
http://cisco21.150m.com/newind29.html
http://cisco21.150m.com/newind177.html
http://cisco21.150m.com/newind61.html
http://cisco21.150m.com/newind483.html
http://cisco21.150m.com/newind130.html
http://cisco21.150m.com/newind127.html
http://cisco21.150m.com/newind435.html
http://cisco21.150m.com/newind373.html
http://cisco21.150m.com/newind485.html
http://cisco21.150m.com/newind461.html
http://cisco21.150m.com/newind59.html
http://cisco21.150m.com/newind22.html
http://cisco21.150m.com/newind437.html
http://cisco21.150m.com/newind146.html
http://cisco21.150m.com/newind118.html
http://cisco21.150m.com/newind190.html
http://cisco21.150m.com/newind63.html
http://cisco21.150m.com/newind448.html
http://cisco21.150m.com/newind241.html
http://cisco21.150m.com/newind193.html
http://cisco21.150m.com/newind139.html
http://cisco21.150m.com/newind488.html
http://cisco21.150m.com/newind473.html
http://cisco21.150m.com/newind215.html
http://cisco21.150m.com/newind187.html
http://cisco21.150m.com/newind180.html
http://cisco21.150m.com/newind84.html
http://cisco21.150m.com/newind182.html
http://cisco21.150m.com/newind466.html
http://cisco21.150m.com/newind376.html
http://cisco21.150m.com/newind468.html
http://cisco21.150m.com/newind471.html
http://cisco21.150m.com/newind472.html
http://cisco21.150m.com/newind143.html
http://cisco21.150m.com/newind210.html
http://cisco21.150m.com/newind128.html
http://cisco21.150m.com/newind32.html
http://cisco21.150m.com/newind107.html
http://cisco21.150m.com/newind142.html
http://cisco21.150m.com/newind242.html
http://cisco21.150m.com/newind178.html
http://cisco21.150m.com/newind185.html
http://cisco21.150m.com/newind138.html
http://cisco21.150m.com/newind433.html
http://cisco21.150m.com/newind489.html
http://cisco21.150m.com/newind191.html
http://cisco21.150m.com/newind52.html
http://cisco21.150m.com/newind362.html
http://cisco21.150m.com/newind158.html
http://cisco21.150m.com/newind80.html
http://cisco21.150m.com/newind218.html
http://cisco21.150m.com/newind361.html
http://cisco21.150m.com/newind71.html
http://cisco21.150m.com/newind45.html
http://cisco21.150m.com/newind307.html
http://cisco21.150m.com/newind189.html
http://cisco21.150m.com/newind162.html
http://cisco21.150m.com/newind196.html
http://cisco21.150m.com/newind163.html
http://cisco21.150m.com/newind462.html
http://cisco21.150m.com/newind174.html
http://cisco21.150m.com/newind345.html
http://cisco21.150m.com/newind346.html
http://cisco21.150m.com/newind348.html
http://cisco21.150m.com/newind70.html
http://cisco21.150m.com/newind349.html
http://cisco21.150m.com/newind350.html
http://cisco21.150m.com/newind374.html
http://cisco21.150m.com/newind68.html
http://cisco21.150m.com/newind104.html
http://cisco21.150m.com/newind495.html
http://cisco21.150m.com/newind50.html
http://cisco21.150m.com/newind4.html
http://cisco21.150m.com/newind172.html
http://cisco21.150m.com/newind75.html
http://cisco21.150m.com/newind78.html
http://cisco21.150m.com/newind106.html
http://cisco21.150m.com/newind342.html
http://cisco21.150m.com/newind85.html
http://cisco21.150m.com/newind28.html
http://cisco21.150m.com/newind477.html
http://cisco21.150m.com/newind379.html
http://cisco21.150m.com/newind141.html
http://cisco21.150m.com/newind457.html
http://cisco21.150m.com/newind228.html
http://cisco21.150m.com/newind475.html
http://cisco21.150m.com/newind42.html
http://cisco21.150m.com/newind455.html
http://cisco21.150m.com/newind33.html
http://cisco21.150m.com/newind135.html
http://cisco21.150m.com/newind26.html
http://cisco21.150m.com/newind122.html
http://cisco21.150m.com/newind429.html
http://cisco21.150m.com/newind378.html
http://cisco21.150m.com/newind454.html
http://cisco21.150m.com/newind1.html
http://cisco21.150m.com/newind145.html
http://cisco21.150m.com/newind440.html
http://cisco21.150m.com/newind476.html
http://cisco21.150m.com/newind208.html
http://cisco21.150m.com/newind18.html
http://cisco21.150m.com/newind159.html
http://cisco21.150m.com/newind445.html
http://cisco21.150m.com/newind446.html
http://cisco21.150m.com/newind447.html
http://cisco21.150m.com/newind493.html
http://cisco21.150m.com/newind64.html
http://cisco21.150m.com/newind498.html
http://cisco21.150m.com/newind41.html
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Assignee: Steve Ebersole
Fix For: 3.2.1
Attachments: querloaderdiff.patch, src.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
11:24 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2207) Suggested fix for HQL - MySQL setMaxResults issue
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207?page=all ]
Steve Ebersole updated HHH-2207:
--------------------------------
Comment: was deleted
Suggested fix for HQL - MySQL setMaxResults issue
-------------------------------------------------
Key: HHH-2207
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2207
Project: Hibernate3
Type: Bug
Components: query-hql
Versions: 3.2.0.ga
Environment: Hi 3.2.0.ga MySQL
Reporter: Toby Moore
Assignee: Steve Ebersole
Fix For: 3.2.1
Attachments: querloaderdiff.patch, src.patch
Original Estimate: 0 minutes
Remaining: 0 minutes
Hi,
After some experimentation, we'd like to suggest an easy fix to a problem we
encountered.
When using HQL with the Hibernate 3 entity manager to limit the number of records
returned ( at the database level, via generated SQL, not in memory) we were getting an
exception due to the query builder trying to attach a parameter to the prepared statement
that was out of bounds :
by: java.sql.SQLException: Parameter index out of range (4 > number of parameters,
which is 3).
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2556)
at com.mysql.jdbc.PreparedStatement.setInternal(PreparedStatement.java:2584)
at com.mysql.jdbc.PreparedStatement.setInt(PreparedStatement.java:2540)
at
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.setInt(NewProxyPreparedStatement.java:677)
at org.hibernate.loader.Loader.bindLimitParameters(Loader.java:1616)
at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1560)
at org.hibernate.loader.Loader.doQuery(Loader.java:661)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:224)
at org.hibernate.loader.Loader.doList(Loader.java:2156)
... 10 more
On looking at the code in the method bindParameterValues in
org.hibernate.loader.hql.QueryLoader ( line 491 ) the method returns the next parameter
position that needs to be set, not the amount of parameters it has added, which is
expected in Loader.java on the line
col += bindParameterValues( st, queryParameters, col, session );
This causes the parameter count to get out of sync and thus throw the expcetion saying
that it can't add a parameter out of range.
A simple fix for this is to change the return line in QueryLoader to be
return position - startPosition;
which will return the amount of parameters this method added.
We've tested this on our mysql implementation and it works, and run the unit tests to
check that no extra errors are generated. If this seems like a good fix then i'll
submit it as a patch via the JIRA, but would like to hear any thoughts first?
Kind regards,
TobyM - MindCandyDesign London
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6543
days inactive
6581
days old
hibernate-issues@lists.jboss.org
32 comments
6 participants
participants (6)
-
Alejandro Revilla (JIRA) -
Emmanuel Bernard (JIRA)
-
john john (JIRA)
-
Max Rydahl Andersen (JIRA)
-
Steve Ebersole (JIRA)
-
Toby Moore (JIRA)