Bad code in FastClass.equals ---------------------------- Key: HHH-1646 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1646 Project: Hibernate3 Type: Bug

Versions: 3.1.3, 3.2.0 cr1 Environment: 3.2.0 Reporter: Niels Harremoës Assignee: Scott Marlow Priority: Blocker Attachments: FastClass.patch Original Estimate: 3 minutes Remaining: 3 minutes In FastClass, the equals method is: public boolean equals(Object o) { if ( o == null || ( o instanceof FastClass ) ) { return false; } return this.type.equals( ( ( FastClass ) o ).type ); } There's a missing ! - the first line should be if ( o == null || ! ( o instanceof FastClass ) ) {