Re: [keycloak-dev] Provider's "disabled" and "enabled" flags

Hey, As Stefan noticed, some providers (including the one I created a few weeks back) check "disabled" flag from the configuration [1][2]. Stefan pointed out, that our Subsystem (and Keycloak internals) already check the "enabled" flag [3] on the SPI level. If the SPI is disabled, it won't be initialized at all, so all the disabled/enabled checks in ProviderFactory#init seems to be redundant. If I didn't miss anything and you all agree with me, I'd like to remove this kind of checks. Thanks, Sebastian [1] https://github.com/keycloak/keycloak/blob/5f9feee3f86e3d856063c8b6d355e30... [2] https://github.com/keycloak/keycloak/blob/3afbdd3ea3d8eb1ef339f2c0c46fb57... [3] https://github.com/keycloak/keycloak/blob/505cf5b25184c59ca85de63b082eb12... _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev