Re: [keycloak-dev] Create a PR for handling username/password with whitespace in keycloak-containers

Ok, then I will proceed, do you want a ticket in Jira as well for this? Den ons 9 okt. 2019 kl 11:28 skrev Stian Thorgersen <sthorger(a)redhat.com&gt;: > Devil is in the detail, but sounds like a good idea :) > > On Tue, 8 Oct 2019 at 19:53, Erik Lindskog <erik.lindskog(a)codemill.se&gt; > wrote: > >> Hello again, >> >> I have a follow up PR on my way. The plan is to add -e to bash so the >> entrypoint bails if there are errors from subcommands together with some >> improvements suggested by the shellcheck tool. >> Is this something that you are interested in? >> https://github.com/koalaman/shellcheck >> >> Best Regards >> /Erik >> >> Den ons 2 okt. 2019 kl 14:53 skrev Erik Lindskog < >> erik.lindskog(a)codemill.se >> >: >> >> > Hello! >> > >> > I found out that the current docker-entrypoint.sh doesn't handle if you >> > try to set a password that contains whitespace. So the plan is just to >> > create a PR out of this if it is ok? >> > >> > >> https://github.com/cartmanume/keycloak-containers/commit/4b09e830a2151ccb... >> > >> > >> > Regards >> > /Erik >> > >> > >> >> -- >> Erik Lindskog | Team Leader / Senior Developer >> erik.lindskog(a)codemill.se | +46702271273 >> www.codemill.se <http://codemill.se> | Umeå, Sweden >> <https://goo.gl/maps/xJo7b> >> _______________________________________________ >> keycloak-dev mailing list >> keycloak-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/keycloak-dev > > -- Erik Lindskog | Team Leader / Senior Developer erik.lindskog(a)codemill.se | +46702271273 www.codemill.se <http://codemill.se> | Umeå, Sweden <https://goo.gl/maps/xJo7b>