Undertow adapter sounds good.
We would still need some Arquillian tests though. To test web applications Arquillian
Drone is really good. But, you wouldn't run those tests on a normal build as they are
slow (and open Firefox/Chrome windows). To run those you'd enabled
'arq-remote' or 'arq-embed' mvn profiles.
I was also wondering if instead of forwarding to securityFailure + rollback transaction if
we could throw a SecurityFailure exception. Then add an exception handler that rollsback
the transaction and does the forwarding. To prevent it from being a performance issue we
could simply override fillInStackTrace to prevent it from generating the stack trace.
If you're happy with servlet filter + exception mapper approach I can sort it out now.
To make sure tests continue to function I can just leave KeycloakSessionCleanupFilter
until the Undertow adapter is ready.
BTW one way to run Arquillian tests quicker is to use the remote container. This
doesn't start/stop the container for each test making it a lot quicker to run during
development.
----- Original Message -----
From: "Bill Burke" <bburke(a)redhat.com>
To: "Stian Thorgersen" <stian(a)redhat.com>
Cc: keycloak-dev(a)lists.jboss.org
Sent: Thursday, 15 August, 2013 12:53:37 PM
Subject: Re: What next
Arquillian seemed like a beast last time I used it. Wildfly/JBoss takes
seconds to boot up and tear down. Slow compared to the milliseconds I'm
used to. Add to this that we'd have to weave in the latest version of
Resteasy... What about Undertow? If I do a resteasy release with an
Undertow adapter would that be a happy medium?
On 8/15/2013 4:17 AM, Stian Thorgersen wrote:
> Ok,
>
> I'll add registration and once that's working I can start looking at adding
> support for Google Authenticator.
>
> Another thing, I was thinking we could use Arquillian for testing. It's
> simple and quick to use, and there's also Arquillian Drone which is very
> good to do full end-to-end tests in the browser. At the same time this
> would allow us to use a servlet filter to close the sessions. If you're
> happy with Arquillian (and servlet filter approach to closing sessions). I
> can port the existing tests to Arquillian.
>
> I probably also need to add some tests around social login.
>
> ----- Original Message -----
>> From: "Bill Burke" <bburke(a)redhat.com>
>> To: "Stian Thorgersen" <stian(a)redhat.com>
>> Cc: keycloak-dev(a)lists.jboss.org
>> Sent: Wednesday, 14 August, 2013 2:38:21 PM
>> Subject: Re: What next
>>
>> Working on registration would be great. Hopefully incorporating some of
>> the things we talked about earlier. What I would love to see is support
>> for TOTP and Google Authenticator for registration and login. Much of
>> the code is already set up to support TOTP, just the setup is missing.
>> I just think TOTP effects the design of the registration page flow so it
>> might be a good idea to incorporate that too and I don't think it would
>> be that much of a stretch to do so.
>>
>> Here's a good blog I found on dealing with Google Authenticator:
>>
>>
https://weblogs.java.net/blog/evanx/archive/2012/11/07/google-authenticat...
>>
>> It shows you Java code and how to set up the scannable bar code.
>>
>> I actually need to focus on my JAX-RS book the next few weeks as my
>> deadline is next month. I'm actually writing a section on OAuth and
>> want to include an example that uses Resteasy's OAuth stuff on Wildfly.
>> Which will require creating Wildfly integration which will be good for
>> Keycloak too :)
>>
>> On 8/14/2013 8:17 AM, Stian Thorgersen wrote:
>>> I've finished the work on login/registration forms for SaaS and Realm.
>>> What
>>> would you like me to work on next?
>>>
>>> One thing I thought I could do was to add registration for Realms. This
>>> should basically be adding registerPage + processRegister to
>>> TokenService.
>>> In the process I could add initialRoles to RealmModel?
>>>
>>
>> --
>> Bill Burke
>> JBoss, a division of Red Hat
>>
http://bill.burkecentral.com
>>
--
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com