Since last week, I've added the support for running the adapter tests on
embedded undertow and some are run during default travis build too.
Basically everything in package
"org.keycloak.testsuite.adapter.undertow.servlet" for now. This also
allows running adapter tests from IDE, which is great for development
and debugging. Previously you either needed to develop adapters in the
old testsuite or develop against wildfly server, which sucks (constantly
rebuilding stuff with maven, copying the jars to modules etc).
This should help to avoid most of regressions in adapters, which should
be catched during travis build now. Unfortunately it won't help with the
issue like KEYCLOAK-4017 because the modules inside
testsuite/integration-arquillian/tests/other/adapters/jboss/ are
"detached" from the main project, so removing the class in IDE won't
automatically remove the subclasses in those detached modules. I wonder
if we can improve to avoid those detached modules and abstract classes
with tests and instead have just the single class with particular
adapter test, which will just work with any app server profile (
-Papp-server-wildfly, -Pauth-server-eap etc)?
Marek
On 05/12/16 12:53, Hynek Mlnarik wrote:
Speaking of the tests, we seem not to run any of the adapter test
suites. I believe that running at least adapter tests for wildfly
would be beneficial, preventing e.g. [1]. WDYT?
[1]
https://issues.jboss.org/browse/KEYCLOAK-4017
On Mon, Dec 5, 2016 at 8:39 AM, Marek Posolda <mposolda(a)redhat.com
<mailto:mposolda@redhat.com>> wrote:
Fyi. On Friday afternoon, I've found the issue that travis didn't run
all the tests from the testsuite. And PartialImportTest was the one,
which wasn't executed. See
https://issues.jboss.org/browse/KEYCLOAK-4021
<
https://issues.jboss.org/browse/KEYCLOAK-4021>
However with the travis fix, all the tests were passing (including
PartialImportTest). So it seems this test was just failing
randomly (not
always)?
Now I can see in latest travis build that PartialImportTest passes.
Marek
On 03/12/16 17:36, Bill Burke wrote:
> I just noticed that my local build fails while travis passes.
The bug is
> really something travis should have picked up, specifically the
> PartialImportsTest was removing an identity provider. The JPA
> removeIdenittyProviderByAlias method was wrong as it was trying
to load
> an IdentityProviderModel after it was removed thus resulting in a
> Hibernate error. Travis did not pick this up which makes me
wonder if
> the test is even running.
>
> FYI, i have a pull request that fixes this that is incoming. The
bug,
> not travis.
>
> Bill
>
>
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev(a)lists.jboss.org <mailto:keycloak-dev@lists.jboss.org>
>
https://lists.jboss.org/mailman/listinfo/keycloak-dev
<
https://lists.jboss.org/mailman/listinfo/keycloak-dev>
_______________________________________________
keycloak-dev mailing list
keycloak-dev(a)lists.jboss.org <mailto:keycloak-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/keycloak-dev
<
https://lists.jboss.org/mailman/listinfo/keycloak-dev>
--
--Hynek