PR is done. There is one more caveat you need to know about. If you
are using the tooltip attributes outside of the <kc-tooltip> directive,
you will need to manually specify tooltip-trigger and tooltip-placement.
Apparently, if you leave them out it now means "no triggers" and "no
placement".
For example:
<buton tooltip-trigger="mouseover mouseout" tooltip="my message"
tooltip-placement="right">Foo</button>"
On 8/21/2015 7:21 AM, Stan Silvert wrote:
On 8/20/2015 2:41 AM, Stian Thorgersen wrote:
> There are no changes that must be made - it just has to be checked that things still
work
I did find a couple of things that broke. I had to change the way
response interceptors are registered and also fix our <kc-tooltip>
directive. But those should be one-time fixes to app.js.
It would be good for everyone to at least browse the migration guide to
see if you notice any mandatory changes that need to be made. Remember,
we are moving from 1.2 to 1.4. See
https://docs.angularjs.org/guide/migration.
I'm going to do some more manual testing and if all goes well I'll
submit a PR by the end of the day.
> ----- Original Message -----
>> From: "Bill Burke" <bburke(a)redhat.com>
>> To: keycloak-dev(a)lists.jboss.org
>> Sent: Thursday, 20 August, 2015 3:15:41 AM
>> Subject: Re: [keycloak-dev] Upgrade Angular?
>>
>> Do no upgrade angular until you go over with the team any changes that
>> must be made. I don't want to be banging my head wondering why I can't
>> get my UI changes to work.
>>
>> --
>> Bill Burke
>> JBoss, a division of Red Hat
>>
http://bill.burkecentral.com
>> _______________________________________________
>> keycloak-dev mailing list
>> keycloak-dev(a)lists.jboss.org
>>
https://lists.jboss.org/mailman/listinfo/keycloak-dev
>>
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/keycloak-dev
_______________________________________________
keycloak-dev mailing list
keycloak-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev