From: "Bill Burke" <bburke(a)redhat.com&gt; To: keycloak-dev(a)lists.jboss.org Sent: Saturday, 27 September, 2014 12:04:58 AM Subject: [keycloak-dev] need more time I need more time on the refactoring of login actions. So far I've refactored all the code to * create a ClientSession when login page is visited * Pass around a "client session code" as a query parameter that references the client session * Store state within the client session instead of in query and form parameters * Refactor Social login to use a client session. This allowed me to remove the "KEYCLOAK_SOCIAL" cookie. I have all this building correctly. Next steps are to create a "protocol adapter" interface and have all login actions use this adapter instead of being hardcoded to oauth. I probably won't get this done until late next week. After that I'll start on SAML and the "protocol adapter" interface will probably go through another iteration. -- Bill Burke JBoss, a division of Red Hat http://bill.burkecentral.com _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev

From: "Bill Burke" <bburke(a)redhat.com&gt; To: "Stian Thorgersen" <stian(a)redhat.com&gt; Cc: keycloak-dev(a)lists.jboss.org Sent: Monday, 29 September, 2014 2:31:42 PM Subject: Re: [keycloak-dev] need more time I can commit my stuff now, but it is a work in progress. Up to you. API has changed a little: https://github.com/patriot1burke/keycloak/tree/master/model/api/src/main/... On 9/29/2014 2:34 AM, Stian Thorgersen wrote: > Can I commit the Infinispan user sessions provider? Or do you want me to > wait until you've commited the refactoring? > > ----- Original Message ----- >> From: "Bill Burke" <bburke(a)redhat.com&gt; >> To: keycloak-dev(a)lists.jboss.org >> Sent: Saturday, 27 September, 2014 12:04:58 AM >> Subject: [keycloak-dev] need more time >> >> I need more time on the refactoring of login actions. So far I've >> refactored all the code to >> >> * create a ClientSession when login page is visited >> * Pass around a "client session code" as a query parameter that >> references the client session >> * Store state within the client session instead of in query and form >> parameters >> * Refactor Social login to use a client session. This allowed me to >> remove the "KEYCLOAK_SOCIAL" cookie. >> >> I have all this building correctly. >> >> Next steps are to create a "protocol adapter" interface and have all >> login actions use this adapter instead of being hardcoded to oauth. I >> probably won't get this done until late next week. After that I'll >> start on SAML and the "protocol adapter" interface will probably go >> through another iteration. >> >> -- >> Bill Burke >> JBoss, a division of Red Hat >> http://bill.burkecentral.com >> _______________________________________________ >> keycloak-dev mailing list >> keycloak-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/keycloak-dev >> -- Bill Burke JBoss, a division of Red Hat http://bill.burkecentral.com

From: "Bill Burke" <bburke(a)redhat.com&gt; To: "Stian Thorgersen" <stian(a)redhat.com&gt; Cc: keycloak-dev(a)lists.jboss.org Sent: Monday, 29 September, 2014 3:04:46 PM Subject: Re: [keycloak-dev] need more time I don't think session api will change any more. But everything else will (required actions, token service, etc.)

On 9/29/2014 9:03 AM, Stian Thorgersen wrote: > Are you expecting more changes to sessions? Is it fully working atm? > > I'd like to finish clustering this week and hopefully release next week > (see separate email I sent). > > ----- Original Message ----- >> From: "Bill Burke" <bburke(a)redhat.com&gt; >> To: "Stian Thorgersen" <stian(a)redhat.com&gt; >> Cc: keycloak-dev(a)lists.jboss.org >> Sent: Monday, 29 September, 2014 2:31:42 PM >> Subject: Re: [keycloak-dev] need more time >> >> I can commit my stuff now, but it is a work in progress. Up to you. >> API has changed a little: >> >> https://github.com/patriot1burke/keycloak/tree/master/model/api/src/main/... >> >> >> On 9/29/2014 2:34 AM, Stian Thorgersen wrote: >>> Can I commit the Infinispan user sessions provider? Or do you want me to >>> wait until you've commited the refactoring? >>> >>> ----- Original Message ----- >>>> From: "Bill Burke" <bburke(a)redhat.com&gt; >>>> To: keycloak-dev(a)lists.jboss.org >>>> Sent: Saturday, 27 September, 2014 12:04:58 AM >>>> Subject: [keycloak-dev] need more time >>>> >>>> I need more time on the refactoring of login actions. So far I've >>>> refactored all the code to >>>> >>>> * create a ClientSession when login page is visited >>>> * Pass around a "client session code" as a query parameter that >>>> references the client session >>>> * Store state within the client session instead of in query and form >>>> parameters >>>> * Refactor Social login to use a client session. This allowed me to >>>> remove the "KEYCLOAK_SOCIAL" cookie. >>>> >>>> I have all this building correctly. >>>> >>>> Next steps are to create a "protocol adapter" interface and have all >>>> login actions use this adapter instead of being hardcoded to oauth. I >>>> probably won't get this done until late next week. After that I'll >>>> start on SAML and the "protocol adapter" interface will probably go >>>> through another iteration. >>>> >>>> -- >>>> Bill Burke >>>> JBoss, a division of Red Hat >>>> http://bill.burkecentral.com >>>> _______________________________________________ >>>> keycloak-dev mailing list >>>> keycloak-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/keycloak-dev >>>> >> >> -- >> Bill Burke >> JBoss, a division of Red Hat >> http://bill.burkecentral.com >> -- Bill Burke JBoss, a division of Red Hat http://bill.burkecentral.com

From: "Bill Burke" <bburke(a)redhat.com&gt; To: "Stian Thorgersen" <stian(a)redhat.com&gt; Cc: keycloak-dev(a)lists.jboss.org Sent: Monday, 29 September, 2014 3:17:32 PM Subject: Re: [keycloak-dev] need more time Why do you want to delete mem, jpa, and mongo providers? IMO, we shouldn't have a hard dependency on Infinispan. In the future, users might want a jpa or mongo provider with a cache in front of it so they can archive user sessions.

On 9/29/2014 9:11 AM, Stian Thorgersen wrote: > > > ----- Original Message ----- >> From: "Bill Burke" <bburke(a)redhat.com&gt; >> To: "Stian Thorgersen" <stian(a)redhat.com&gt; >> Cc: keycloak-dev(a)lists.jboss.org >> Sent: Monday, 29 September, 2014 3:04:46 PM >> Subject: Re: [keycloak-dev] need more time >> >> I don't think session api will change any more. But everything else >> will (required actions, token service, etc.) > > Ok - my vote is commit the changes then > > I'd like to delete mem/jpa/mongo user session providers, and only leave the > Infinispan provider. > >> >> On 9/29/2014 9:03 AM, Stian Thorgersen wrote: >>> Are you expecting more changes to sessions? Is it fully working atm? >>> >>> I'd like to finish clustering this week and hopefully release next week >>> (see separate email I sent). >>> >>> ----- Original Message ----- >>>> From: "Bill Burke" <bburke(a)redhat.com&gt; >>>> To: "Stian Thorgersen" <stian(a)redhat.com&gt; >>>> Cc: keycloak-dev(a)lists.jboss.org >>>> Sent: Monday, 29 September, 2014 2:31:42 PM >>>> Subject: Re: [keycloak-dev] need more time >>>> >>>> I can commit my stuff now, but it is a work in progress. Up to you. >>>> API has changed a little: >>>> >>>> https://github.com/patriot1burke/keycloak/tree/master/model/api/src/main/... >>>> >>>> >>>> On 9/29/2014 2:34 AM, Stian Thorgersen wrote: >>>>> Can I commit the Infinispan user sessions provider? Or do you want me >>>>> to >>>>> wait until you've commited the refactoring? >>>>> >>>>> ----- Original Message ----- >>>>>> From: "Bill Burke" <bburke(a)redhat.com&gt; >>>>>> To: keycloak-dev(a)lists.jboss.org >>>>>> Sent: Saturday, 27 September, 2014 12:04:58 AM >>>>>> Subject: [keycloak-dev] need more time >>>>>> >>>>>> I need more time on the refactoring of login actions. So far I've >>>>>> refactored all the code to >>>>>> >>>>>> * create a ClientSession when login page is visited >>>>>> * Pass around a "client session code" as a query parameter that >>>>>> references the client session >>>>>> * Store state within the client session instead of in query and form >>>>>> parameters >>>>>> * Refactor Social login to use a client session. This allowed me to >>>>>> remove the "KEYCLOAK_SOCIAL" cookie. >>>>>> >>>>>> I have all this building correctly. >>>>>> >>>>>> Next steps are to create a "protocol adapter" interface and have all >>>>>> login actions use this adapter instead of being hardcoded to oauth. I >>>>>> probably won't get this done until late next week. After that I'll >>>>>> start on SAML and the "protocol adapter" interface will probably go >>>>>> through another iteration. >>>>>> >>>>>> -- >>>>>> Bill Burke >>>>>> JBoss, a division of Red Hat >>>>>> http://bill.burkecentral.com >>>>>> _______________________________________________ >>>>>> keycloak-dev mailing list >>>>>> keycloak-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/keycloak-dev >>>>>> >>>> >>>> -- >>>> Bill Burke >>>> JBoss, a division of Red Hat >>>> http://bill.burkecentral.com >>>> >> >> -- >> Bill Burke >> JBoss, a division of Red Hat >> http://bill.burkecentral.com >> -- Bill Burke JBoss, a division of Red Hat http://bill.burkecentral.com

From: "Bill Burke" <bburke(a)redhat.com&gt; To: "Stian Thorgersen" <stian(a)redhat.com&gt; Cc: keycloak-dev(a)lists.jboss.org Sent: Monday, 29 September, 2014 5:15:06 PM Subject: Re: [keycloak-dev] need more time On 9/29/2014 10:40 AM, Stian Thorgersen wrote: > > > ----- Original Message ----- >> From: "Bill Burke" <bburke(a)redhat.com&gt; >> To: "Stian Thorgersen" <stian(a)redhat.com&gt; >> Cc: keycloak-dev(a)lists.jboss.org >> Sent: Monday, 29 September, 2014 3:17:32 PM >> Subject: Re: [keycloak-dev] need more time >> >> Why do you want to delete mem, jpa, and mongo providers? IMO, we >> shouldn't have a hard dependency on Infinispan. In the future, users >> might want a jpa or mongo provider with a cache in front of it so they >> can archive user sessions. > > Ok, I don't have an issue with leaving them. I guess not having a hard dep > on would be good. > > I was just thinking a bit of cleanup to reduce code that needs to be > maintained ;) > Remove mongo? -- Bill Burke JBoss, a division of Red Hat http://bill.burkecentral.com